All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michael Tokarev <mjt@tls.msk.ru>
To: Wei Huang <wei@redhat.com>, qemu-arm@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
	afaerber@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [PATCH Trivial V2] hw/intc/arm_gic: Remove the definition of NUM_CPU
Date: Fri, 06 Nov 2015 11:14:09 +0300	[thread overview]
Message-ID: <563C6151.9070800@msgid.tls.msk.ru> (raw)
In-Reply-To: <1446744293-32365-1-git-send-email-wei@redhat.com>

05.11.2015 20:24, Wei Huang wrote:
> arm_gic.c retrieves CPU number using either NUM_CPU(s) or s->num_cpu.
> Such mixed-uses make source code inconsistent. This patch removes
> NUM_CPU(s), which was defined for MPCore tweak long ago, and instead
> favors s->num_cpu. The source is more consistent after this small tweak.
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Wei Huang <wei@redhat.com>

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

I'm not applying this to -trivial per previous comments.

Thanks,

/mjt


WARNING: multiple messages have this Message-ID (diff)
From: Michael Tokarev <mjt@tls.msk.ru>
To: Wei Huang <wei@redhat.com>, qemu-arm@nongnu.org
Cc: qemu-trivial@nongnu.org, peter.maydell@linaro.org,
	afaerber@suse.de, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH Trivial V2] hw/intc/arm_gic: Remove the definition of NUM_CPU
Date: Fri, 06 Nov 2015 11:14:09 +0300	[thread overview]
Message-ID: <563C6151.9070800@msgid.tls.msk.ru> (raw)
In-Reply-To: <1446744293-32365-1-git-send-email-wei@redhat.com>

05.11.2015 20:24, Wei Huang wrote:
> arm_gic.c retrieves CPU number using either NUM_CPU(s) or s->num_cpu.
> Such mixed-uses make source code inconsistent. This patch removes
> NUM_CPU(s), which was defined for MPCore tweak long ago, and instead
> favors s->num_cpu. The source is more consistent after this small tweak.
> 
> Reviewed-by: Andreas Färber <afaerber@suse.de>
> Signed-off-by: Wei Huang <wei@redhat.com>

Reviewed-by: Michael Tokarev <mjt@tls.msk.ru>

I'm not applying this to -trivial per previous comments.

Thanks,

/mjt

  reply	other threads:[~2015-11-06  8:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-05 17:24 [Qemu-trivial] [PATCH Trivial V2] hw/intc/arm_gic: Remove the definition of NUM_CPU Wei Huang
2015-11-05 17:24 ` [Qemu-devel] " Wei Huang
2015-11-05 17:24 ` [Qemu-arm] " Wei Huang
2015-11-06  8:14 ` Michael Tokarev [this message]
2015-11-06  8:14   ` [Qemu-devel] " Michael Tokarev
2015-11-06 14:54 ` [Qemu-trivial] " Peter Maydell
2015-11-06 14:54   ` [Qemu-devel] " Peter Maydell
2015-11-06 14:54   ` [Qemu-arm] " Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563C6151.9070800@msgid.tls.msk.ru \
    --to=mjt@tls.msk.ru \
    --cc=afaerber@suse.de \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=wei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.