From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Henderson Subject: Re: [PATCH 2/2] target-i386: tcg: Check right CPUID bits for clflushopt/pcommit Date: Fri, 6 Nov 2015 12:07:19 +0100 Message-ID: <563C89E7.60206@twiddle.net> References: <1446672286-9136-1-git-send-email-ehabkost@redhat.com> <1446672286-9136-3-git-send-email-ehabkost@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: Xiao Guangrong , Paolo Bonzini , kvm@vger.kernel.org To: Eduardo Habkost , qemu-devel@nongnu.org Return-path: Received: from mail-wi0-f172.google.com ([209.85.212.172]:38519 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031997AbbKFLHa (ORCPT ); Fri, 6 Nov 2015 06:07:30 -0500 Received: by wicll6 with SMTP id ll6so26506544wic.1 for ; Fri, 06 Nov 2015 03:07:29 -0800 (PST) In-Reply-To: <1446672286-9136-3-git-send-email-ehabkost@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 11/04/2015 10:24 PM, Eduardo Habkost wrote: > Detect the clflushopt and pcommit instructions and check their > corresponding feature flags, instead of checking CPUID_SSE and > CPUID_CLFLUSH. > > Signed-off-by: Eduardo Habkost > --- > target-i386/translate.c | 28 ++++++++++++++++++++-------- > 1 file changed, 20 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~ From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39305) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuern-0006nY-Dw for qemu-devel@nongnu.org; Fri, 06 Nov 2015 06:07:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zueri-0008AW-4z for qemu-devel@nongnu.org; Fri, 06 Nov 2015 06:07:35 -0500 Received: from mail-wi0-x22d.google.com ([2a00:1450:400c:c05::22d]:36521) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuerh-0008AS-V9 for qemu-devel@nongnu.org; Fri, 06 Nov 2015 06:07:30 -0500 Received: by wimw2 with SMTP id w2so28029146wim.1 for ; Fri, 06 Nov 2015 03:07:29 -0800 (PST) Sender: Richard Henderson References: <1446672286-9136-1-git-send-email-ehabkost@redhat.com> <1446672286-9136-3-git-send-email-ehabkost@redhat.com> From: Richard Henderson Message-ID: <563C89E7.60206@twiddle.net> Date: Fri, 6 Nov 2015 12:07:19 +0100 MIME-Version: 1.0 In-Reply-To: <1446672286-9136-3-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] target-i386: tcg: Check right CPUID bits for clflushopt/pcommit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost , qemu-devel@nongnu.org Cc: Paolo Bonzini , Xiao Guangrong , kvm@vger.kernel.org On 11/04/2015 10:24 PM, Eduardo Habkost wrote: > Detect the clflushopt and pcommit instructions and check their > corresponding feature flags, instead of checking CPUID_SSE and > CPUID_CLFLUSH. > > Signed-off-by: Eduardo Habkost > --- > target-i386/translate.c | 28 ++++++++++++++++++++-------- > 1 file changed, 20 insertions(+), 8 deletions(-) Reviewed-by: Richard Henderson r~