From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Zuhko-0005PB-CC for mharc-grub-devel@gnu.org; Fri, 06 Nov 2015 09:12:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54625) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuhkk-0005MT-H4 for grub-devel@gnu.org; Fri, 06 Nov 2015 09:12:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zuhkf-0000K3-CO for grub-devel@gnu.org; Fri, 06 Nov 2015 09:12:30 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:26835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuhkf-0000J6-7D for grub-devel@gnu.org; Fri, 06 Nov 2015 09:12:25 -0500 Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.15.0.59/8.15.0.59) with SMTP id tA6EBZIf029352 for ; Fri, 6 Nov 2015 06:12:23 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=ZkGDzeGo0LGr86kCCxdKgk2xUBDLCSSlSgC5Z8bUDDw=; b=qcjhx5KrTALC1YS9xdPBw5fRglWhNnCOVV97YG5IOGhIWQPl0miS+WiCxCEaYqjlS24J 6ciyLBxAC6gTYL9EKsoj3+t45mmGagMzPwBdmDZPk0NPS2w/2S//wdhXcaQHQPCFmcpM K7mLm35LmQku54Hp73Xbnp9Mzg/VOqYAYg4= Received: from mail.thefacebook.com ([199.201.64.23]) by m0001303.ppops.net with ESMTP id 1xxfbns1em-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for ; Fri, 06 Nov 2015 06:12:23 -0800 Received: from localhost.localdomain (192.168.52.123) by mail.thefacebook.com (192.168.16.14) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 6 Nov 2015 06:12:21 -0800 Subject: Re: [PATCH] efinet: add efinet_multicast_filter command To: References: <1446751432-2184661-1-git-send-email-jbacik@fb.com> <563C2971.5090705@gmail.com> From: Josef Bacik Message-ID: <563CB544.1060809@fb.com> Date: Fri, 6 Nov 2015 09:12:20 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <563C2971.5090705@gmail.com> Content-Type: text/plain; charset="utf-8"; format=flowed X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2015-11-06_10:, , signatures=0 Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by m0001303.ppops.net id tA6EBZIf029352 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 67.231.153.30 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Nov 2015 14:12:31 -0000 On 11/05/2015 11:15 PM, Andrei Borzenkov wrote: > 05.11.2015 22:23, Josef Bacik =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> We have some hardware that doesn't honor >> EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS_MULTICAST properly so we aren't >> getting > > You mean that driver advertises promiscuous multicast support but does > not implement it? Can you add debugging to efi_call_6 > (net->receive_filters, net, filters, 0, 0, 0, NULL); whether it fails. > May be need set each one separately and fall back to promiscuous. > I spent a week debugging this before I declared it a firmware bug. The=20 receive_filters succeeds when setting it to promiscuous, and=20 net->mode->receive_filter_settings has all the appropriate bits set.=20 It's all done right, the firmware just isn't working. I'll also note we noticed this with ipxe first (we haven't finished our=20 grub2 rollout yet) and we had to do a similar approach there. >> RA's that are multicasted properly (our switches respond to >> solicitations with a >> multicast rather than a unicast). > > Could you send packet trace? > Can't sorry, this is in our secure network. But I can tell you we see=20 the solicit from grub properly, and then the switches respond with a=20 multicast RA and grub doesn't do anything with it. These are from our=20 FBOSS switches, we are fixing them to do unicast responses to=20 solicitations as well because of this but a multicast response is also=20 allowed. >> I don't want to add this filtering by >> default, so add a new command to allow a user to specify a multicast >> receive >> filter. We use it like this >> > > I do not think we need any IPv4 multicasts; for IPv6 we need all nodes > and solicited address. > > But I would like to understand first whether receive_filters fail and w= e > ignore it or it succeeds. > I agree, I'll do what Vladimir is suggesting. However I'm going to=20 leave an option to use promiscuous. We are going to use that to test=20 new hardware coming in so we stop buying crap that doesn't behave=20 according to spec. Thanks, Josef