Re: [PATCH 1/1] Fix AARCH64_TLSDESC relocation conflict

[Mark Hatle <mark.hatle@windriver.com>]

On 11/6/15 1:09 AM, Vaneet Narang wrote:
> Hi Mark, 
> 
>> I have done the same implementation for AARCH64.  Loader handles AARCH64_TLSDESC conflict as below.
>> case R_AARCH64_TLSDESC:
>> ....
>>            if (! sym)
>>              {
>>                td->arg = (void*)reloc->r_addend;
>>                td->entry = _dl_tlsdesc_undefweak;
>>              }
> 
> we have shared one patch in libc to handle AARCH64_TLS conflict on AARCH64. 
> https://sourceware.org/ml/libc-alpha/2015-11/msg00106.html
>  
> Since we are using cross prelink we don't run testsuite. we compile all test cases 
> from test suite manually as mentioned in tls.sh file and run on target. 
> 
> LD_DEBUG=libs LD_LIBRARY_PATH=. ./tls1
>        
>  1828:     prelink checking: ok
> 
> ....
> No segfault or abort() is observed hence i assume testcase is running properly.  

I will look into this further.  But you should start building the test cases on
the target and running them.

Some of the failures are segfault/aborts.  But many of them have to do with
prelink functionality.  For example, many failures are related to the inability
to 'unprelink' the binaries.

Something is changing the binary in a way that can not be reverted, and this is
a failure case.  The system must be able to be unprelinked for validation
purposes -- and also to permit being re-prelinked.

I will look into merging these patches later today and will also work on adding
the necessary patches to poky/oe-core and putting them into a contrib branch so
we're working on the same set of data.

--Mark

>          
> Thanks 
> Vaneet Narang
>