From: Timur Tabi <timur@codeaurora.org>
To: Peter Hurley <peter@hurleysoftware.com>
Cc: andre.przywara@arm.com, Linus Walleij <linus.walleij@linaro.org>,
Andrew.Jackson@arm.com, rmk+kernel@arm.linux.org.uk,
jun.nie@linaro.or, linux-serial@vger.kernel.org,
Greg Kroah-Hartman <greg@kroah.com>,
jslaby@suse.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] tty: amba-pl011: add options to earlycon for 32-bit reg access
Date: Fri, 6 Nov 2015 12:59:59 -0600 [thread overview]
Message-ID: <563CF8AF.50808@codeaurora.org> (raw)
In-Reply-To: <563C1409.4070804@hurleysoftware.com>
On 11/05/2015 08:44 PM, Peter Hurley wrote:
> Or better yet, for sbsa32 earlycon, just use the existing port type constructs.
> So,
>
> earlycon=pl011,mmio32,0x3ced1000
>
> which will set port->iotype to UPIO_MEM32, which in turn can be used to select
> the correct i/o width in pl011_putc().
That's a great idea. But why aren't we using it for pl011_write()?
static void pl011_write(unsigned int val, const struct uart_amba_port *uap,
unsigned int reg)
{
void __iomem *addr = uap->port.membase + pl011_reg_to_offset(uap, reg);
if (uap->port.iotype == UPIO_MEM32)
writel(val, addr);
else
writew(val, addr);
}
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: timur@codeaurora.org (Timur Tabi)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] tty: amba-pl011: add options to earlycon for 32-bit reg access
Date: Fri, 6 Nov 2015 12:59:59 -0600 [thread overview]
Message-ID: <563CF8AF.50808@codeaurora.org> (raw)
In-Reply-To: <563C1409.4070804@hurleysoftware.com>
On 11/05/2015 08:44 PM, Peter Hurley wrote:
> Or better yet, for sbsa32 earlycon, just use the existing port type constructs.
> So,
>
> earlycon=pl011,mmio32,0x3ced1000
>
> which will set port->iotype to UPIO_MEM32, which in turn can be used to select
> the correct i/o width in pl011_putc().
That's a great idea. But why aren't we using it for pl011_write()?
static void pl011_write(unsigned int val, const struct uart_amba_port *uap,
unsigned int reg)
{
void __iomem *addr = uap->port.membase + pl011_reg_to_offset(uap, reg);
if (uap->port.iotype == UPIO_MEM32)
writel(val, addr);
else
writew(val, addr);
}
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2015-11-06 18:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 0:37 [PATCH] tty: amba-pl011: add options to earlycon for 32-bit reg access Timur Tabi
2015-11-06 0:37 ` Timur Tabi
2015-11-06 1:52 ` Peter Hurley
2015-11-06 1:52 ` Peter Hurley
2015-11-06 2:00 ` Timur Tabi
2015-11-06 2:00 ` Timur Tabi
2015-11-06 2:44 ` Peter Hurley
2015-11-06 2:44 ` Peter Hurley
2015-11-06 18:59 ` Timur Tabi [this message]
2015-11-06 18:59 ` Timur Tabi
2015-11-07 22:36 ` Peter Hurley
2015-11-07 22:36 ` Peter Hurley
2015-11-07 23:02 ` Russell King - ARM Linux
2015-11-07 23:02 ` Russell King - ARM Linux
2015-11-07 23:31 ` Timur Tabi
2015-11-07 23:31 ` Timur Tabi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563CF8AF.50808@codeaurora.org \
--to=timur@codeaurora.org \
--cc=Andrew.Jackson@arm.com \
--cc=andre.przywara@arm.com \
--cc=greg@kroah.com \
--cc=jslaby@suse.com \
--cc=jun.nie@linaro.or \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter@hurleysoftware.com \
--cc=rmk+kernel@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.