From: Benjamin Larsson <benjamin@southpole.se>
To: Antti Palosaari <crope@iki.fi>, linux-media@vger.kernel.org
Subject: Re: [PATCH] rtl28xxu: fix control message flaws
Date: Sat, 7 Nov 2015 00:15:17 +0100 [thread overview]
Message-ID: <563D3485.7010309@southpole.se> (raw)
In-Reply-To: <1444495530-1674-1-git-send-email-crope@iki.fi>
On 10/10/2015 06:45 PM, Antti Palosaari wrote:
> Add lock to prevent concurrent access for control message as control
> message function uses shared buffer. Without the lock there may be
> remote control polling which messes the buffer causing IO errors.
> Increase buffer size and add check for maximum supported message
> length.
>
This patch made at least one of my devices work. Before my log was full
of errors.
Totally unrelated I do get a fail on loading the firmware. Just retrying
made it work eventually.
[ 143.286498] mn88473 19-0018: downloading firmware from file
'dvb-demod-mn88473-01.fw'
[ 143.551497] mn88473 19-0018: firmware download failed=-32
[ 143.826792] rtl2832 19-0010: i2c reg read failed -32
[ 143.903215] mn88473 19-0018: downloading firmware from file
'dvb-demod-mn88473-01.fw'
[ 144.345554] mn88473 19-0018: firmware download failed=-32
[ 331.060613] mn88473 19-0018: downloading firmware from file
'dvb-demod-mn88473-01.fw'
[ 331.477234] mn88473 19-0018: firmware download failed=-32
[ 354.997771] rtl2832 19-0010: i2c reg read failed -32
[ 358.591754] mn88473 19-0018: downloading firmware from file
'dvb-demod-mn88473-01.fw'
[ 359.115582] mn88473 19-0018: firmware parity check succeeded=0x20
MvH
Benjamin Larsson
prev parent reply other threads:[~2015-11-06 23:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 16:45 [PATCH] rtl28xxu: fix control message flaws Antti Palosaari
2015-10-14 22:11 ` Daniel Glöckner
2015-10-15 6:54 ` Antti Palosaari
2015-11-06 23:15 ` Benjamin Larsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563D3485.7010309@southpole.se \
--to=benjamin@southpole.se \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.