All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sinan Kaya <okaya@codeaurora.org>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: linux-pci@vger.kernel.org
Subject: Re: ECRC and Max Read Request Size
Date: Fri, 6 Nov 2015 22:39:51 -0500	[thread overview]
Message-ID: <563D7287.1050500@codeaurora.org> (raw)
In-Reply-To: <20151107001143.GA17842@localhost>



On 11/6/2015 7:11 PM, Bjorn Helgaas wrote:
> That should definitely be fixed.  Do we enable ECRC unconditionally,
> or only when we boot with "pci=ecrc=on"?  The doc
> (Documentation/kernel-parameters.txt) suggests the latter.
>
> It would be ideal if we could try to turn on ECRC all the time by
> default for paths that support it.  I suppose there's some risk that
> we'd trip over broken hardware.  If that's an issue, we could consider
> turning it on all the time on machines newer than X (that's easy on
> x86, where we have a DMI BIOS date, but maybe not so easy on other
> arches).

ecrc=on kernel option works like "force on" rather than just a simple on.

I agree we should enable it by default.


-- 
Sinan Kaya
Qualcomm Technologies, Inc. on behalf of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
Linux Foundation Collaborative Project

  reply	other threads:[~2015-11-07  3:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28 17:51 ECRC and Max Read Request Size Sinan Kaya
2015-11-06 17:22 ` Bjorn Helgaas
2015-11-06 17:54   ` Sinan Kaya
2015-11-07  0:11     ` Bjorn Helgaas
2015-11-07  3:39       ` Sinan Kaya [this message]
2015-11-09 19:47         ` Bjorn Helgaas
2015-11-10  0:09           ` Sinan Kaya
2015-11-09 19:15     ` Bjorn Helgaas
2015-11-10  0:43       ` Sinan Kaya
2015-11-08 17:20   ` Sinan Kaya
  -- strict thread matches above, loose matches on Subject: below --
2015-10-26 18:42 Sinan Kaya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=563D7287.1050500@codeaurora.org \
    --to=okaya@codeaurora.org \
    --cc=helgaas@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.