From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Zuwfz-000337-JC for mharc-grub-devel@gnu.org; Sat, 07 Nov 2015 01:08:35 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35877) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuwfx-00032z-RB for grub-devel@gnu.org; Sat, 07 Nov 2015 01:08:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zuwfu-0001TE-KR for grub-devel@gnu.org; Sat, 07 Nov 2015 01:08:33 -0500 Received: from mail-lb0-x236.google.com ([2a00:1450:4010:c04::236]:34524) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zuwfu-0001Sk-Da for grub-devel@gnu.org; Sat, 07 Nov 2015 01:08:30 -0500 Received: by lbbwb3 with SMTP id wb3so70731310lbb.1 for ; Fri, 06 Nov 2015 22:08:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=KymF0Dp1e7lHv3Za01STlmEwXc4RHMIeSd8EqZ+7IGs=; b=eVPand4ebnV4llEvetiMuPTrp+QIKMuMPT/Ubf5HRVPSUbIdAtG1U1fJlSy8nFXUtI r/46+S0X6nq2/2U4GT4hEuaFwPb0R0CfQvNF89FyNtZyQwvj3yIRivsn4ItWFxg9lwqg Eu7OKLmKGfKJ9WtIDMOLo8nC9A07LKkZUPbluDo/ePxfuJzJrkSTpOMzh90UtuvpSCFs YgtWAuVFAaJ2sJYnRr76oIVyt37jjuh3S8AU32qBB7OiLXkWVrT2v8ksTd95sBIFlfON mvR+K5HoOv9QEYqHfvpumUicFenRvzHafo9kvxIVWtI6ICBlU1h/LoM8O0isbPfGvw7P BlqA== X-Received: by 10.112.199.231 with SMTP id jn7mr8506858lbc.37.1446876509606; Fri, 06 Nov 2015 22:08:29 -0800 (PST) Received: from [192.168.1.41] (ppp91-76-25-247.pppoe.mtu-net.ru. [91.76.25.247]) by smtp.gmail.com with ESMTPSA id d194sm595321lfg.34.2015.11.06.22.08.28 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Nov 2015 22:08:28 -0800 (PST) Subject: Re: [PATCH] efinet: add efinet_multicast_filter command To: grub-devel@gnu.org References: <1446751432-2184661-1-git-send-email-jbacik@fb.com> <563BC763.1080002@fb.com> <563CF4AF.2010508@gmail.com> From: Andrei Borzenkov Message-ID: <563D955C.2000405@gmail.com> Date: Sat, 7 Nov 2015 09:08:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:4010:c04::236 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 07 Nov 2015 06:08:34 -0000 06.11.2015 21:47, Vladimir 'phcoder' Serbinenko пишет: > Le 6 nov. 2015 7:43 PM, "Andrei Borzenkov" a écrit : >> >> 06.11.2015 02:47, Vladimir 'phcoder' Serbinenko пишет: >> >>> If we can't figure out which ones we need to filter out, then it's >>> unrealistic to expect our users to be able to configure. We need to go > with >>> multicast filter per default and switch to promiscuous only when we >>> actually need it: when we override mac address. You can add function to > go >>> to promiscuous mode to network interface structure >> >> >> I'm afraid if we cannot trust firmware the only solution is to simply use > promiscuous mode. This is not as bad as it sounds, as with moder switches > we won't get significantly more traffic anyway unless someone floods > network with video broadcast, in which case grub is probably not the right > place to fix it. >> >> Also firmware is free to implement filter using promiscuous mode, so it > may well be what we end up doing anyway. >> >> And i386 did it all the time. I do not know how wide testing it received, > but nobody complained about problems due to promiscuous. >> > Josef's firmware apparently doesn't work with promiscuous. Or do you mean > some kind of hybrid mode when we set both promiscuous and filters? I mean full promiscuous, not multicast promiscuous - EFI_SIMPLE_NETWORK_RECEIVE_PROMISCUOUS.