From: "Torsten Bögershausen" <tboegi@web.de>
To: Stefan Beller <sbeller@google.com>, git@vger.kernel.org, j6t@kdbg.org
Cc: ramsay@ramsayjones.plus.com, jacob.keller@gmail.com,
peff@peff.net, gitster@pobox.com, jrnieder@gmail.com,
johannes.schindelin@gmail.com, Jens.Lehmann@web.de,
ericsunshine@gmail.com
Subject: Re: [PATCH] run-command: detect finished children by closed pipe rather than waitpid
Date: Sat, 7 Nov 2015 07:28:30 +0100 [thread overview]
Message-ID: <563D9A0E.8050405@web.de> (raw)
In-Reply-To: <1446853737-19047-1-git-send-email-sbeller@google.com>
On 07.11.15 00:48, Stefan Beller wrote:
>
> +enum child_state {
> + FREE,
> + WORKING,
> + WAIT_CLEANUP,
> +};
This kind of "generic names" feels are begging for
name clash, some day, may be in the future.
How about something like this:
> + GIT_CP_FREE,
> + GIT_CP_WORKING,
> + GIT_CP_WAIT_CLEANUP,
next prev parent reply other threads:[~2015-11-07 6:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-06 23:48 [PATCH] run-command: detect finished children by closed pipe rather than waitpid Stefan Beller
2015-11-07 6:28 ` Torsten Bögershausen [this message]
2015-11-07 9:01 ` Johannes Sixt
2015-11-11 20:37 ` Stefan Beller
2015-11-11 20:48 ` Johannes Sixt
2015-11-11 20:53 ` Stefan Beller
2015-11-11 22:18 ` Johannes Sixt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=563D9A0E.8050405@web.de \
--to=tboegi@web.de \
--cc=Jens.Lehmann@web.de \
--cc=ericsunshine@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j6t@kdbg.org \
--cc=jacob.keller@gmail.com \
--cc=johannes.schindelin@gmail.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
--cc=ramsay@ramsayjones.plus.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.