Re: [dpdk-dev] [PATCH v3 0/2] fix distributor unit test

["Hunt, David" <david.hunt@intel.com>]

On 25/10/2019 09:18, David Marchand wrote:
> On Fri, Oct 25, 2019 at 10:11 AM Hunt, David <david.hunt@intel.com> wrote:
>>
>> On 24/10/2019 20:31, David Marchand wrote:
>>> On Tue, Oct 15, 2019 at 11:29 AM Ruifeng Wang <ruifeng.wang@arm.com> wrote:
>>>> Bug 342 reported distributor_autotest execution suspension
>>>> on aarch64 platform.
>>>> Issue was due to lack of synchronization among threads. Distributor
>>>> thread and worker thread may get deadlocked.
>>>> Fixed synchronization issue by adding barriers.
>>>>
>>>> Another issue identified was in test case. Non-atomic operation on
>>>> stat value could cause value reset not been observed by worker thread
>>>> and mess counters. The issue was fixed by using atomic operations.
>>>>
>>>> ---
>>>> v3:
>>>> Added comments for using of C11 acquire/release semantics. (Honnappa)
> The comments are also something to maintain, so checking the v3 made
> sense to me.


   I agree, and the comments look good to me.



>
>>>> v2:
>>>> Fixed intermittent packet count incorrect failure. (Aaron, David)
>>>> Fixed Clang build on 32bit systems.
>>>> Additional patch to fix non-atomic operation in unit test.
>>> David,
>>>
>>> Can you review this series?
>>> Thanks.
>>>
>> Hi David,
>>
>>       I had tested this previously, including performance comparisons
>> against original version on x86, and saw no performance degradation, so
>> I Acked it. I can re-ack on the latest version now.
> If you think this is fine as is, I will go and apply with your ack.


Sure, thanks.


Regards,

Dave.