From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pa0-x233.google.com ([2607:f8b0:400e:c03::233]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZuxEk-0006iU-Fc for kexec@lists.infradead.org; Sat, 07 Nov 2015 06:44:31 +0000 Received: by pasz6 with SMTP id z6so148691382pas.2 for ; Fri, 06 Nov 2015 22:44:08 -0800 (PST) Message-ID: <563d9db7.6293420a.cdda3.ffffa5c8@mx.google.com> Date: Fri, 06 Nov 2015 22:44:07 -0800 (PST) From: Palmer Dabbelt Subject: Re: [PATCH 09/13] Move bp_type_idx to kernel/event/hw_breakpoint.c In-Reply-To: <20151104122151.GB11639@twins.programming.kicks-ass.net> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: peterz@infradead.org Cc: dave@sr71.net, linux-xtensa@linux-xtensa.org, dhowells@redhat.com, jcmvbkbc@gmail.com, hpa@zytor.com, mingo@kernel.org, ast@plumgrid.com, aarcange@redhat.com, bhe@redhat.com, x86@kernel.org, tomi.valkeinen@ti.com, 3chas3@gmail.com, paulmck@linux.vnet.ibm.com, dyoung@redhat.com, vgoyal@redhat.com, aishchuk@linux.vnet.ibm.com, linux-arch@vger.kernel.org, jikos@kernel.org, arnd@arndb.de, plagnioj@jcrosoft.com, josh@joshtriplett.org, acme@kernel.org, mathieu.desnoyers@efficios.com, viro@zeniv.linux.org.uk, luto@kernel.org, tglx@linutronix.de, drysdale@google.com, chris@zankel.net, iulia.manda21@gmail.com, geoff@infradead.org, gregkh@linuxfoundation.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, ebiederm@xmission.com, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, akpm@linux-foundation.org, davem@davemloft.net On Wed, 04 Nov 2015 04:21:51 PST (-0800), peterz@infradead.org wrote: > On Wed, Nov 04, 2015 at 12:41:06PM +0100, Peter Zijlstra wrote: >> On Tue, Nov 03, 2015 at 11:46:30AM -0800, Palmer Dabbelt wrote: >> > This has a "#ifdef CONFIG_*" that used to be exposed to userspace. >> > >> > The names in here are so generic that I don't think it's a good idea >> > to expose them to userspace (or even the rest of the kernel). Since >> > there's only one kernel user, it's been moved to that file. >> > >> > Signed-off-by: Palmer Dabbelt >> > Reviewed-by: Andrew Waterman >> > Reviewed-by: Albert Ou >> >> Assuming you want to keep all these patches together in a tree or so. >> Let me know if you want me to take this patch. Well, the plan was to try to get the whole patch set all upstream together. I'd prefer that, because it'll be easier to make sure everything gets in before the last checker patch. Since it touches so many different places I'd be OK with doing it peicemeal. I'm kind of new to this whole process: do you think someone is likely to take this patch set all together? >> Acked-by: Peter Zijlstra (Intel) > > Ah, build-bot finds your change is broken and you didn't grep right. It > is used in more places. Sorry about that, I must have mis-grep'd. I guess that's what the build-bot is for :). > How about moving it to include/linux/hw_breakpoint.h, instead of having > it in the uapi crud? Yep, that makes sense. I'm going to re-submit a v5 of this patch set, since there was also a missing patch for blackfin that the buildbot found. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 From: Palmer Dabbelt Subject: Re: [PATCH 09/13] Move bp_type_idx to kernel/event/hw_breakpoint.c Date: Fri, 06 Nov 2015 22:44:07 -0800 (PST) Message-ID: <563d9db7.6293420a.cdda3.ffffa5c8@mx.google.com> References: <20151104122151.GB11639@twins.programming.kicks-ass.net> Return-path: In-Reply-To: <20151104122151.GB11639-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org Cc: arnd-r2nGTMty4D4@public.gmane.org, dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org, ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org, aishchuk-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org, luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, 3chas3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org, dave-gkUM19QKKo4@public.gmane.org, dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, drysdale-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, geoff-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org, mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, iulia.manda21-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org, jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org, kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-xtensa-PjhNF2WwrV/0Sa2dR60CXw@public.gmane.org, mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org, jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org, tomi.valkeinen-l0cyMroinI0@public.gmane.org, vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: linux-api@vger.kernel.org On Wed, 04 Nov 2015 04:21:51 PST (-0800), peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org wrote: > On Wed, Nov 04, 2015 at 12:41:06PM +0100, Peter Zijlstra wrote: >> On Tue, Nov 03, 2015 at 11:46:30AM -0800, Palmer Dabbelt wrote: >> > This has a "#ifdef CONFIG_*" that used to be exposed to userspace. >> > >> > The names in here are so generic that I don't think it's a good idea >> > to expose them to userspace (or even the rest of the kernel). Since >> > there's only one kernel user, it's been moved to that file. >> > >> > Signed-off-by: Palmer Dabbelt >> > Reviewed-by: Andrew Waterman >> > Reviewed-by: Albert Ou >> >> Assuming you want to keep all these patches together in a tree or so. >> Let me know if you want me to take this patch. Well, the plan was to try to get the whole patch set all upstream together. I'd prefer that, because it'll be easier to make sure everything gets in before the last checker patch. Since it touches so many different places I'd be OK with doing it peicemeal. I'm kind of new to this whole process: do you think someone is likely to take this patch set all together? >> Acked-by: Peter Zijlstra (Intel) > > Ah, build-bot finds your change is broken and you didn't grep right. It > is used in more places. Sorry about that, I must have mis-grep'd. I guess that's what the build-bot is for :). > How about moving it to include/linux/hw_breakpoint.h, instead of having > it in the uapi crud? Yep, that makes sense. I'm going to re-submit a v5 of this patch set, since there was also a missing patch for blackfin that the buildbot found. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f54.google.com ([209.85.220.54]:35931 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750983AbbKGGoJ (ORCPT ); Sat, 7 Nov 2015 01:44:09 -0500 Received: by pacdm15 with SMTP id dm15so120236700pac.3 for ; Fri, 06 Nov 2015 22:44:08 -0800 (PST) Message-ID: <563d9db7.6293420a.cdda3.ffffa5c8@mx.google.com> Date: Fri, 06 Nov 2015 22:44:07 -0800 (PST) From: Palmer Dabbelt Subject: Re: [PATCH 09/13] Move bp_type_idx to kernel/event/hw_breakpoint.c In-Reply-To: <20151104122151.GB11639@twins.programming.kicks-ass.net> Sender: linux-arch-owner@vger.kernel.org List-ID: To: peterz@infradead.org Cc: arnd@arndb.de, dhowells@redhat.com, viro@zeniv.linux.org.uk, ast@plumgrid.com, aishchuk@linux.vnet.ibm.com, aarcange@redhat.com, akpm@linux-foundation.org, luto@kernel.org, acme@kernel.org, bhe@redhat.com, 3chas3@gmail.com, chris@zankel.net, dave@sr71.net, dyoung@redhat.com, drysdale@google.com, davem@davemloft.net, ebiederm@xmission.com, geoff@infradead.org, gregkh@linuxfoundation.org, hpa@zytor.com, mingo@kernel.org, iulia.manda21@gmail.com, plagnioj@jcrosoft.com, jikos@kernel.org, josh@joshtriplett.org, kexec@lists.infradead.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xtensa@linux-xtensa.org, mathieu.desnoyers@efficios.com, jcmvbkbc@gmail.com, paulmck@linux.vnet.ibm.com, tglx@linutronix.de, tomi.valkeinen@ti.com, vgoyal@redhat.com, x86@kernel.org Message-ID: <20151107064407.ChmYQl3_5EBreIvl_5JmewHY-ybX_asUJMkGFaCDJlY@z> On Wed, 04 Nov 2015 04:21:51 PST (-0800), peterz@infradead.org wrote: > On Wed, Nov 04, 2015 at 12:41:06PM +0100, Peter Zijlstra wrote: >> On Tue, Nov 03, 2015 at 11:46:30AM -0800, Palmer Dabbelt wrote: >> > This has a "#ifdef CONFIG_*" that used to be exposed to userspace. >> > >> > The names in here are so generic that I don't think it's a good idea >> > to expose them to userspace (or even the rest of the kernel). Since >> > there's only one kernel user, it's been moved to that file. >> > >> > Signed-off-by: Palmer Dabbelt >> > Reviewed-by: Andrew Waterman >> > Reviewed-by: Albert Ou >> >> Assuming you want to keep all these patches together in a tree or so. >> Let me know if you want me to take this patch. Well, the plan was to try to get the whole patch set all upstream together. I'd prefer that, because it'll be easier to make sure everything gets in before the last checker patch. Since it touches so many different places I'd be OK with doing it peicemeal. I'm kind of new to this whole process: do you think someone is likely to take this patch set all together? >> Acked-by: Peter Zijlstra (Intel) > > Ah, build-bot finds your change is broken and you didn't grep right. It > is used in more places. Sorry about that, I must have mis-grep'd. I guess that's what the build-bot is for :). > How about moving it to include/linux/hw_breakpoint.h, instead of having > it in the uapi crud? Yep, that makes sense. I'm going to re-submit a v5 of this patch set, since there was also a missing patch for blackfin that the buildbot found. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Palmer Dabbelt Subject: Re: [PATCH 09/13] Move bp_type_idx to kernel/event/hw_breakpoint.c Date: Fri, 06 Nov 2015 22:44:07 -0800 (PST) Message-ID: <563d9db7.6293420a.cdda3.ffffa5c8@mx.google.com> References: <20151104122151.GB11639@twins.programming.kicks-ass.net> Cc: arnd-r2nGTMty4D4@public.gmane.org To: peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org Return-path: CC: dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org CC: viro-RmSDqhL/yNMiFSDQTTA3OLVCufUGDwFn@public.gmane.org CC: ast-uqk4Ao+rVK5Wk0Htik3J/w@public.gmane.org CC: aishchuk-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org CC: aarcange-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org CC: akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org CC: luto-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org CC: acme-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org CC: bhe-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org CC: 3chas3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org CC: chris-YvXeqwSYzG2sTnJN9+BGXg@public.gmane.org CC: dave-gkUM19QKKo4@public.gmane.org CC: dyoung-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org CC: drysdale-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org CC: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org CC: ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org CC: geoff-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org CC: gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org CC: hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org CC: mingo-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org CC: iulia.manda21-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org CC: plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org CC: jikos-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org CC: josh-iaAMLnmF4UmaiuxdJuQwMA@public.gmane.org CC: kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org CC: linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org CC: linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org CC: linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org CC: linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org CC: linux-xtensa-PjhNF2WwrV/0Sa2dR60CXw@public.gmane.org CC: mathieu.desnoyers-vg+e7yoeK/dWk0Htik3J/w@public.gmane.org CC: jcmvbkbc-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org CC: paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org CC: tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org CC: tomi.valkeinen-l0cyMroinI0@public.gmane.org CC: vgoyal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org CC: x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org In-Reply-To: <20151104122151.GB11639-ndre7Fmf5hadTX5a5knrm8zTDFooKrT+cvkQGrU6aU0@public.gmane.org> Sender: linux-api-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 04 Nov 2015 04:21:51 PST (-0800), peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org wrote: > On Wed, Nov 04, 2015 at 12:41:06PM +0100, Peter Zijlstra wrote: >> On Tue, Nov 03, 2015 at 11:46:30AM -0800, Palmer Dabbelt wrote: >> > This has a "#ifdef CONFIG_*" that used to be exposed to userspace. >> > >> > The names in here are so generic that I don't think it's a good idea >> > to expose them to userspace (or even the rest of the kernel). Since >> > there's only one kernel user, it's been moved to that file. >> > >> > Signed-off-by: Palmer Dabbelt >> > Reviewed-by: Andrew Waterman >> > Reviewed-by: Albert Ou >> >> Assuming you want to keep all these patches together in a tree or so. >> Let me know if you want me to take this patch. Well, the plan was to try to get the whole patch set all upstream together. I'd prefer that, because it'll be easier to make sure everything gets in before the last checker patch. Since it touches so many different places I'd be OK with doing it peicemeal. I'm kind of new to this whole process: do you think someone is likely to take this patch set all together? >> Acked-by: Peter Zijlstra (Intel) > > Ah, build-bot finds your change is broken and you didn't grep right. It > is used in more places. Sorry about that, I must have mis-grep'd. I guess that's what the build-bot is for :). > How about moving it to include/linux/hw_breakpoint.h, instead of having > it in the uapi crud? Yep, that makes sense. I'm going to re-submit a v5 of this patch set, since there was also a missing patch for blackfin that the buildbot found. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751604AbbKGGoN (ORCPT ); Sat, 7 Nov 2015 01:44:13 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:33622 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750884AbbKGGoJ (ORCPT ); Sat, 7 Nov 2015 01:44:09 -0500 Message-ID: <563d9db7.6293420a.cdda3.ffffa5c8@mx.google.com> X-Google-Original-Message-ID: Mime-Version: 1.0 (MHng) Date: Fri, 06 Nov 2015 22:44:07 -0800 (PST) X-Google-Original-Date: Fri, 06 Nov 2015 22:44:03 PST (-0800) From: Palmer Dabbelt To: peterz@infradead.org CC: arnd@arndb.de CC: dhowells@redhat.com CC: viro@zeniv.linux.org.uk CC: ast@plumgrid.com CC: aishchuk@linux.vnet.ibm.com CC: aarcange@redhat.com CC: akpm@linux-foundation.org CC: luto@kernel.org CC: acme@kernel.org CC: bhe@redhat.com CC: 3chas3@gmail.com CC: chris@zankel.net CC: dave@sr71.net CC: dyoung@redhat.com CC: drysdale@google.com CC: davem@davemloft.net CC: ebiederm@xmission.com CC: geoff@infradead.org CC: gregkh@linuxfoundation.org CC: hpa@zytor.com CC: mingo@kernel.org CC: iulia.manda21@gmail.com CC: plagnioj@jcrosoft.com CC: jikos@kernel.org CC: josh@joshtriplett.org CC: kexec@lists.infradead.org CC: linux-api@vger.kernel.org CC: linux-arch@vger.kernel.org CC: linux-fsdevel@vger.kernel.org CC: linux-kernel@vger.kernel.org CC: linux-xtensa@linux-xtensa.org CC: mathieu.desnoyers@efficios.com CC: jcmvbkbc@gmail.com CC: paulmck@linux.vnet.ibm.com CC: tglx@linutronix.de CC: tomi.valkeinen@ti.com CC: vgoyal@redhat.com CC: x86@kernel.org Subject: Re: [PATCH 09/13] Move bp_type_idx to kernel/event/hw_breakpoint.c In-Reply-To: <20151104122151.GB11639@twins.programming.kicks-ass.net> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 04 Nov 2015 04:21:51 PST (-0800), peterz@infradead.org wrote: > On Wed, Nov 04, 2015 at 12:41:06PM +0100, Peter Zijlstra wrote: >> On Tue, Nov 03, 2015 at 11:46:30AM -0800, Palmer Dabbelt wrote: >> > This has a "#ifdef CONFIG_*" that used to be exposed to userspace. >> > >> > The names in here are so generic that I don't think it's a good idea >> > to expose them to userspace (or even the rest of the kernel). Since >> > there's only one kernel user, it's been moved to that file. >> > >> > Signed-off-by: Palmer Dabbelt >> > Reviewed-by: Andrew Waterman >> > Reviewed-by: Albert Ou >> >> Assuming you want to keep all these patches together in a tree or so. >> Let me know if you want me to take this patch. Well, the plan was to try to get the whole patch set all upstream together. I'd prefer that, because it'll be easier to make sure everything gets in before the last checker patch. Since it touches so many different places I'd be OK with doing it peicemeal. I'm kind of new to this whole process: do you think someone is likely to take this patch set all together? >> Acked-by: Peter Zijlstra (Intel) > > Ah, build-bot finds your change is broken and you didn't grep right. It > is used in more places. Sorry about that, I must have mis-grep'd. I guess that's what the build-bot is for :). > How about moving it to include/linux/hw_breakpoint.h, instead of having > it in the uapi crud? Yep, that makes sense. I'm going to re-submit a v5 of this patch set, since there was also a missing patch for blackfin that the buildbot found.