From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZvjyN-0007px-2c for mharc-grub-devel@gnu.org; Mon, 09 Nov 2015 05:46:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40675) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvjyK-0007pX-64 for grub-devel@gnu.org; Mon, 09 Nov 2015 05:46:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvjyJ-00077N-Ff for grub-devel@gnu.org; Mon, 09 Nov 2015 05:46:48 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:37217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvjyJ-00077C-9g for grub-devel@gnu.org; Mon, 09 Nov 2015 05:46:47 -0500 Received: by wmww144 with SMTP id w144so26762342wmw.0 for ; Mon, 09 Nov 2015 02:46:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type; bh=BUJojWNw5nL3kxhJml3aJrXWBEIvEl+U0stDoaBcFAw=; b=T0Z7C0zX8x0YrN7AMdOm0AH0yY03dxOsY0SK4pcCUCsEXFxEUheBzIaQE/IE/KNCvt Tl3xyCx+Iw+B2nCb5/B1ASMjZ8nZ62xv2qzKQDQcHhc8R+rRbUxEzSKQ/DqIqzP8BXwr 70lBJ+jOfFlnKpadWPFS2wQjiKgCFz819t9U+2JnnIBXC/xlmw7TFQDDKHxOWz7+59MW vjU6vVMhlX0BxISoSXdNa8Ax8H86CporpG9wvemCLKL5Yekrmm8Wvd10NmZm1KYfW0+v DTFYDOPMQsNbXvOIVPDHD9m4bimnnP20v96fwdivSts6q5/sOD7ZjNLfbjdamiUhjDRt O86A== X-Received: by 10.28.87.1 with SMTP id l1mr23596605wmb.72.1447066006551; Mon, 09 Nov 2015 02:46:46 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:863a:4bff:fe50:abc4? ([2620:0:105f:fd00:863a:4bff:fe50:abc4]) by smtp.gmail.com with ESMTPSA id w9sm14727259wjf.20.2015.11.09.02.46.45 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Nov 2015 02:46:45 -0800 (PST) Subject: Re: [PATCH] ofdisk: allocate space for vscsi table To: The development of GNU GRUB References: <1447032789-17670-1-git-send-email-pfsmorigo@linux.vnet.ibm.com> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <56407989.50903@gmail.com> Date: Mon, 9 Nov 2015 11:46:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447032789-17670-1-git-send-email-pfsmorigo@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="hdfxUL6MSIl7KjhGap0lHtn9Uln2i8IL6" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c09::22c X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Nov 2015 10:46:49 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hdfxUL6MSIl7KjhGap0lHtn9Uln2i8IL6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09.11.2015 02:33, Paulo Flabiano Smorigo wrote: > + /* 64 entries should be enough */ > + table_size =3D sizeof (grub_uint64_t) * 64; Can we do something better than assuming a particular upper limit? You don't even pass this limit to the function in any way. You basically get a buffer overflow. Should we perhaps pass the limit in nentries? Or do something similar? --hdfxUL6MSIl7KjhGap0lHtn9Uln2i8IL6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlZAeYkACgkQmBXlbbo5nOvtMwD/XTZfh5RPK9t4xv3rP0y7h2gJ gSmKSWqGh5AQVjw8eMsA/2lnAJnzzlHLozmvE+EiYonGSkZVYslHrApASlU+v9Y/ =4z7Y -----END PGP SIGNATURE----- --hdfxUL6MSIl7KjhGap0lHtn9Uln2i8IL6--