From: Peter Hurley <peter@hurleysoftware.com>
To: Johannes Stezenbach <js@sig21.net>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.cz>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
netdev@vger.kernel.org, Karsten Keil <isdn@linux-pingi.de>,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Jesper Nilsson <jesper.nilsson@axis.com>,
Mikael Starvik <starvik@axis.com>, Jiri Kosina <jikos@kernel.org>,
David Sterba <dsterba@suse.com>,
Mark Hounschell <markh@compro.net>
Subject: Re: [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior
Date: Mon, 9 Nov 2015 06:58:42 -0500 [thread overview]
Message-ID: <56408A72.4050301@hurleysoftware.com> (raw)
In-Reply-To: <20151109091214.GD16715@sig21.net>
On 11/09/2015 04:12 AM, Johannes Stezenbach wrote:
> On Sun, Nov 08, 2015 at 05:02:52PM -0500, Peter Hurley wrote:
>> +void tty_ldisc_closing(struct tty_struct *tty)
>> +{
>> + struct tty_ldisc *ld = tty_ldisc_ref(tty);
>> +
>> + if (ld->ops->closing)
>> + ld->ops->closing(tty);
>> + if (ld)
>> + tty_ldisc_deref(ld);
>> +}
>
> That looks strange. Do you need to check ld _before_ dereferencing?
Yes. Thanks for noticing.
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-11-09 11:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-08 22:02 [PATCH 0/4] Replace tty->closing Peter Hurley
2015-11-08 22:02 ` [PATCH 1/4] tty: rocket: Remove private close_wait Peter Hurley
2015-11-08 22:02 ` [PATCH 2/4] n_tty: Ignore all read data when closing Peter Hurley
2015-11-08 22:02 ` [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior Peter Hurley
2015-11-09 9:12 ` Johannes Stezenbach
2015-11-09 11:58 ` Peter Hurley [this message]
2015-11-08 22:02 ` [PATCH 4/4] tty: Remove drivers' extra tty_ldisc_flush() Peter Hurley
2015-11-09 12:15 ` [PATCH v2 0/4] Replace tty->closing Peter Hurley
2015-11-09 12:15 ` [PATCH v2 1/4] tty: rocket: Remove private close_wait Peter Hurley
2015-11-09 12:15 ` [PATCH v2 2/4] n_tty: Ignore all read data when closing Peter Hurley
2015-11-09 12:15 ` [PATCH v2 3/4] tty: Abstract and encapsulate tty->closing behavior Peter Hurley
2015-11-09 12:15 ` [PATCH v2 4/4] tty: Remove drivers' extra tty_ldisc_flush() Peter Hurley
2015-12-14 0:16 ` [PATCH v2 0/4] Replace tty->closing Peter Hurley
2015-12-14 4:02 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56408A72.4050301@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=dsterba@suse.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=isdn@linux-pingi.de \
--cc=jesper.nilsson@axis.com \
--cc=jikos@kernel.org \
--cc=js@sig21.net \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=markh@compro.net \
--cc=netdev@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=starvik@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.