From: Robert Yang <liezhi.yang@windriver.com>
To: "Burton, Ross" <ross.burton@intel.com>
Cc: OE-core <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH 3/3] bitbake-prserv-tool: check file name
Date: Mon, 9 Nov 2015 20:43:25 +0800 [thread overview]
Message-ID: <564094ED.4050402@windriver.com> (raw)
In-Reply-To: <CAJTo0LaOD2_=aDwHi9fjGzWZ2+hcMtUnjHMFsSOTABWiozuSTQ@mail.gmail.com>
On 11/09/2015 06:33 PM, Burton, Ross wrote:
>
> On 20 October 2015 at 10:25, Robert Yang <liezhi.yang@windriver.com
> <mailto:liezhi.yang@windriver.com>> wrote:
>
> Fixed:
> $ bitbake-prserv-tool import /tmp/1
> File "/path/to/lib/bb/parse/__init__.py", line 114, in
> handle(fn='/tmp/1', data=<bb.data_smart.DataSmart object at 0x2369bd0>,
> include=True):
> return h['handle'](fn, data, include)
> > raise ParseError("not a BitBake file", fn)
>
> ParseError: ParseError in /tmp/1: not a BitBake file
>
> But 1.conf works well, its help also shows "<file.conf>", so check the
> filename and print proper error message.
>
>
> This breaks the selftest:
>
> ======================================================================
> FAIL: test_import_export_override_db (oeqa.selftest.prservice.BitbakePrTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/utils/decorators.py",
> line 106, in wrapped_f
> return func(*args, **kwargs)
> File
> "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/prservice.py",
> line 97, in test_import_export_override_db
> self.run_test_pr_export_import('m4', replace_current_db=False)
> File
> "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/prservice.py",
> line 74, in run_test_pr_export_import
> self.assertEqual(export_result.status, 0, msg="PR Service database export
> failed: %s" % export_result.output)
> AssertionError: 1 != 0 : PR Service database export failed: ERROR:
> /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/build/export.inc
> must end with .conf!
>
> ======================================================================
> FAIL: test_import_export_replace_db (oeqa.selftest.prservice.BitbakePrTests)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File
> "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/utils/decorators.py",
> line 106, in wrapped_f
> return func(*args, **kwargs)
> File
> "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/prservice.py",
> line 93, in test_import_export_replace_db
> self.run_test_pr_export_import('m4')
> File
> "/home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/meta/lib/oeqa/selftest/prservice.py",
> line 74, in run_test_pr_export_import
> self.assertEqual(export_result.status, 0, msg="PR Service database export
> failed: %s" % export_result.output)
> AssertionError: 1 != 0 : PR Service database export failed: ERROR:
> /home/pokybuild/yocto-autobuilder/yocto-worker/nightly-oe-selftest/build/build/export.inc
> must end with .conf!
Maybe selftest should use export.conf rather than export.inc ?
// Robert
>
> Ross
next prev parent reply other threads:[~2015-11-09 12:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-20 9:25 [PATCH 0/3] meta: fixes for prserver Robert Yang
2015-10-20 9:25 ` [PATCH 1/3] prserv.bbclass: remove it since it is null Robert Yang
2015-10-20 9:25 ` [PATCH 2/3] prexport.bbclass: avoid export for native and crosssdk Robert Yang
2015-10-20 9:25 ` [PATCH 3/3] bitbake-prserv-tool: check file name Robert Yang
2015-11-09 10:33 ` Burton, Ross
2015-11-09 12:43 ` Robert Yang [this message]
2015-11-09 14:33 ` Burton, Ross
2015-11-10 6:03 ` Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564094ED.4050402@windriver.com \
--to=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=ross.burton@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.