All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stefan Tatschner <rumpelsepp@sevenbyte.org>,
	Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Jonathan Corbet <corbet@lwn.net>, linux-can <linux-can@vger.kernel.org>
Subject: Re: [PATCH] can-doc: Add missing semicolon to example
Date: Mon, 9 Nov 2015 14:20:51 +0100	[thread overview]
Message-ID: <56409DB3.6040803@pengutronix.de> (raw)
In-Reply-To: <1447075029-22711-1-git-send-email-rumpelsepp@sevenbyte.org>

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]

On 11/09/2015 02:17 PM, Stefan Tatschner wrote:
> The example code for CAN_BCM,
> 
> 	connect(s, (struct sockaddr *)&addr, sizeof(addr))
> 
> lacks a semicolon at the end of the line. This patch adds that
> missing semicolon to ensure that the given code snippet actually
> compiles.
> 
> Signed-off-by: Stefan Tatschner <rumpelsepp@sevenbyte.org>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>

Jonathan, feel free to take the patch via your tree.

regards,
Marc

> ---
>  Documentation/networking/can.txt | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/networking/can.txt b/Documentation/networking/can.txt
> index 4636b94..05fd83b 100644
> --- a/Documentation/networking/can.txt
> +++ b/Documentation/networking/can.txt
> @@ -681,7 +681,7 @@ solution for a couple of reasons:
>      addr.can_family = AF_CAN;
>      addr.can_ifindex = ifr.ifr_ifindex;
>  
> -    connect(s, (struct sockaddr *)&addr, sizeof(addr))
> +    connect(s, (struct sockaddr *)&addr, sizeof(addr));
>  
>      (..)
>  
> 


-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

       reply	other threads:[~2015-11-09 13:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1447075029-22711-1-git-send-email-rumpelsepp@sevenbyte.org>
2015-11-09 13:20 ` Marc Kleine-Budde [this message]
2015-11-09 18:01   ` [PATCH] can-doc: Add missing semicolon to example Oliver Hartkopp
2015-11-13 20:00     ` Oliver Hartkopp
2015-11-11 16:51   ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56409DB3.6040803@pengutronix.de \
    --to=mkl@pengutronix.de \
    --cc=corbet@lwn.net \
    --cc=linux-can@vger.kernel.org \
    --cc=rumpelsepp@sevenbyte.org \
    --cc=socketcan@hartkopp.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.