From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH] x86/P2M: consolidate handling of types not requiring a valid MFN Date: Mon, 9 Nov 2015 15:02:50 +0000 Message-ID: <5640B59A.9010909@citrix.com> References: <5640C13902000078000B3122@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZvnyB-0005Mi-Vz for xen-devel@lists.xenproject.org; Mon, 09 Nov 2015 15:02:56 +0000 In-Reply-To: <5640C13902000078000B3122@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: George Dunlap List-Id: xen-devel@lists.xenproject.org On 09/11/15 14:52, Jan Beulich wrote: > As noted regarding the mixture of checks in p2m_pt_set_entry(), > introduce an new P2M type group allowing to be used everywhere we "a new P2M" > just care about accepting operations with either a valid MFN or a type > permitting to be used without (valid) MFN. > > Note that p2m_mmio_dm is not included in P2M_NO_MFN_TYPES, as for the > intended purpose that one ought to be treated similar to p2m_invalid > (perhaps the two should ultimately get folded anyway). I seem to recall that p2m_invalid is still required to make the default ioreq server infrastructure work with older qemu's We really should see about cleaning the two up however. > > Signed-off-by: Jan Beulich You probably also want to note that PoD superpages are now INVALID_MFN rather than _mfn(0), but code wise, Reviewed-by: Andrew Cooper