From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33220) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvonc-0005PU-KM for qemu-devel@nongnu.org; Mon, 09 Nov 2015 10:56:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZvonZ-0004Yq-CW for qemu-devel@nongnu.org; Mon, 09 Nov 2015 10:56:04 -0500 Received: from mx2.suse.de ([195.135.220.15]:40624) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZvonZ-0004Ye-5z for qemu-devel@nongnu.org; Mon, 09 Nov 2015 10:56:01 -0500 References: <1447082260-427-1-git-send-email-mjrosato@linux.vnet.ibm.com> <5640BBAA.1000201@suse.de> <5640BD5B.9050204@de.ibm.com> <5640BDD2.9040102@de.ibm.com> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Message-ID: <5640C210.5060804@suse.de> Date: Mon, 9 Nov 2015 16:56:00 +0100 MIME-Version: 1.0 In-Reply-To: <5640BDD2.9040102@de.ibm.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/4] s390: Allow hotplug of s390 CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Christian Borntraeger , qemu-devel@nongnu.org Cc: Matthew Rosato , cornelia.huck@de.ibm.com, agraf@suse.de, Eduardo Habkost , rth@twiddle.net Am 09.11.2015 um 16:37 schrieb Christian Borntraeger: > Am 09.11.2015 um 16:35 schrieb Christian Borntraeger: >> Am 09.11.2015 um 16:28 schrieb Andreas F=E4rber: >>> Hi, >>> >>> Am 09.11.2015 um 16:17 schrieb Matthew Rosato: >>>> To subsequently hotplug a CPU: >>>> >>>> Issue 'cpu-add ' from qemu monitor, or use virsh setvcpus --coun= t =20 >>>> , where is the total number of desired guest CPUs. >>> >>> What exactly is still missing for you to use the standard device_add? >>> >>> Last time I checked (a while ago...) some patches were stuck on the x= 86 >>> side, and I don't recall hearing any feedback from the s390x side in = my >>> KVM Forum CPU hotplug session. >> >> libvirt uses "cpu-add" unconditionally for hotplugging, so we certainl= y=20 >> want to support that.=20 >=20 > Sorry, hit send too early. I assume you want us to support device_add o= f > a CPU in addition to that. Correct?=20 No, I mean as I've always said: cpu-add was a short-term hack to make CPU hotplug work on x86. libvirt certainly needs to be fixed if it assumes this to work for s390. If device_add works, we don't need cpu-add. If device_add does not work, we need to know which patches are missing. device_del is a separate beast and there were also patches around that seemed incomplete according to Eduardo. Bharata did implement device_add for pseries, I thought. Regards, Andreas --=20 SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC= rnberg)