Re: [Qemu-devel] [PATCH v10 12/30] qapi-introspect: Document lack of sorting

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1066 bytes --]

On 11/06/2015 08:52 AM, Markus Armbruster wrote:
> Eric Blake <eblake@redhat.com> writes:
> 
>> qapi-code-gen.txt already claims that types, commands, and
>> events share a common namespace; set this in stone by further
>> documenting that our introspection output will never have
>> collisions with the same name tied to more than one meta-type.
>>

>> For these reasons, we simply document that clients should not
>> rely on any particular order of items in introspection output.
>> And since it is now a documented part of the contract, we have
>> the freedom to later rearrange output if needed, without
>> worrying about breaking well-written clients that were already
>> aware that they had to do linear searches.
> 
> Well, any kind of search that doesn't rely on sorting.  Suggest to drop
> the "that were already..." clause.  Happy to do that on commit.

I don't see that phrase dropped in your v1 pull request. Worth fixing?

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]