From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58272) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zvu5w-0001Vf-RC for qemu-devel@nongnu.org; Mon, 09 Nov 2015 16:35:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zvu5r-0002EU-R6 for qemu-devel@nongnu.org; Mon, 09 Nov 2015 16:35:20 -0500 Message-ID: <5641116C.7060801@ilande.co.uk> Date: Mon, 09 Nov 2015 21:34:36 +0000 From: Mark Cave-Ayland MIME-Version: 1.0 References: <1447095959-10046-1-git-send-email-jsnow@redhat.com> In-Reply-To: <1447095959-10046-1-git-send-email-jsnow@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] atapi: fix NetBSD boot regression List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: armbru@redhat.com, qemu-devel@nongnu.org On 09/11/15 19:05, John Snow wrote: > Marc noticed that a recent ATAPI permissions fix broke NetBSD 7.0's > installer ISO. > > The problem is that it's meaningless to check for !(cmd->flags & nondata) > if the command isn't supported, since all unsupported commands have > _no_ flags. Effectively, all commands default to "Transfer Data" in our > model until we classify them otherwise. > > This leads to a problem where we reject a zero byte BCL PIO command that > transfers no data, simply because we have no properties for the command > at all. > > Getting an ATA rejection for this command greatly confuses NetBSD. > > Correct behavior is to reject the command at the SCSI layer for being > unsupported. > > ________________________________________________________________________________ > > For convenience, this branch is available at: > https://github.com/jnsnow/qemu.git branch atapi-bclimit-netbsd > https://github.com/jnsnow/qemu/tree/atapi-bclimit-netbsd > > This version is tagged atapi-bclimit-netbsd-v1: > https://github.com/jnsnow/qemu/releases/tag/atapi-bclimit-netbsd-v1 > > John Snow (2): > atapi: add byte_count_limit helper > atapi: Prioritize unknown cmd error over BCL error > > hw/ide/atapi.c | 38 +++++++++++++++++++++++--------------- > 1 file changed, 23 insertions(+), 15 deletions(-) I've tested this against my OpenBIOS ISO images here and it fixes the problem without introducing any further regressions, so: Tested-by: Mark Cave-Ayland Many thanks, Mark.