From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44999) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zw05g-0006BV-CN for qemu-devel@nongnu.org; Mon, 09 Nov 2015 22:59:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zw05f-0005Es-Bb for qemu-devel@nongnu.org; Mon, 09 Nov 2015 22:59:28 -0500 References: <1447127063-4662-1-git-send-email-mreitz@redhat.com> <1447127063-4662-2-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <56416B94.5050602@redhat.com> Date: Mon, 9 Nov 2015 20:59:16 -0700 MIME-Version: 1.0 In-Reply-To: <1447127063-4662-2-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="29Ij8Qi9448MJbAXGn4Bh2oSpt0GUNTih" Subject: Re: [Qemu-devel] [PATCH 1/8] qapi: Drop QERR_UNKNOWN_BLOCK_FORMAT_FEATURE List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --29Ij8Qi9448MJbAXGn4Bh2oSpt0GUNTih Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11/09/2015 08:44 PM, Max Reitz wrote: > Just specifying a custom string is simpler in basically all places that= > used it, and in addition, specifying the BB or node name is something w= e > generally do not do in other error messages when opening a BDS, so we > should not do it here. >=20 > This changes the output for iotest 036 (to the better, in my opinion), s/to/for/ to make the idiomatic expression sound correct to a native spea= ker > so the reference output needs to be changed accordingly. >=20 > Signed-off-by: Max Reitz > --- > block/qcow.c | 6 +----- > block/qcow2.c | 24 +++++------------------- > block/qed.c | 7 ++----- > block/vmdk.c | 7 ++----- > include/qapi/qmp/qerror.h | 3 --- > tests/qemu-iotests/036.out | 16 ++++++++-------- > 6 files changed, 18 insertions(+), 45 deletions(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --29Ij8Qi9448MJbAXGn4Bh2oSpt0GUNTih Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWQWuVAAoJEKeha0olJ0NqT+AH/i7y99HotFUfUj7EqXfL0ZJu y1Gs1ck3Nplkw91M9Cp5pMD0rFjRPfLqVsJgLNEHm1PA/kf/AJsUhkAEIw6PP8S3 xfNirQqAL1KiI+4BarWrQ7HhI9ic+OC2sF+n6uUpqIeNAC+sP1bFpmWZSwYuDpVc AkKzJHSBdxMKZDDui8ucvKxN52noJRdb7J26Mx4dTuem64GaK1M+dKPvlNJtL78d ppisTGUOauUPKAh7su53oxsq8HH22qXuh1VnFXRWDdjE75hZVzxdV0x7MGLMMonj UKd6gU9KgwCyfSGIUfPoanTfKnFriFbM0pyFVF09hYZCNOOEpN3Q1EIgvZtZ6zU= =BmID -----END PGP SIGNATURE----- --29Ij8Qi9448MJbAXGn4Bh2oSpt0GUNTih--