From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: [PATCH 1/2] drm/rockchip: create the fake mmap offset during gem creation Date: Tue, 10 Nov 2015 14:17:43 +0800 Message-ID: <56418C07.60208@rock-chips.com> References: <4982827.0pnZflEOSR@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <4982827.0pnZflEOSR@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: linux-rockchip.vger.kernel.org SGkgSGVpa28KICAgICAgSSBkb24ndCB0aGluayB0aGlzIHBhdGNoIGlzIG5lZWRlZCBmb3Igcm9j a2NoaXAgZHJtLCBzaW5jZSAKcm9ja2NoaXAgZHJtIG9ubHkgdXNlIGttcy4KSSBzYXcgdGhlIGRp c2N1c3Npb24gYWJvdXQgKCJkcm0vZXh5bm9zOiBjcmVhdGUgYSBmYWtlIG1tYXAgb2Zmc2V0IHdp dGggCmdlbSBjcmVhdGlvbiIpLApJbmtpIHNhaWQgdGhhdDogIlRoaXMgcGF0Y2ggbWFrZXMgZHJt X2dlbV9jcmVhdGVfbW1hcF9vZmZzZXQgdG8gYmUgCmNhbGxlZCBldmVuIGluIGNhc2Ugb2YKbm90 IHVzaW5nIGR1bWIqIGludGVyZmFjZXMuIEkuZS4sIGV4eW5vc19kcm1fZ2VtX2NyZWF0ZV9pb2N0 bCAtPiAKZXh5bm9zX2RybV9nZW1fbW1hcCIKClNvIEkgdGhpbmsgdGhpcyBwYXRjaCBkb2Vzbid0 IG1ha2Ugc2Vuc2UgZm9yIHJvY2tjaGlwIGRybS4KCgpPbiAyMDE15bm0MTHmnIgxMOaXpSAwMzo1 MCwgSGVpa28gU3R1ZWJuZXIgd3JvdGU6Cj4gU2ltaWxhcmx5IHRvIHRoZSBlcXVpdmFsZW50IGV4 eW5vcy1maXggaW4gY29tbWl0IDQ4Y2Y1M2Y0MzQzYQo+ICgiZHJtL2V4eW5vczogY3JlYXRlIGEg ZmFrZSBtbWFwIG9mZnNldCB3aXRoIGdlbSBjcmVhdGlvbiIpIHRoZSByb2NrY2hpcAo+IGRybSBk cml2ZXIgYWxzbyBjYWxscyB0aGUgZHJtX2dlbV9jcmVhdGVfbW1hcF9vZmZzZXQgZmFrZS1vZmZz ZXQgY3JlYXRpb24KPiBvbiBldmVyeSBpbnZvY2F0aW9uIG9mIHJvY2tjaGlwX2dlbV9kdW1iX21h cF9vZmZzZXQuCj4KPiBNb3ZlIHRoYXQgdG8gdGhlIGNyZWF0aW9uIG9mIHRoZSBnZW0gdG8gb25s eSBjcmVhdGUgdGhhdCBvZmZzZXQgb25jZS4KPgo+IFNpZ25lZC1vZmYtYnk6IEhlaWtvIFN0dWVi bmVyIDxoZWlrb0BzbnRlY2guZGU+Cj4gLS0tCj4gICBkcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAv cm9ja2NoaXBfZHJtX2dlbS5jIHwgMTIgKysrKysrLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwg NiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv Z3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fZ2VtLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9j a2NoaXAvcm9ja2NoaXBfZHJtX2dlbS5jCj4gaW5kZXggNGFiMmYyMC4uZTUwZDExMyAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJtX2dlbS5jCj4gKysr IGIvZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV9nZW0uYwo+IEBAIC0xMjYs OCArMTI2LDE0IEBAIHN0cnVjdCByb2NrY2hpcF9nZW1fb2JqZWN0ICoKPiAgIAlpZiAocmV0KQo+ ICAgCQlnb3RvIGVycl9mcmVlX3JrX29iajsKPiAgIAo+ICsJcmV0ID0gZHJtX2dlbV9jcmVhdGVf bW1hcF9vZmZzZXQob2JqKTsKPiArCWlmIChyZXQpCj4gKwkJZ290byBlcnJfZnJlZV9idWY7Cj4g Kwo+ICAgCXJldHVybiBya19vYmo7Cj4gICAKPiArZXJyX2ZyZWVfYnVmOgo+ICsJcm9ja2NoaXBf Z2VtX2ZyZWVfYnVmKHJrX29iaik7Cj4gICBlcnJfZnJlZV9ya19vYmo6Cj4gICAJa2ZyZWUocmtf b2JqKTsKPiAgIAlyZXR1cm4gRVJSX1BUUihyZXQpOwo+IEBAIC0xOTYsNyArMjAyLDYgQEAgaW50 IHJvY2tjaGlwX2dlbV9kdW1iX21hcF9vZmZzZXQoc3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYs Cj4gICAJCQkJIHVpbnQ2NF90ICpvZmZzZXQpCj4gICB7Cj4gICAJc3RydWN0IGRybV9nZW1fb2Jq ZWN0ICpvYmo7Cj4gLQlpbnQgcmV0Owo+ICAgCj4gICAJb2JqID0gZHJtX2dlbV9vYmplY3RfbG9v a3VwKGRldiwgZmlsZV9wcml2LCBoYW5kbGUpOwo+ICAgCWlmICghb2JqKSB7Cj4gQEAgLTIwNCwx NCArMjA5LDkgQEAgaW50IHJvY2tjaGlwX2dlbV9kdW1iX21hcF9vZmZzZXQoc3RydWN0IGRybV9m aWxlICpmaWxlX3ByaXYsCj4gICAJCXJldHVybiAtRUlOVkFMOwo+ICAgCX0KPiAgIAo+IC0JcmV0 ID0gZHJtX2dlbV9jcmVhdGVfbW1hcF9vZmZzZXQob2JqKTsKPiAtCWlmIChyZXQpCj4gLQkJZ290 byBvdXQ7Cj4gLQo+ICAgCSpvZmZzZXQgPSBkcm1fdm1hX25vZGVfb2Zmc2V0X2FkZHIoJm9iai0+ dm1hX25vZGUpOwo+ICAgCURSTV9ERUJVR19LTVMoIm9mZnNldCA9IDB4JWxseFxuIiwgKm9mZnNl dCk7Cj4gICAKPiAtb3V0Ogo+ICAgCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlX3VubG9ja2Vk KG9iaik7Cj4gICAKPiAgIAlyZXR1cm4gMDsKCgotLSAK77ytYXJrIFlhbwoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0 b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: mark.yao@rock-chips.com (Mark yao) Date: Tue, 10 Nov 2015 14:17:43 +0800 Subject: [PATCH 1/2] drm/rockchip: create the fake mmap offset during gem creation In-Reply-To: <4982827.0pnZflEOSR@phil> References: <4982827.0pnZflEOSR@phil> Message-ID: <56418C07.60208@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Heiko I don't think this patch is needed for rockchip drm, since rockchip drm only use kms. I saw the discussion about ("drm/exynos: create a fake mmap offset with gem creation"), Inki said that: "This patch makes drm_gem_create_mmap_offset to be called even in case of not using dumb* interfaces. I.e., exynos_drm_gem_create_ioctl -> exynos_drm_gem_mmap" So I think this patch doesn't make sense for rockchip drm. On 2015?11?10? 03:50, Heiko Stuebner wrote: > Similarly to the equivalent exynos-fix in commit 48cf53f4343a > ("drm/exynos: create a fake mmap offset with gem creation") the rockchip > drm driver also calls the drm_gem_create_mmap_offset fake-offset creation > on every invocation of rockchip_gem_dumb_map_offset. > > Move that to the creation of the gem to only create that offset once. > > Signed-off-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > index 4ab2f20..e50d113 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_gem.c > @@ -126,8 +126,14 @@ struct rockchip_gem_object * > if (ret) > goto err_free_rk_obj; > > + ret = drm_gem_create_mmap_offset(obj); > + if (ret) > + goto err_free_buf; > + > return rk_obj; > > +err_free_buf: > + rockchip_gem_free_buf(rk_obj); > err_free_rk_obj: > kfree(rk_obj); > return ERR_PTR(ret); > @@ -196,7 +202,6 @@ int rockchip_gem_dumb_map_offset(struct drm_file *file_priv, > uint64_t *offset) > { > struct drm_gem_object *obj; > - int ret; > > obj = drm_gem_object_lookup(dev, file_priv, handle); > if (!obj) { > @@ -204,14 +209,9 @@ int rockchip_gem_dumb_map_offset(struct drm_file *file_priv, > return -EINVAL; > } > > - ret = drm_gem_create_mmap_offset(obj); > - if (ret) > - goto out; > - > *offset = drm_vma_node_offset_addr(&obj->vma_node); > DRM_DEBUG_KMS("offset = 0x%llx\n", *offset); > > -out: > drm_gem_object_unreference_unlocked(obj); > > return 0; -- ?ark Yao