From: Jiri Slaby <jslaby@suse.cz>
To: Jessica Yu <jeyu@redhat.com>,
Rusty Russell <rusty@rustcorp.com.au>,
Josh Poimboeuf <jpoimboe@redhat.com>,
Seth Jennings <sjenning@redhat.com>,
Jiri Kosina <jikos@kernel.org>, Vojtech Pavlik <vojtech@suse.com>,
Miroslav Benes <mbenes@suse.cz>
Cc: linux-api@vger.kernel.org, live-patching@vger.kernel.org,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 3/5] livepatch: reuse module loader code to write relocations
Date: Tue, 10 Nov 2015 09:13:27 +0100 [thread overview]
Message-ID: <5641A727.6020708@suse.cz> (raw)
In-Reply-To: <1447130755-17383-4-git-send-email-jeyu@redhat.com>
On 11/10/2015, 05:45 AM, Jessica Yu wrote:
> @@ -95,7 +95,7 @@ struct klp_reloc {
> struct klp_object {
> /* external */
> const char *name;
> - struct klp_reloc *relocs;
> + struct list_head reloc_secs;
Too early to proper review the code, but you seem you never call
INIT_LIST_HEAD for this guy.
thanks,
--
js
suse labs
next prev parent reply other threads:[~2015-11-10 8:13 UTC|newest]
Thread overview: 95+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-10 4:45 [RFC PATCH 0/5] Arch-independent livepatch Jessica Yu
2015-11-10 4:45 ` Jessica Yu
2015-11-10 4:45 ` [RFC PATCH 1/5] elf: add livepatch-specific elf constants Jessica Yu
2015-11-11 13:58 ` Petr Mladek
2015-11-12 15:33 ` Josh Poimboeuf
2015-11-12 15:45 ` Josh Poimboeuf
2015-11-13 6:49 ` Jessica Yu
2015-11-10 4:45 ` [RFC PATCH 2/5] module: save load_info for livepatch modules Jessica Yu
2015-11-11 8:08 ` Minfei Huang
2015-11-11 14:17 ` Miroslav Benes
2015-11-12 5:33 ` Jessica Yu
2015-11-12 10:24 ` Petr Mladek
[not found] ` <20151112102404.GL4431-KsEp0d+Q8qECVLCxKZUutA@public.gmane.org>
2015-11-12 13:22 ` Miroslav Benes
2015-11-12 13:22 ` Miroslav Benes
[not found] ` <alpine.LNX.2.00.1511121400290.9440-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-11-12 15:03 ` Petr Mladek
2015-11-12 15:03 ` Petr Mladek
[not found] ` <20151112150345.GT2599-KsEp0d+Q8qECVLCxKZUutA@public.gmane.org>
2015-11-12 17:05 ` Josh Poimboeuf
2015-11-12 17:05 ` Josh Poimboeuf
[not found] ` <20151112170501.GD4038-M1RQNqTfbHcHO9+bouH2LOBSVt8DKT+lrE5yTffgRl4@public.gmane.org>
2015-11-12 22:17 ` Jessica Yu
2015-11-12 22:17 ` Jessica Yu
[not found] ` <20151112221750.GA13513-N0bYjD2NfQ6k4hzjq3hgyGTy53QMssKEsp+A89P3RPuQWHG76I6BsA@public.gmane.org>
2015-11-13 12:24 ` Miroslav Benes
2015-11-13 12:24 ` Miroslav Benes
[not found] ` <alpine.LNX.2.00.1511131304280.15073-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-11-13 12:46 ` Miroslav Benes
2015-11-13 12:46 ` Miroslav Benes
[not found] ` <alpine.LNX.2.00.1511131338510.15073-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-11-14 0:36 ` Jessica Yu
2015-11-14 0:36 ` Jessica Yu
[not found] ` <20151114003536.GA14759-N0bYjD2NfQ6k4hzjq3hgyGTy53QMssKEsp+A89P3RPuQWHG76I6BsA@public.gmane.org>
2015-11-16 12:12 ` Miroslav Benes
2015-11-16 12:12 ` Miroslav Benes
2015-11-13 12:56 ` Miroslav Benes
2015-11-13 12:56 ` Miroslav Benes
[not found] ` <alpine.LNX.2.00.1511131353300.15073-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-11-14 2:09 ` Jessica Yu
2015-11-14 2:09 ` Jessica Yu
[not found] ` <20151114020950.GA21414-N0bYjD2NfQ6k4hzjq3hgyGTy53QMssKEsp+A89P3RPuQWHG76I6BsA@public.gmane.org>
2015-11-16 12:21 ` Miroslav Benes
2015-11-16 12:21 ` Miroslav Benes
2015-11-13 0:25 ` Jessica Yu
[not found] ` <1447130755-17383-3-git-send-email-jeyu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-11 14:31 ` [RFC PATCH 2/5] " Petr Mladek
2015-11-11 14:31 ` Petr Mladek
[not found] ` <20151111143152.GG4431-KsEp0d+Q8qECVLCxKZUutA@public.gmane.org>
2015-11-12 4:44 ` Jessica Yu
2015-11-12 4:44 ` Jessica Yu
[not found] ` <20151112044407.GC30025-N0bYjD2NfQ6k4hzjq3hgyGTy53QMssKEsp+A89P3RPuQWHG76I6BsA@public.gmane.org>
2015-11-12 10:05 ` Petr Mladek
2015-11-12 10:05 ` Petr Mladek
[not found] ` <20151112100548.GK4431-KsEp0d+Q8qECVLCxKZUutA@public.gmane.org>
2015-11-12 14:19 ` Miroslav Benes
2015-11-12 14:19 ` Miroslav Benes
[not found] ` <alpine.LNX.2.00.1511121518080.9440-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-11-13 6:35 ` Jessica Yu
2015-11-13 6:35 ` Jessica Yu
2015-11-13 13:07 ` Miroslav Benes
2015-11-13 8:20 ` Jessica Yu
2015-11-13 8:20 ` Jessica Yu
2015-11-12 17:14 ` [RFC PATCH 2/5] " Josh Poimboeuf
2015-11-12 17:14 ` Josh Poimboeuf
2015-11-12 17:21 ` Josh Poimboeuf
2015-11-12 17:21 ` Josh Poimboeuf
2015-11-10 4:45 ` [RFC PATCH 3/5] livepatch: reuse module loader code to write relocations Jessica Yu
2015-11-10 8:13 ` Jiri Slaby [this message]
2015-11-11 14:30 ` Miroslav Benes
[not found] ` <alpine.LNX.2.00.1511111519250.12467-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-11-11 20:07 ` Jessica Yu
2015-11-11 20:07 ` Jessica Yu
[not found] ` <20151111200732.GB30025-N0bYjD2NfQ6k4hzjq3hgyGTy53QMssKEsp+A89P3RPuQWHG76I6BsA@public.gmane.org>
2015-11-12 15:27 ` Miroslav Benes
2015-11-12 15:27 ` Miroslav Benes
2015-11-12 17:40 ` Josh Poimboeuf
[not found] ` <20151112174032.GG4038-M1RQNqTfbHcHO9+bouH2LOBSVt8DKT+lrE5yTffgRl4@public.gmane.org>
2015-11-12 20:22 ` Jessica Yu
2015-11-12 20:22 ` Jessica Yu
[not found] ` <20151112202243.GC5841-N0bYjD2NfQ6k4hzjq3hgyGTy53QMssKEsp+A89P3RPuQWHG76I6BsA@public.gmane.org>
2015-11-12 20:32 ` Josh Poimboeuf
2015-11-12 20:32 ` Josh Poimboeuf
[not found] ` <20151112203221.GM4038-M1RQNqTfbHcHO9+bouH2LOBSVt8DKT+lrE5yTffgRl4@public.gmane.org>
2015-11-13 7:15 ` Jessica Yu
2015-11-13 7:15 ` Jessica Yu
2015-11-13 13:51 ` Miroslav Benes
[not found] ` <alpine.LNX.2.00.1511121601370.9440-ztGlSCb7Y1iN3ZZ/Hiejyg@public.gmane.org>
2015-11-12 19:14 ` Jessica Yu
2015-11-12 19:14 ` Jessica Yu
[not found] ` <20151112191458.GB5841-N0bYjD2NfQ6k4hzjq3hgyGTy53QMssKEsp+A89P3RPuQWHG76I6BsA@public.gmane.org>
2015-11-12 20:35 ` Jessica Yu
2015-11-12 20:35 ` Jessica Yu
2015-11-11 15:22 ` [RFC PATCH 3/5] " Petr Mladek
[not found] ` <20151111152256.GP2599-KsEp0d+Q8qECVLCxKZUutA@public.gmane.org>
2015-11-11 18:27 ` Jessica Yu
2015-11-11 18:27 ` Jessica Yu
[not found] ` <20151111182718.GA30025-N0bYjD2NfQ6k4hzjq3hgyGTy53QMssKEsp+A89P3RPuQWHG76I6BsA@public.gmane.org>
2015-11-12 9:16 ` Petr Mladek
2015-11-12 9:16 ` Petr Mladek
[not found] ` <1447130755-17383-4-git-send-email-jeyu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-12 17:59 ` [RFC PATCH 3/5] " Josh Poimboeuf
2015-11-12 17:59 ` Josh Poimboeuf
2015-11-10 4:45 ` [RFC PATCH 4/5] samples: livepatch: init reloc list and mark as klp module Jessica Yu
[not found] ` <1447130755-17383-5-git-send-email-jeyu-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-11-10 8:15 ` Jiri Slaby
2015-11-10 8:15 ` Jiri Slaby
2015-11-10 13:50 ` Josh Poimboeuf
[not found] ` <20151110135006.GB3163-8wJ5/zUtDR0XGNroddHbYwC/G2K4zDHf@public.gmane.org>
2015-11-10 18:37 ` Jessica Yu
2015-11-10 18:37 ` Jessica Yu
2015-11-11 15:42 ` [RFC PATCH 4/5] " Petr Mladek
2015-11-11 15:42 ` Petr Mladek
[not found] ` <20151111154249.GQ2599-KsEp0d+Q8qECVLCxKZUutA@public.gmane.org>
2015-11-12 6:02 ` Jessica Yu
2015-11-12 6:02 ` Jessica Yu
[not found] ` <20151112060249.GA5841-N0bYjD2NfQ6k4hzjq3hgyGTy53QMssKEsp+A89P3RPuQWHG76I6BsA@public.gmane.org>
2015-11-12 10:44 ` Miroslav Benes
2015-11-12 10:44 ` Miroslav Benes
2015-11-10 4:45 ` [RFC PATCH 5/5] livepatch: x86: remove unused relocation code Jessica Yu
2015-11-11 15:48 ` Petr Mladek
2015-11-12 18:01 ` Josh Poimboeuf
2015-11-11 14:00 ` [RFC PATCH 0/5] Arch-independent livepatch Miroslav Benes
2015-11-11 16:28 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5641A727.6020708@suse.cz \
--to=jslaby@suse.cz \
--cc=jeyu@redhat.com \
--cc=jikos@kernel.org \
--cc=jpoimboe@redhat.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=rusty@rustcorp.com.au \
--cc=sjenning@redhat.com \
--cc=vojtech@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.