Re: [PATCH v3 08/32] scsi: hisi_sas: add hisi_sas_remove

[John Garry <john.garry@huawei.com>]

>> +int hisi_sas_remove(struct platform_device *pdev)
>> +{
>> +	struct sas_ha_struct *sha = platform_get_drvdata(pdev);
>> +	struct hisi_hba *hisi_hba = sha->lldd_ha;
>> +
>> +	sas_unregister_ha(sha);
>> +	sas_remove_host(sha->core.shost);
>> +	scsi_remove_host(sha->core.shost);
>
> scsi host should be removed before detaching SAS transport.
>
> See more information:
> http://www.spinics.net/lists/linux-scsi/msg90088.html
>
> Thanks,
> Wei
>
OK, I can make this minor change.

Thanks,
John

>> +	hisi_sas_free(hisi_hba);
>> +	return 0;
>> +}
>> +EXPORT_SYMBOL_GPL(hisi_sas_remove);
>> +
>>   static __init int hisi_sas_init(void)
>>   {
>>   	pr_info("hisi_sas: driver version %s\n", DRV_VERSION);
>>
>
>
> .
>