From: Lars-Peter Clausen <lars@metafoo.de>
To: Jyri Sarha <jsarha@ti.com>, alsa-devel@alsa-project.org
Cc: liam.r.girdwood@linux.intel.com, peter.ujfalusi@ti.com,
broonie@kernel.org
Subject: Re: [PATCH] ASoC: damp: Reset dapm wcache after freeing damp widgets
Date: Tue, 10 Nov 2015 12:31:44 +0100 [thread overview]
Message-ID: <5641D5A0.60606@metafoo.de> (raw)
In-Reply-To: <1447075826-641-1-git-send-email-jsarha@ti.com>
On 11/09/2015 02:30 PM, Jyri Sarha wrote:
[...]
> diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
> index ff8bda4..d78db59 100644
> --- a/sound/soc/soc-dapm.c
> +++ b/sound/soc/soc-dapm.c
> @@ -2286,6 +2286,9 @@ static void dapm_free_widgets(struct snd_soc_dapm_context *dapm)
> continue;
> snd_soc_dapm_free_widget(w);
> }
> +
> + dapm->path_sink_cache.widget = NULL;
> + dapm->path_source_cache.widget = NULL;
> }
Looks good, but this is not the only place where we free widgets. Can you
add a helper function snd_soc_dapm_reset_cache() (or similar) and then call
this from dapm_free_widgets() as well as snd_soc_tplg_widget_remove_all().
- Lars
prev parent reply other threads:[~2015-11-10 11:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 13:30 [PATCH] ASoC: damp: Reset dapm wcache after freeing damp widgets Jyri Sarha
2015-11-10 10:37 ` Charles Keepax
2015-11-10 11:31 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5641D5A0.60606@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jsarha@ti.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.