From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 856AAE00AF2; Tue, 10 Nov 2015 07:34:05 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 50419E00AD7 for ; Tue, 10 Nov 2015 07:34:01 -0800 (PST) Received: by wmww144 with SMTP id w144so5721957wmw.0 for ; Tue, 10 Nov 2015 07:34:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel_com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=W51C0ZRTZ4NpLJX+/Mh90pwq6EE+V6qr39ZbjyzJKCw=; b=snRZ1SRd5h1AVPqsvU4IXS3TzgCQ00T45nXNMlDL5vE30sjzoToVSwF8wYU1nuJ6Dr 87C9LM9Ow/MKI8InAhT0uKvbrEk5DPYet46H8P+kSuJtg9KmKBcIu0H07fZI6moWqpfl vqE+K51enqmWMkOGrcTrrdS7cxOz1iCEqI052euoA5n/yu5FAoBj02pQfw8PJGDg8Jam 9r6BpITXClHSWfHkLkAPKh41S5kpu2lcxGdRJbIUaK1iWpgc83iGC8GQVb5rxkEtgqbQ yHVG0v+Perq9ZArnYW0x9udPjpNLcsnzZkF7Kh4IIrTfna/Zd0QjoVwVdYUacq1blHyA wVBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=W51C0ZRTZ4NpLJX+/Mh90pwq6EE+V6qr39ZbjyzJKCw=; b=UfIxa7lq3gPW5E7mpmIoC2+xSaGgCT4XYIU0bxUmSaxOy40b06xYeIqvx8YuwuLi33 +qLckEyPRxOQiGXjtkE/N/6vQSV6/LQp6uQ/zRqjB7F9BwRmdNRG/NRL0J1uaMUpiqrq yb+me2l8ubPK5AlwF/5yKzxigBm5UBnX4Wp8vtUnbwkdnDz4yq/ZJOHWiSg6Up1LfqQb vbNccQyZTidNhCljQmSvaAgF/sIZrD+ouq+R8OmsJhFxNnslLM+ilxKOgEFsWH5109mi 26clReha9PrLb/Ld+Nn5kvtCbh5wl8U25Kytw8Eh2NcCZmGxVjHDQlFfDzk2rNWZdCGa GuCQ== X-Gm-Message-State: ALoCoQmnbU8F7a7gYFNPS72SwORsCY0xuUMfauzDjHwWOV5uMel1E5SvIGkKM//ubT8/kBoE/Bri X-Received: by 10.28.144.10 with SMTP id s10mr5767323wmd.23.1447169639555; Tue, 10 Nov 2015 07:33:59 -0800 (PST) Received: from [192.168.0.22] ([90.199.203.61]) by smtp.googlemail.com with ESMTPSA id r65sm20379883wmb.20.2015.11.10.07.33.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 07:33:58 -0800 (PST) To: toaster@yoctoproject.org References: <1447167061-11829-1-git-send-email-belen.barros.pena@linux.intel.com> From: Michael Wood Message-ID: <56420E66.9070707@intel.com> Date: Tue, 10 Nov 2015 15:33:58 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447167061-11829-1-git-send-email-belen.barros.pena@linux.intel.com> Subject: Re: [PATCH] toaster: Bring back the download icon X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 15:34:05 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit On 10/11/15 14:51, Belen Barros Pena wrote: > From: Belen Barros Pena > > The 'all builds' page was missing the download icon > next to the outcome icon, which allows you to download > a build log from the 'all builds' page. > > This patch brings it back. > > Signed-off-by: Belen Barros Pena > --- > bitbake/lib/toaster/toastergui/templates/builds.html | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/bitbake/lib/toaster/toastergui/templates/builds.html b/bitbake/lib/toaster/toastergui/templates/builds.html > index a27a121..9f07211 100644 > --- a/bitbake/lib/toaster/toastergui/templates/builds.html > +++ b/bitbake/lib/toaster/toastergui/templates/builds.html > @@ -62,7 +62,13 @@ > {% for build in objects %} > > > - {%if build.outcome == build.SUCCEEDED%}{%elif build.outcome == build.FAILED%}{%else%}{%endif%}   > + {%if build.outcome == build.SUCCEEDED%}{%elif build.outcome == build.FAILED%}{%else%}{%endif%} > + {% if build.project %} > +   > + > + > + > + {% endif %} > > > {% for t in build.target_set.all %} Could you format the template logic on that first line so that there is indentation in the logic sequence, for ease of reading. To avoid an empty else statement it's better to switch round the logic to be inclusive. Something more like {% if build.outcome == build.SUCCEEDED or build.outcome == build.FAILED %} {% endif %} more info on https://wiki.yoctoproject.org/wiki/Contribute_to_Toaster#Templates Thanks Michael