Re: [PATCH 00/25] Exynos DRM: new life of IPP (Image Post Processing) subsystem

[Tobias Jakobi <tjakobi@math.uni-bielefeld.de>]

Hello Marek,

this looks very interesting. I'll try to integrate this with my mpv DRM
backend once the colorspace conversion bits are implemented.

I also wanted to suggest that using the IPP blocks (rotator, FIMC)
should be still be possible without any kind of display active. So
similar in the way I can use the G2D block without presenting anything
on the screen itself.

I'm take a closer look at the series later.

With best wishes,
Tobias




Marek Szyprowski wrote:
> Dear All,
> 
> This patch series introduces a new life into Exynos IPP (Image Post
> Processing) subsystem by integrating it (transparently for userspace
> applications) with Exynos DRM core plane management. This means that all
> CRTC drivers transparently get support for standard features of IPP
> subsystem like rotation and scaling.
> 
> Support for features not supported natively by CRTC drivers is
> implemented with a help of temporary framebuffers, where image data is
> processed by IPP subsystem before performing the scanout by a CRTC driver.
> 
> This patchset is a first version of this 'new feature' and I would like
> get some comments on the proposed approach. I plan to continue working
> on enhancing Exynos DRM drivers and especially do the cleanup the IPP
> subsystem.
> 
> Most of the new features are added by the last 2 patches. All other
> patches are bugfixes in various Exynos DRM subdrivers and significant
> core rewrite - introducing a subclass of drm_plane_state was needed and
> all drivers have been converted to use it. Some initial cleanups in IPP
> subsystem were also needed to let Exynos core to call it internally from
> the driver core. This part will be cleaned even more in the future.
> 
> 
> My solution has been tested on Exynos4412-based Odroid U3 and
> Exynos5420-based Odroid XU3. To check rotation, cropping and scaling
> I've developed a simple test application, which use atomic mode
> setting/page flipping API. You can download it here:
> 
> https://git.linaro.org/?p=people/marek.szyprowski/atomictest.git
> 
> The application draws a rectangle with test pattern and then moves it
> around the screen. To see how all mentioned features work (plane
> rotation, cropping, scaling and off-screen display), please run the
> following commands:
> 
> scaling + rotation:
> # ./atomictest -b400x300 -f60 -t100 -m2x1 -x1x1
> 
> cropping + rotation:
> # ./atomictest -b400x300 -f60 -t100 -m2x1 -c1x1
> 
> cropping + rotation + off-screen display:
> # ./atomictest -b400x300 -f60 -t100 -m2x1 -c1x1 -o400x300
> 
> scaling + cropping + rotation:
> # ./atomictest -b400x300 -f60 -t100 -m2x1 -x1x1 -c1x1 
> 
> For more information about parameters, run the application with -h
> parameter or check the source code.
> 
> 
> My TODO list (please comment the priority of those tasks):
> 
> 1. add support for color space conversion, support for foreign pixel
> formats and fb-modifiers to my plane-IPP integration code (currently
> only RGB single plane modes are supported)
> 
> 2. provide support for IPP features (framebuffer rotation, scaling,
> cropping, color space conversion) with userspace atomic API instead of
> (or together with) Exynos custom IPP ioctls; the important question is
> weather the existing Exynos IPP API (userspace ioctls) should be kept or
> can be removed (existing userspace API is misleading in many aspects).
> 
> 3. simplify IPP subsystem core (the code looks over-engineered a bit,
> there are also some known issues with error paths), remove
> non-functional write-back and output modes
> 
> 4. simplify interface to IPP HW-specific mem2mem subdrivers
> 
> 5. implement output mode for IPP sub-drivers, use it where possible
> instead of using temporary framebuffer (image data is then transferred
> directly from scaling hw block to display engine via local path, no
> temporary framebuffers are needed)
> 
> 6. implement write-back feature with atomic API as respective CRTC
> properties
> 
> 
> Patches have been prepared on top of linux-next from 10-11-2015. First
> 2 patches should be applied to Samsung SoC tree, all other should go
> to Exynos DRM tree.
> 
> Best regards
> Marek Szyprowski
> Samsung R&D Institute Poland
> 
> 
> Patch summary:
> 
> Marek Szyprowski (21):
>   ARM: dts: exynos4: add rotator nodes
>   ARM: dts: exynos542x: add rotator node
>   drm/exynos: gsc: add device tree support and remove usage of static
>     mappings
>   drm/exynos: rotator: convert to common clock framework
>   drm/exynos: exynos7-decon: remove excessive check
>   drm/exynos: move dma_addr attribute from exynos plane to exynos fb
>   drm/exynos: introduce exynos_drm_plane_state structure
>   drm/exynos: mixer: use crtc->state->adjusted_mode instead of
>     crtc->mode
>   drm/exynos: mixer: enable video overlay plane only when VP is
>     available
>   drm/exynos: introduce exynos_drm_plane_config structure
>   drm/exynos: add generic check for plane state
>   drm/exynos: mixer: use ratio precalculated in exynos_state
>   drm/exynos: fix clipping when scalling is enabled
>   drm/exynos: fimd: fix dma burst size setting for small plane size
>   drm/exynos: add fb pointer to exynos_drm_plane_state
>   drm/exynos: gem: set default alignment for dumb GEM buffers
>   drm/exynos: gem: remove old unused prototypes
>   drm/exynos: gem: simplify access to exynos gem object
>   drm/exynos: ipp: make framework context global
>   drm/exynos: add generic plane rotation property support
>   drm/exynos: add support for plane scaling
> 
> Seung-Woo Kim (4):
>   drm/exynos: gsc: prepare and unprepare gsc clock
>   drm/exynos: gsc: fix wrong pm_runtime state
>   drm/exynos: fix to calculate offset of each plane for ipp fimc
>   drm/exynos: fix to calculate offset of each plane for ipp gsc
> 
>  .../devicetree/bindings/media/exynos5-gsc.txt      |   4 +
>  arch/arm/boot/dts/exynos4.dtsi                     |  10 +-
>  arch/arm/boot/dts/exynos4210.dtsi                  |   8 +
>  arch/arm/boot/dts/exynos4x12.dtsi                  |   4 +
>  arch/arm/boot/dts/exynos5420.dtsi                  |  19 ++
>  drivers/gpu/drm/exynos/Kconfig                     |  10 +-
>  drivers/gpu/drm/exynos/Makefile                    |   1 +
>  drivers/gpu/drm/exynos/exynos5433_drm_decon.c      |  48 ++--
>  drivers/gpu/drm/exynos/exynos7_drm_decon.c         |  68 ++---
>  drivers/gpu/drm/exynos/exynos_drm_drv.h            |  97 +++++--
>  drivers/gpu/drm/exynos/exynos_drm_fb.c             |  16 +-
>  drivers/gpu/drm/exynos/exynos_drm_fb.h             |   3 +-
>  drivers/gpu/drm/exynos/exynos_drm_fimc.c           | 106 ++++++++
>  drivers/gpu/drm/exynos/exynos_drm_fimd.c           |  88 ++++---
>  drivers/gpu/drm/exynos/exynos_drm_g2d.c            |  48 ++--
>  drivers/gpu/drm/exynos/exynos_drm_gem.c            |  54 +---
>  drivers/gpu/drm/exynos/exynos_drm_gem.h            |  51 +---
>  drivers/gpu/drm/exynos/exynos_drm_gsc.c            | 151 ++++++++++-
>  drivers/gpu/drm/exynos/exynos_drm_ipp.c            | 237 +++++++++++++----
>  drivers/gpu/drm/exynos/exynos_drm_ipp.h            |   8 +-
>  drivers/gpu/drm/exynos/exynos_drm_plane.c          | 255 +++++++++++++------
>  drivers/gpu/drm/exynos/exynos_drm_plane.h          |   7 +-
>  drivers/gpu/drm/exynos/exynos_drm_plane_ipp.c      | 281 +++++++++++++++++++++
>  drivers/gpu/drm/exynos/exynos_drm_plane_ipp.h      |  73 ++++++
>  drivers/gpu/drm/exynos/exynos_drm_rotator.c        |   4 +-
>  drivers/gpu/drm/exynos/exynos_drm_vidi.c           |  30 ++-
>  drivers/gpu/drm/exynos/exynos_mixer.c              | 133 +++++-----
>  drivers/gpu/drm/exynos/regs-gsc.h                  |   4 +-
>  28 files changed, 1348 insertions(+), 470 deletions(-)
>  create mode 100644 drivers/gpu/drm/exynos/exynos_drm_plane_ipp.c
>  create mode 100644 drivers/gpu/drm/exynos/exynos_drm_plane_ipp.h
> 

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel