From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id B9388E00BAB; Tue, 10 Nov 2015 09:12:18 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily * valid * -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 2180AE00A9B for ; Tue, 10 Nov 2015 09:12:16 -0800 (PST) Received: by wmdw130 with SMTP id w130so80275943wmd.0 for ; Tue, 10 Nov 2015 09:12:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel_com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-type:content-transfer-encoding; bh=/Oxymq2w+1rhTc++DF1CyWPGfhnv1aWJDTN1v5/IONo=; b=lBvj2TJOC7JIXRh4b5YjHuzS5jPPY82MguSiPSvuXSgrhsGpv8huVllNKmMHIm/63C mQzrWSuoIHSXf8ikYO8OqMg47oyxNuUJtdTFhNURU6GRvszmCSxZGwvj9Z7/VnEHx0M7 1XQ8ebTOqXSD5lyZ7zBD+8PxJp+Kf2X00HiprUCadDErR6NXyQ6sNHTEG6jx6a1Er19e fjbkqswy2B0lDvOelEm0/nZAEcLbDpDg/0lOGwHPjeIYGN07fkg9Upe74aBjoM0fEJ6t NNBvrjrqvQ5ShX5Rw6UEllx9Im/xt1QbO4CtlEdm62xfApDArfSYPmxUeem650vUh6gb Yzew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=/Oxymq2w+1rhTc++DF1CyWPGfhnv1aWJDTN1v5/IONo=; b=U6C2E4QG1GDNZPVkK3EQWm+/PWruL+sfgqLvQWr/uC/epLn7vDBBVrZk3eJ8FnVKNl jUhpAljs3oJjVhd1ruz7nKYtU+NWq2Tv+bOzizKL8KnDJSTIF9lPQdINfdE85KVOU0jg 4DPjyQhGkstaCFeTPJmdaNJtQbKXVaJHZacpRO/LkHofJyNRprzTa3K1VHUCAcLx+AJ/ 3TrK0QMg8Y1VEaWKsNJlFo0EE0Z55TVzWGGtGKB9WsqJFyezzJdrAJ/z/3TU36crN0Yn ML6a/ZGE++vCMWtXwcQzdGKkkGu9vSDUXyP+k4v9qz28QUplJAJjyZsY0LaNIy5+il2i XNSA== X-Gm-Message-State: ALoCoQmi0VIzoCeniVFp63GgLZbbpkyjvLFcdKaE9Lui0Sp9aX0QWTeZbaYBRmmDL5Ep0F2wf4YD X-Received: by 10.194.52.68 with SMTP id r4mr308125wjo.8.1447175535825; Tue, 10 Nov 2015 09:12:15 -0800 (PST) Received: from [192.168.0.22] ([90.199.203.61]) by smtp.googlemail.com with ESMTPSA id pn6sm333094wjb.15.2015.11.10.09.12.15 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 09:12:15 -0800 (PST) To: toaster@yoctoproject.org References: <1447174333-14130-1-git-send-email-belen.barros.pena@linux.intel.com> From: Michael Wood Message-ID: <5642256E.8000907@intel.com> Date: Tue, 10 Nov 2015 17:12:14 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447174333-14130-1-git-send-email-belen.barros.pena@linux.intel.com> Subject: Re: [PATCH] [v2] toaster: Fix the download icon X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 17:12:18 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Thanks upstreamed and pushed to toaster-next with additions to make commit message more descriptive. On 10/11/15 16:52, Belen Barros Pena wrote: > From: Belen Barros Pena > > The 'all builds' page was missing the download icon > next to the outcome icon, which allows you to download > a build log from the 'all builds' page. > > This patch brings it back. > > It also adds a check in the project builds page to make > sure the download icon only appears if the build generates > a cooker log, since builds that fail at the build request > stage do not generate a cooker log. > > Signed-off-by: Belen Barros Pena > --- > bitbake/lib/toaster/toastergui/templates/builds.html | 8 +++++++- > bitbake/lib/toaster/toastergui/templates/projectbuilds.html | 11 ++++++----- > 2 files changed, 13 insertions(+), 6 deletions(-) > > diff --git a/bitbake/lib/toaster/toastergui/templates/builds.html b/bitbake/lib/toaster/toastergui/templates/builds.html > index a27a121..c3cc266 100644 > --- a/bitbake/lib/toaster/toastergui/templates/builds.html > +++ b/bitbake/lib/toaster/toastergui/templates/builds.html > @@ -62,7 +62,13 @@ > {% for build in objects %} > > > - {%if build.outcome == build.SUCCEEDED%}{%elif build.outcome == build.FAILED%}{%else%}{%endif%}   > + {%if build.outcome == build.SUCCEEDED%}{%elif build.outcome == build.FAILED%}{%else%}{%endif%} > + {% if build.cooker_log_path %} > +   > + > + > + > + {% endif %} > > > {% for t in build.target_set.all %} > diff --git a/bitbake/lib/toaster/toastergui/templates/projectbuilds.html b/bitbake/lib/toaster/toastergui/templates/projectbuilds.html > index bb38284..3402fc4 100644 > --- a/bitbake/lib/toaster/toastergui/templates/projectbuilds.html > +++ b/bitbake/lib/toaster/toastergui/templates/projectbuilds.html > @@ -63,11 +63,12 @@ > {% for build in objects %} {# if we have a build, just display it #} > > {%if build.outcome == build.SUCCEEDED%}{%elif build.outcome == build.FAILED%}{%else%}{%endif%} > - {% if build.project %} > -   > - > - > - {% endif %} > + {% if build.cooker_log_path %} > +   > + > + > + > + {% endif %} > > >