From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZwDjx-0004ZS-8Y for mharc-grub-devel@gnu.org; Tue, 10 Nov 2015 13:33:57 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwDju-0004YP-Iv for grub-devel@gnu.org; Tue, 10 Nov 2015 13:33:55 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwDjr-0000tv-A5 for grub-devel@gnu.org; Tue, 10 Nov 2015 13:33:54 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:21498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwDjr-0000t1-3i for grub-devel@gnu.org; Tue, 10 Nov 2015 13:33:51 -0500 Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.15.0.59/8.15.0.59) with SMTP id tAAIVfBY020522 for ; Tue, 10 Nov 2015 10:33:49 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=subject : to : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=facebook; bh=Nr0oXLHZ3Wt28htFRyRmEXX9GwJyDfedun1aBGS4Iw0=; b=T0TEGlD5iuwUE3LwLsiHzN03mBNjYPnzmrhfPzfeqmPp7vJlr/g3wxwNVzeWzvckWJTx oknHa8MVXOich3LMxaQcnJdA91ZevFJNB0dF4hHoa1rRzCqG43KUJ01KgC46payRVBMe kTeTs6IOQ/8eLlgWkYRwPSAKpPGMlnZO6dY= Received: from mail.thefacebook.com ([199.201.64.23]) by m0001303.ppops.net with ESMTP id 1y1duhbmp3-3 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NOT) for ; Tue, 10 Nov 2015 10:33:49 -0800 Received: from localhost.localdomain (192.168.52.123) by mail.thefacebook.com (192.168.16.16) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 10 Nov 2015 10:33:46 -0800 Subject: Re: [PATCH] efinet: add efinet_multicast_filter command To: The development of GNU GRUB References: <1446751432-2184661-1-git-send-email-jbacik@fb.com> From: Josef Bacik Message-ID: <56423889.2050401@fb.com> Date: Tue, 10 Nov 2015 13:33:45 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.52.123] X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2015-11-10_13:, , signatures=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-Received-From: 67.231.153.30 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 18:33:55 -0000 On 11/05/2015 03:28 PM, Vladimir 'phcoder' Serbinenko wrote: > I don't have EFI spec under my hand now. Can we get away with making it > a default or at least for the case when no interface overrides mac > address. Extra config to workaround firmware bugs is usually harmful > So I made us start setting the mac filter at open time and the problem still happened. I"ve been running down what is going on since then and it seems there is a timing window between setting the receive filters and the card actually honoring the settings. I've now gotten to the point that it works if I set the receive filters and then reset the interface and then set the mac filter. This is horrible, and I may be able to get it to work less horribly but it feels more and more like my option is the least painful way. I'll get it working as cleanly as possible and send that patch out and you can decide which approach you hate the least. Thanks, Josef