From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752182AbbKJWkT (ORCPT ); Tue, 10 Nov 2015 17:40:19 -0500 Received: from mga02.intel.com ([134.134.136.20]:22608 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751284AbbKJWkQ (ORCPT ); Tue, 10 Nov 2015 17:40:16 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.20,272,1444719600"; d="scan'208";a="847400309" Subject: Re: [PATCH] x86/fpu: Fix get_xsave_addr which returns error pointer to KVM To: Huaitong Han , tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com References: <1446800423-21622-1-git-send-email-huaitong.han@intel.com> Cc: x86@kernel.org, linux-kernel@vger.kernel.org From: Dave Hansen Message-ID: <56427250.1020407@intel.com> Date: Tue, 10 Nov 2015 14:40:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1446800423-21622-1-git-send-email-huaitong.han@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2015 01:00 AM, Huaitong Han wrote: > when KVM uses the get_xsave_addr, xsave parameter belongs to guest vcpu, if > xsave is replaced with current task (host) xsave, get_xsave_addr will return error > xsave addr to KVM. > > Signed-off-by: Huaitong Han Looks good to me. It was completely bogus that we passed 'xsave' in there and then just wrote over it. Reviewed-by: Dave Hansen