Re: [PATCH] ARM: dts: exynos5422-odroid*: remove fimd node

[Krzysztof Kozlowski <k.kozlowski@samsung.com>]

On 10.11.2015 19:24, Marek Szyprowski wrote:
> FIMD device is not used at all on Exynos5422-based Odroid XU3-lite and
> XU4. XU3 board teorethically can support FIMD with DisplayPort

s/teorethically/theoretically/

> connector, but due to hw limitation/design it doesn't work in most
> cases. It is also not even enabled in XU3 dts file.
> 
> FIMD node was enabled mainly due to limitation of early Exynos DRM
> driver, which didn't initialize properly when no FIMD device was
> available. This node can be now safetly removed from XU3-common dtsi and

s/safetly/safely/

> added layer to Odroid XU3 dts, when Display Port driver gets enabled.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi | 5 -----
>  1 file changed, 5 deletions(-)

Tested on Odroid XU4 board (HDMI, IOMMU enabled):

Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>


No need for respin, the changelog fixes above can be done during applying.


BTW, do you know why we don't have EXYNOS_IOMMU enabled in defconfig?
Any reasons against?

Best regards,
Krzysztof


> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> index 1af5bdc..9134217 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi
> @@ -67,11 +67,6 @@
>  			<19200000>;
>  };
>  
> -&fimd {
> -	status = "okay";
> -};
> -
> -
>  &hdmi {
>  	status = "okay";
>  	hpd-gpio = <&gpx3 7 GPIO_ACTIVE_HIGH>;
>