All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Ian Campbell <ian.campbell@citrix.com>,
	stefano.stabellini@eu.citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 3/8] xen: arm: Refactor route_irq_to_guest
Date: Wed, 11 Nov 2015 11:46:25 +0000	[thread overview]
Message-ID: <56432A91.90407@citrix.com> (raw)
In-Reply-To: <1447172473-21405-3-git-send-email-ian.campbell@citrix.com>

Hi Ian,

On 10/11/15 16:21, Ian Campbell wrote:
> Split out the bit which allocates the struct irqaction and calls
> __setup_irq into a new function (setup_guest_irq). I'm going to want
> to call this a second time in a subsequent patch.
> 
> Note that the action is now allocated and initialised with the desc
> lock held (since it is taken by the caller). I don't think this is an
> issue (and avoiding this would make things more complex)

There is one potential issue, the desc->lock has to be taken with
interrupt disabled.

With this change, the interrupts are disabled far more longer than
previously.

I'm mostly worry about the xmalloc and the printk within this section.

Regards,

-- 
Julien Grall

  reply	other threads:[~2015-11-11 11:46 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 16:20 [PATCH v2] xen: arm: context switch vtimer PPI state Ian Campbell
2015-11-10 16:21 ` [PATCH v2 1/8] xen: arm: fix indendation of struct vtimer Ian Campbell
2015-11-10 22:18   ` Julien Grall
2015-12-22 16:54   ` Stefano Stabellini
2015-11-10 16:21 ` [PATCH v2 2/8] xen: arm: fix typo in the description of struct pending_irq->desc Ian Campbell
2015-11-10 22:19   ` Julien Grall
2015-12-22 16:55   ` Stefano Stabellini
2015-11-10 16:21 ` [PATCH v2 3/8] xen: arm: Refactor route_irq_to_guest Ian Campbell
2015-11-11 11:46   ` Julien Grall [this message]
2015-11-10 16:21 ` [PATCH v2 4/8] xen: arm: remove vgic_vcpu_inject_spi() Ian Campbell
2015-12-22 18:32   ` Stefano Stabellini
2015-11-10 16:21 ` [PATCH v2 5/8] xen: arm: add interfaces to save/restore the state of a PPI Ian Campbell
2015-11-11 12:49   ` Julien Grall
2015-11-11 13:03     ` Ian Campbell
2015-11-10 16:21 ` [PATCH v2 6/8] xen: arm: supporting routing a PPI to the current vcpu Ian Campbell
2015-11-11 14:37   ` Julien Grall
2015-11-10 16:21 ` [PATCH v2 7/8] xen: arm: context switch vtimer PPI state Ian Campbell
2015-11-11 14:42   ` Julien Grall
2015-12-22 19:15   ` Stefano Stabellini
2015-11-10 16:21 ` [PATCH v2 8/8] HACK: Force virt timer to PPI0 (IRQ16) Ian Campbell
2015-11-11 12:49 ` [PATCH v2] xen: arm: context switch vtimer PPI state Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56432A91.90407@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=ian.campbell@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.