From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47137)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZwVPo-0000tc-Rk
	for qemu-devel@nongnu.org; Wed, 11 Nov 2015 08:26:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1ZwVPm-0000t4-O1
	for qemu-devel@nongnu.org; Wed, 11 Nov 2015 08:26:20 -0500
References: <1447224690-9743-1-git-send-email-eblake@redhat.com>
	<1447224690-9743-19-git-send-email-eblake@redhat.com>
From: =?UTF-8?Q?Andreas_F=c3=a4rber?= <afaerber@suse.de>
Message-ID: <564341ED.30804@suse.de>
Date: Wed, 11 Nov 2015 14:26:05 +0100
MIME-Version: 1.0
In-Reply-To: <1447224690-9743-19-git-send-email-eblake@redhat.com>
Content-Type: text/plain; charset=iso-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v11 18/28] qerror: more error_setg() usage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Jiri Pirko <jiri@resnulli.us>, Eduardo Habkost <ehabkost@redhat.com>, qemu-block <qemu-block@nongnu.org>, "Michael S. Tsirkin" <mst@redhat.com>, Jason Wang <jasowang@redhat.com>, armbru@redhat.com, Scott Feldman <sfeldma@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>, Richard Henderson <rth@twiddle.net>

Am 11.11.2015 um 07:51 schrieb Eric Blake:
> A few uses of error_set(ERROR_CLASS_GENERIC_ERROR) have snuck in
> since c6bd8c706.  Nuke them.
>=20
> Signed-off-by: Eric Blake <eblake@redhat.com>
[...]
> diff --git a/qom/object.c b/qom/object.c
> index fc6e161..c0decb6 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -1330,8 +1330,8 @@ static Object *object_resolve_link(Object *obj, c=
onst char *name,
>      target =3D object_resolve_path_type(path, target_type, &ambiguous)=
;
>=20
>      if (ambiguous) {
> -        error_set(errp, ERROR_CLASS_GENERIC_ERROR,
> -                  "Path '%s' does not uniquely identify an object", pa=
th);
> +        error_setg(errp, "Path '%s' does not uniquely identify an obje=
ct",
> +                   path);
>      } else if (!target) {
>          target =3D object_resolve_path(path, &ambiguous);
>          if (target || ambiguous) {

Acked-by: Andreas F=E4rber <afaerber@suse.de>

No idea why it's this way, maybe predated the function?

Regards,
Andreas

--=20
SUSE Linux GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Felix Imend=F6rffer, Jane Smithard, Graham Norton; HRB 21284 (AG N=FC=
rnberg)