From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2 4/4] x86/traps: honor EXT bit in error codes Date: Wed, 11 Nov 2015 15:50:21 +0000 Message-ID: <564363BD.5040207@citrix.com> References: <5642390402000078000B384D@prv-mh.provo.novell.com> <56423A2302000078000B3865@prv-mh.provo.novell.com> <5642355C.6070400@citrix.com> <5643170802000078000B3ABA@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1ZwXfn-0006pz-3o for xen-devel@lists.xenproject.org; Wed, 11 Nov 2015 15:50:59 +0000 In-Reply-To: <5643170802000078000B3ABA@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Keir Fraser List-Id: xen-devel@lists.xenproject.org On 11/11/15 09:23, Jan Beulich wrote: > The specification does not explicitly limit the use of this bit to > exceptions that can have selector style error codes, so to be on the > safe side we should deal with it being set even on error codes formally > documented to be always zero (if they're indeed always zero, the change > is simply dead code in those cases). > > Introduce and use (where suitable) X86_XEC_* constants to make the code > easier to read. > > To match the placement of the "hardware_trap" label, the "hardware_gp" > one gets moved slightly too. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper