From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZwbaI-0005Go-Vn for mharc-grub-devel@gnu.org; Wed, 11 Nov 2015 15:01:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwbaF-0005Er-CE for grub-devel@gnu.org; Wed, 11 Nov 2015 15:01:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwbaE-0002S5-Kd for grub-devel@gnu.org; Wed, 11 Nov 2015 15:01:31 -0500 Received: from mail-wm0-x22d.google.com ([2a00:1450:400c:c09::22d]:34962) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwbaE-0002S0-Da for grub-devel@gnu.org; Wed, 11 Nov 2015 15:01:30 -0500 Received: by wmdw130 with SMTP id w130so127197786wmd.0 for ; Wed, 11 Nov 2015 12:01:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type; bh=ReIfzsd1FfFc7wLyqfMISQNAcGovxLb6QszZHQUe2fg=; b=DqNOuKFcAFLarp4v87kGrRZ90NtVQWRloYkGmfMtTpHm7pm1F1FcgI58/bO91gGTeV tLoPLyAYtXSniW7GboO8e/JWOtT3+JhR4FPYQWfTmdwnzVfAZHIkUbJtnpnh5V3o4EEK 0HZtBog437yIHIQCh077NqtyVgvkoW/GEq54giAPpIRmEPbaeSeqDZiKCreKLQOMC0xb vkLaO6mu2AMi2bHIJ/RuQbcWF43Wv0swdWwGx7RvwhrQJ8Q4A/zENCMO8M/OG6A6aHIK iihGpMhgE+DFLKOHt8pObMklBkODZxp6XzjutqlDt25ov2i437TsdNl1cLv1E46I54GY r2lA== X-Received: by 10.28.226.11 with SMTP id z11mr204157wmg.56.1447272089684; Wed, 11 Nov 2015 12:01:29 -0800 (PST) Received: from ?IPv6:2a02:1205:34c8:dc00:863a:4bff:fe50:abc4? ([2a02:1205:34c8:dc00:863a:4bff:fe50:abc4]) by smtp.gmail.com with ESMTPSA id q3sm10621374wjr.34.2015.11.11.12.01.27 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 Nov 2015 12:01:28 -0800 (PST) Subject: Re: [PATCH v4] ofdisk: add sas disks to the device list To: The development of GNU GRUB References: <1447247672-20823-1-git-send-email-pfsmorigo@linux.vnet.ibm.com> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <56439E90.3080200@gmail.com> Date: Wed, 11 Nov 2015 21:01:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447247672-20823-1-git-send-email-pfsmorigo@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="XuMkqx5qJF5nCDO8gCwEnjNO64hsiQF8M" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c09::22d Cc: Paulo Flabiano Smorigo X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Nov 2015 20:01:32 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XuMkqx5qJF5nCDO8gCwEnjNO64hsiQF8M Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 11.11.2015 14:14, Paulo Flabiano Smorigo wrote: > + ptr =3D (grub_uint64_t *) (table + sizeof (grub_uint64_t) * = i); > + grub_snprintf (bufptr, 32, "/disk@%" PRIxGRUB_UINT64_T, *ptr= ); Please declare table as being grub_uint64_t * and then just use table[i]. This code violates cast-align --XuMkqx5qJF5nCDO8gCwEnjNO64hsiQF8M Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlZDnpAACgkQmBXlbbo5nOuFHgD/aE7yBAVtpRxhfAO8fMAcfTgo huVaM8QB4g1Wcf1uw0MBAI2wqlaLXR2utFSfBDFiViVjnwWPlzIjmXOs+HwWcK3D =fOcG -----END PGP SIGNATURE----- --XuMkqx5qJF5nCDO8gCwEnjNO64hsiQF8M--