From: Boaz Harrosh <boaz@plexistor.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>
Subject: [RFC 1/1] memremap: devm_memremap_pages has wrong nid
Date: Wed, 11 Nov 2015 23:16:51 +0200 [thread overview]
Message-ID: <5643B043.3010103@plexistor.com> (raw)
The pmem dev as received in devm_memremap_pages() does not have
its dev->numa_node properly initialized yet.
What I see is that all pmem devices will call arch_add_memory
with nid==0 regardless of the real nid the memory is actually
on. Needless to say that after that all the NUMA page and zone
members (at page->flags) come out wrong.
If I do the below code it will all work properly.
RFC because probably we want to fix dev->numa_node before the
call to devm_memremap_pages.
This is on top of v4.3. I will please need the final fix for Stable@
Thanks
Signed-off-by: Boaz Harrosh <boaz@plexistor.com>
---
kernel/memremap.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/memremap.c b/kernel/memremap.c
index 9d6b555..9409e23 100644
--- a/kernel/memremap.c
+++ b/kernel/memremap.c
@@ -183,9 +183,7 @@ void *devm_memremap_pages(struct device *dev, struct resource *res)
memcpy(&page_map->res, res, sizeof(*res));
- nid = dev_to_node(dev);
- if (nid < 0)
- nid = 0;
+ nid = memory_add_physaddr_to_nid(res->start);
error = arch_add_memory(nid, res->start, resource_size(res), true);
if (error) {
--
1.9.3
next reply other threads:[~2015-11-11 21:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-11 21:16 Boaz Harrosh [this message]
2015-11-11 21:46 ` [RFC 1/1] memremap: devm_memremap_pages has wrong nid Dan Williams
2015-11-11 22:05 ` Boaz Harrosh
2015-11-12 13:10 ` [PATCH] nvdimm: proper NID in e820_pmem_probe Boaz Harrosh
2015-11-12 13:58 ` Boaz Harrosh
2015-11-12 17:13 ` Dan Williams
2015-11-15 10:08 ` Boaz Harrosh
2015-11-13 16:00 ` [RFC 1/1] memremap: devm_memremap_pages has wrong nid Toshi Kani
2015-11-15 9:17 ` Boaz Harrosh
2015-11-16 17:19 ` Toshi Kani
2015-11-17 13:15 ` Boaz Harrosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5643B043.3010103@plexistor.com \
--to=boaz@plexistor.com \
--cc=dan.j.williams@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.