All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Borkmann <daniel@iogearbox.net>
To: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Cc: David Miller <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Tobias Klauser <tklauser@distanz.ch>,
	Network Development <netdev@vger.kernel.org>
Subject: Re: [PATCH net v2 3/3] packet: fix tpacket_snd max frame and vlan handling
Date: Wed, 11 Nov 2015 23:39:41 +0100	[thread overview]
Message-ID: <5643C3AD.3000803@iogearbox.net> (raw)
In-Reply-To: <CA+FuTSf9nY3PewO0=jDJ7ppv1RsriXg_S+w=owhXsAFKJYkZbg@mail.gmail.com>

On 11/11/2015 03:56 PM, Willem de Bruijn wrote:
> On Tue, Nov 10, 2015 at 6:51 PM, Daniel Borkmann <daniel@iogearbox.net> wrote:
...
>> Saw that, so we need the check as one more fix for 57f89bfa2140 ("network:
>> Allow af_packet to transmit +4 bytes for VLAN packets.") as well.
>>
>> I'll see to respin a v3 tomorrow.
>
> Thanks, Daniel.
>
> The three existing uses of eth_hdr were applied in 2.6.39, 3.12 and 3.15.
> We probably need a patch per occurrence to allow backporting to the
> relevant stable branches. I can create the fixes independent from your
> patch set, if you prefer.

Thanks, I've pushed the new set out for review with the 3rd patch simplified
quite a bit. I think we could let this linger a bit in -net first, and in
case backporting help would be needed, happy to jump in.

Best & thanks,
Daniel

      reply	other threads:[~2015-11-11 22:39 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-10 22:03 [PATCH net v2 0/3] packet fixes Daniel Borkmann
2015-11-10 22:03 ` [PATCH net v2 1/3] packet: do skb_probe_transport_header when we actually have data Daniel Borkmann
2015-11-11  5:07   ` Jason Wang
2015-11-10 22:03 ` [PATCH net v2 2/3] packet: always probe for transport header Daniel Borkmann
2015-11-11  5:08   ` Jason Wang
2015-11-10 22:03 ` [PATCH net v2 3/3] packet: fix tpacket_snd max frame and vlan handling Daniel Borkmann
2015-11-10 22:52   ` Willem de Bruijn
2015-11-10 23:12     ` Daniel Borkmann
2015-11-10 23:24       ` Willem de Bruijn
2015-11-10 23:51         ` Daniel Borkmann
2015-11-11 14:56           ` Willem de Bruijn
2015-11-11 22:39             ` Daniel Borkmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5643C3AD.3000803@iogearbox.net \
    --to=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=netdev@vger.kernel.org \
    --cc=tklauser@distanz.ch \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.