From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH v4 2/9] ARM: EXYNOS: Fix potential NULL pointer access in exynos_sys_powerdown_conf Date: Thu, 12 Nov 2015 13:03:11 +0900 Message-ID: <56440F7F.6090408@samsung.com> References: <1447155784-12667-1-git-send-email-pankaj.dubey@samsung.com> <1447155784-12667-3-git-send-email-pankaj.dubey@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout3.w1.samsung.com ([210.118.77.13]:29438 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752968AbbKLEDP (ORCPT ); Wed, 11 Nov 2015 23:03:15 -0500 In-reply-to: <1447155784-12667-3-git-send-email-pankaj.dubey@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Pankaj Dubey , linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: kgene.kim@samsung.com, thomas.ab@samsung.com, amitdanielk@gmail.com, olof@lixom.net, khilman@linaro.org, arnd@arndb.de On 10.11.2015 20:42, Pankaj Dubey wrote: > If no platform devices binded to the driver but driver itself loaded and > exynos_sys_powerdown_conf is called from > arch/arm/mach-exynos/{suspend.c, pm.c} it will result in NULL pointer access, > to prevent this added check on pmu_context for NULL. > > Signed-off-by: Pankaj Dubey > --- > arch/arm/mach-exynos/pmu.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Thu, 12 Nov 2015 13:03:11 +0900 Subject: [PATCH v4 2/9] ARM: EXYNOS: Fix potential NULL pointer access in exynos_sys_powerdown_conf In-Reply-To: <1447155784-12667-3-git-send-email-pankaj.dubey@samsung.com> References: <1447155784-12667-1-git-send-email-pankaj.dubey@samsung.com> <1447155784-12667-3-git-send-email-pankaj.dubey@samsung.com> Message-ID: <56440F7F.6090408@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 10.11.2015 20:42, Pankaj Dubey wrote: > If no platform devices binded to the driver but driver itself loaded and > exynos_sys_powerdown_conf is called from > arch/arm/mach-exynos/{suspend.c, pm.c} it will result in NULL pointer access, > to prevent this added check on pmu_context for NULL. > > Signed-off-by: Pankaj Dubey > --- > arch/arm/mach-exynos/pmu.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof