From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ? Date: Thu, 12 Nov 2015 14:27:29 +0800 Message-ID: <56443151.3020508@rock-chips.com> References: <20151110150102.GP963@e106497-lin.cambridge.arm.com> <20151110165615.GB27962@ulmo> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1460780256==" Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.138]) by gabe.freedesktop.org (Postfix) with ESMTPS id A5F2F6EBD9 for ; Wed, 11 Nov 2015 22:27:34 -0800 (PST) In-Reply-To: <20151110165615.GB27962@ulmo> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding , Liviu Dudau Cc: lkml , DRI devel List-Id: dri-devel@lists.freedesktop.org This is a multi-part message in MIME format. --===============1460780256== Content-Type: multipart/alternative; boundary="------------010604030408020301010904" This is a multi-part message in MIME format. --------------010604030408020301010904 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2015=E5=B9=B411=E6=9C=8811=E6=97=A5 00:56, Thierry Reding wrote: > On Tue, Nov 10, 2015 at 03:01:03PM +0000, Liviu Dudau wrote: >> Hello, >> >> When booting my Juno board with the HDLCD driver that I have converted= to >> atomic operations I'm getting the following warning: > Perhaps you can provide pointers to the source code, that might make it > easier for people to spot what's going wrong. > > Thierry > > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel Hi Thierry I encountered the same problem as Liviu. I'm coverting rockchip drm to atomic api, when booting with hdmi=20 connected, get under warning: [ 1.300156] WARNING: CPU: 0 PID: 26 at=20 drivers/gpu/drm/drm_atomic_helper.c:674=20 drm_atomic_helper_update_legacy_modeset_state+0x3c/0x1f8() [ 1.300161] Modules linked in: [ 1.300171] CPU: 0 PID: 26 Comm: kworker/0:1 Not tainted 4.3.0-rc5+ #1= 60 [ 1.300174] Hardware name: Rockchip (Device Tree) [ 1.300189] Workqueue: events output_poll_execute [ 1.300224] [] (unwind_backtrace) from []=20 (show_stack+0x10/0x14) [ 1.300241] [] (show_stack) from []=20 (dump_stack+0x6c/0x88) [ 1.300255] [] (dump_stack) from []=20 (warn_slowpath_common+0x80/0xa8) [ 1.300265] [] (warn_slowpath_common) from []=20 (warn_slowpath_null+0x18/0x1c) [ 1.300277] [] (warn_slowpath_null) from []=20 (drm_atomic_helper_update_legacy_modeset_state+0x3c/0x1f8) [ 1.300293] []=20 (drm_atomic_helper_update_legacy_modeset_state) from []=20 (drm_atomic_helper_commit_modeset_disables+0x208/0x364) [ 1.300305] [] (drm_atomic_helper_commit_modeset_disables)=20 from [] (drm_atomic_helper_commit+0xf8/0x140) [ 1.300320] [] (drm_atomic_helper_commit) from []=20 (drm_atomic_commit+0x50/0x60) [ 1.300333] [] (drm_atomic_commit) from []=20 (restore_fbdev_mode+0xf4/0x278) [ 1.300345] [] (restore_fbdev_mode) from []=20 (drm_fb_helper_restore_fbdev_mode_unlocked+0x30/0x68) [ 1.300357] [] (drm_fb_helper_restore_fbdev_mode_unlocked)=20 from [] (drm_fb_helper_set_par+0x3c/0x54) [ 1.300368] [] (drm_fb_helper_set_par) from []=20 (drm_fb_helper_hotplug_event+0xe4/0xfc) [ 1.300382] [] (drm_fb_helper_hotplug_event) from=20 [] (drm_kms_helper_hotplug_event+0x24/0x28) [ 1.300396] [] (drm_kms_helper_hotplug_event) from=20 [] (output_poll_execute+0x134/0x18c) [ 1.300413] [] (output_poll_execute) from []=20 (process_one_work+0x1e0/0x318) [ 1.300426] [] (process_one_work) from []=20 (worker_thread+0x378/0x4c4) [ 1.300438] [] (worker_thread) from []=20 (kthread+0xdc/0xf0) [ 1.300450] [] (kthread) from []=20 (ret_from_fork+0x14/0x3c) I can't found who can set encoder->crtc value before atomic_commit,=20 what's going wrong? --=20 =EF=BC=ADark Yao --------------010604030408020301010904 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable

On 2015=E5=B9=B411=E6=9C=8811=E6=97=A5= 00:56, Thierry Reding wrote:

On Tue, Nov 10, 2015 at 03:01:03PM +0000, Liviu Duda=
u wrote:

Hello,

When booting my Juno board with the HDLCD driver that I have converted to
atomic operations I'm getting the following warning:

Perhaps you can provide pointers to the source code, that might make it
easier for people to spot what's going wrong.

Thierry

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/=
dri-devel

Hi Thierry
=C2=A0=C2=A0=C2=A0 I encountered the same problem as Liviu.
=C2=A0=C2=A0=C2=A0 I'm coverting rockchip drm to atomic api, when boo= ting with hdmi connected, get under warning:

[=C2=A0=C2=A0=C2=A0 1.300156] WARNING: CPU: 0 PID: 26 at drivers/gpu/drm/drm_atomic_helper.c:674 drm_atomic_helper_update_legacy_modeset_state+0x3c/0x1f8()
[=C2=A0=C2=A0=C2=A0 1.300161] Modules linked in:
[=C2=A0=C2=A0=C2=A0 1.300171] CPU: 0 PID: 26 Comm: kworker/0:1 Not ta= inted 4.3.0-rc5+ #160
[=C2=A0=C2=A0=C2=A0 1.300174] Hardware name: Rockchip (Device Tree) [=C2=A0=C2=A0=C2=A0 1.300189] Workqueue: events output_poll_execute [=C2=A0=C2=A0=C2=A0 1.300224] [<c0015e54>] (unwind_backtrace) f= rom [<c00123cc>] (show_stack+0x10/0x14)
[=C2=A0=C2=A0=C2=A0 1.300241] [<c00123cc>] (show_stack) from [<c01a5980>] (dump_stack+0x6c/0x88)
[=C2=A0=C2=A0=C2=A0 1.300255] [<c01a5980>] (dump_stack) from [<c0024050>] (warn_slowpath_common+0x80/0xa8)
[=C2=A0=C2=A0=C2=A0 1.300265] [<c0024050>] (warn_slowpath_commo= n) from [<c0024090>] (warn_slowpath_null+0x18/0x1c)
[=C2=A0=C2=A0=C2=A0 1.300277] [<c0024090>] (warn_slowpath_null)= from [<c0221184>] (drm_atomic_helper_update_legacy_modeset_state+0x3c/0x1f8)
[=C2=A0=C2=A0=C2=A0 1.300293] [<c0221184>] (drm_atomic_helper_update_legacy_modeset_state) from [<c0221548>] (drm_atomic_helper_commit_modeset_disables+0x208/0x364)
[=C2=A0=C2=A0=C2=A0 1.300305] [<c0221548>] (drm_atomic_helper_commit_modeset_disables) from [<c0222248>] (drm_atomic_helper_commit+0xf8/0x140)
[=C2=A0=C2=A0=C2=A0 1.300320] [<c0222248>] (drm_atomic_helper_c= ommit) from [<c02404cc>] (drm_atomic_commit+0x50/0x60)
[=C2=A0=C2=A0=C2=A0 1.300333] [<c02404cc>] (drm_atomic_commit) = from [<c0223180>] (restore_fbdev_mode+0xf4/0x278)
[=C2=A0=C2=A0=C2=A0 1.300345] [<c0223180>] (restore_fbdev_mode)= from [<c0224164>] (drm_fb_helper_restore_fbdev_mode_unlocked+0x30/0x68)
[=C2=A0=C2=A0=C2=A0 1.300357] [<c0224164>] (drm_fb_helper_restore_fbdev_mode_unlocked) from [<c02241d8>] (drm_fb_helper_set_par+0x3c/0x54)
[=C2=A0=C2=A0=C2=A0 1.300368] [<c02241d8>] (drm_fb_helper_set_p= ar) from [<c022411c>] (drm_fb_helper_hotplug_event+0xe4/0xfc)
[=C2=A0=C2=A0=C2=A0 1.300382] [<c022411c>] (drm_fb_helper_hotpl= ug_event) from [<c021ade8>] (drm_kms_helper_hotplug_event+0x24/0x28)
[=C2=A0=C2=A0=C2=A0 1.300396] [<c021ade8>] (drm_kms_helper_hotp= lug_event) from [<c021af20>] (output_poll_execute+0x134/0x18c)
[=C2=A0=C2=A0=C2=A0 1.300413] [<c021af20>] (output_poll_execute= ) from [<c00377c0>] (process_one_work+0x1e0/0x318)
[=C2=A0=C2=A0=C2=A0 1.300426] [<c00377c0>] (process_one_work) f= rom [<c0037c70>] (worker_thread+0x378/0x4c4)
[=C2=A0=C2=A0=C2=A0 1.300438] [<c0037c70>] (worker_thread) from [<c003c69c>] (kthread+0xdc/0xf0)
[=C2=A0=C2=A0=C2=A0 1.300450] [<c003c69c>] (kthread) from [<= c000f5d8>] (ret_from_fork+0x14/0x3c)

I can't found who can set encoder->crtc value before atomic_commit, what's going wrong?

--=20
=EF=BC=ADark Yao

--------------010604030408020301010904-- --===============1460780256== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1460780256==--