From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mark yao <mark.yao@rock-chips.com>
Subject: Re: drm: Bogus WARN() in
 drm_atomic_helper_update_legacy_modeset_state() ?
Date: Thu, 12 Nov 2015 14:34:57 +0800
Message-ID: <56443311.2020902@rock-chips.com>
References: <20151110150102.GP963@e106497-lin.cambridge.arm.com>
 <20151110165615.GB27962@ulmo> <56443151.3020508@rock-chips.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1611079635=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.135])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 9369A6EBDC
 for <dri-devel@lists.freedesktop.org>; Wed, 11 Nov 2015 22:35:08 -0800 (PST)
In-Reply-To: <56443151.3020508@rock-chips.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Thierry Reding <thierry.reding@gmail.com>, Liviu Dudau <Liviu.Dudau@arm.com>
Cc: lkml <linux-kernel@vger.kernel.org>, DRI devel <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

This is a multi-part message in MIME format.
--===============1611079635==
Content-Type: multipart/alternative;
 boundary="------------060100060205060102000200"

This is a multi-part message in MIME format.
--------------060100060205060102000200
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

On 2015=E5=B9=B411=E6=9C=8812=E6=97=A5 14:27, Mark yao wrote:
> On 2015=E5=B9=B411=E6=9C=8811=E6=97=A5 00:56, Thierry Reding wrote:
>> On Tue, Nov 10, 2015 at 03:01:03PM +0000, Liviu Dudau wrote:
>>> Hello,
>>>
>>> When booting my Juno board with the HDLCD driver that I have converte=
d to
>>> atomic operations I'm getting the following warning:
>> Perhaps you can provide pointers to the source code, that might make i=
t
>> easier for people to spot what's going wrong.
>>
>> Thierry
>>
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
> Hi Thierry
>     I encountered the same problem as Liviu.
>     I'm coverting rockchip drm to atomic api, when booting with hdmi=20
> connected, get under warning:
>
> [    1.300156] WARNING: CPU: 0 PID: 26 at=20
> drivers/gpu/drm/drm_atomic_helper.c:674=20
> drm_atomic_helper_update_legacy_modeset_state+0x3c/0x1f8()
> [    1.300161] Modules linked in:
> [    1.300171] CPU: 0 PID: 26 Comm: kworker/0:1 Not tainted 4.3.0-rc5+=20
> #160
> [    1.300174] Hardware name: Rockchip (Device Tree)
> [    1.300189] Workqueue: events output_poll_execute
> [    1.300224] [<c0015e54>] (unwind_backtrace) from [<c00123cc>]=20
> (show_stack+0x10/0x14)
> [    1.300241] [<c00123cc>] (show_stack) from [<c01a5980>]=20
> (dump_stack+0x6c/0x88)
> [    1.300255] [<c01a5980>] (dump_stack) from [<c0024050>]=20
> (warn_slowpath_common+0x80/0xa8)
> [    1.300265] [<c0024050>] (warn_slowpath_common) from [<c0024090>]=20
> (warn_slowpath_null+0x18/0x1c)
> [    1.300277] [<c0024090>] (warn_slowpath_null) from [<c0221184>]=20
> (drm_atomic_helper_update_legacy_modeset_state+0x3c/0x1f8)
> [    1.300293] [<c0221184>]=20
> (drm_atomic_helper_update_legacy_modeset_state) from [<c0221548>]=20
> (drm_atomic_helper_commit_modeset_disables+0x208/0x364)
> [    1.300305] [<c0221548>]=20
> (drm_atomic_helper_commit_modeset_disables) from [<c0222248>]=20
> (drm_atomic_helper_commit+0xf8/0x140)
> [    1.300320] [<c0222248>] (drm_atomic_helper_commit) from=20
> [<c02404cc>] (drm_atomic_commit+0x50/0x60)
> [    1.300333] [<c02404cc>] (drm_atomic_commit) from [<c0223180>]=20
> (restore_fbdev_mode+0xf4/0x278)
> [    1.300345] [<c0223180>] (restore_fbdev_mode) from [<c0224164>]=20
> (drm_fb_helper_restore_fbdev_mode_unlocked+0x30/0x68)
> [    1.300357] [<c0224164>]=20
> (drm_fb_helper_restore_fbdev_mode_unlocked) from [<c02241d8>]=20
> (drm_fb_helper_set_par+0x3c/0x54)
> [    1.300368] [<c02241d8>] (drm_fb_helper_set_par) from [<c022411c>]=20
> (drm_fb_helper_hotplug_event+0xe4/0xfc)
> [    1.300382] [<c022411c>] (drm_fb_helper_hotplug_event) from=20
> [<c021ade8>] (drm_kms_helper_hotplug_event+0x24/0x28)
> [    1.300396] [<c021ade8>] (drm_kms_helper_hotplug_event) from=20
> [<c021af20>] (output_poll_execute+0x134/0x18c)
> [    1.300413] [<c021af20>] (output_poll_execute) from [<c00377c0>]=20
> (process_one_work+0x1e0/0x318)
> [    1.300426] [<c00377c0>] (process_one_work) from [<c0037c70>]=20
> (worker_thread+0x378/0x4c4)
> [    1.300438] [<c0037c70>] (worker_thread) from [<c003c69c>]=20
> (kthread+0xdc/0xf0)
> [    1.300450] [<c003c69c>] (kthread) from [<c000f5d8>]=20
> (ret_from_fork+0x14/0x3c)
>
> I can't found who can set encoder->crtc value before atomic_commit,=20
> what's going wrong?
>
> --=20
> =EF=BC=ADark Yao
Hi
    here is the message before warning happen (filtering by "dmesg |=20
grep drm"), Hope this helps:

[    1.245700] [drm:drm_minor_register]
[    1.245925] [drm:drm_minor_register] new minor registered 64
[    1.245934] [drm:drm_minor_register]
[    1.245942] [drm:drm_minor_register]
[    1.246099] [drm:drm_minor_register] new minor registered 0
[    1.272968] rockchip-drm display-subsystem: bound ff940000.vop (ops=20
vop_component_ops)
[    1.294790] rockchip-drm display-subsystem: bound ff930000.vop (ops=20
vop_component_ops)
[    1.295086] rockchip-drm display-subsystem: bound ff980000.hdmi (ops=20
dw_hdmi_rockchip_ops)
[    1.295218] [drm:drm_sysfs_connector_add] adding "HDMI-A-1" to sysfs
[    1.295222] [drm:drm_sysfs_hotplug_event] generating hotplug event
[    1.295268] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013)=
.
[    1.295270] [drm] No driver support for vblank timestamp query.
[    1.295290] [drm:drm_helper_probe_single_connector_modes_merge_bits]=20
[CONNECTOR:29:HDMI-A-1]
[    1.295304] [drm:drm_helper_probe_single_connector_modes_merge_bits]=20
[CONNECTOR:29:HDMI-A-1] status updated from 3 to 1
[    1.295470] [drm:drm_do_probe_ddc_edid] drm: skipping non-existent=20
adapter rk3x-i2c
[    1.295513] [drm:drm_mode_debug_printmodeline] Modeline 30:"640x480"=20
0 25175 640 656 752 800 480 490 492 525 0x40 0xa
[    1.295518] [drm:drm_mode_prune_invalid] Not using 640x480 mode: BAD
[    1.295531] [drm:drm_mode_debug_printmodeline] Modeline 33:"848x480"=20
0 33750 848 864 976 1088 480 486 494 517 0x40 0x5
[    1.295535] [drm:drm_mode_prune_invalid] Not using 848x480 mode: BAD
[    1.295543] [drm:drm_helper_probe_single_connector_modes_merge_bits]=20
[CONNECTOR:29:HDMI-A-1] probed modes :
[    1.295555] [drm:drm_mode_debug_printmodeline] Modeline 34:"1024x768"=20
60 65000 1024 1048 1184 1344 768 771 777 806 0x40 0xa
[    1.295564] [drm:drm_mode_debug_printmodeline] Modeline 32:"800x600"=20
60 40000 800 840 968 1056 600 601 605 628 0x40 0x5
[    1.295573] [drm:drm_mode_debug_printmodeline] Modeline 31:"800x600"=20
56 36000 800 824 896 1024 600 601 603 625 0x40 0x5
[    1.295581] [drm:drm_setup_crtcs]
[    1.295594] [drm:drm_enable_connectors] connector 29 enabled? yes
[    1.295601] [drm:drm_target_preferred] looking for cmdline mode on=20
connector 29
[    1.295606] [drm:drm_target_preferred] looking for preferred mode on=20
connector 29 0
[    1.295609] [drm:drm_target_preferred] found mode 1024x768
[    1.295614] [drm:drm_setup_crtcs] picking CRTCs for 4096x4096 config
[    1.295623] [drm:drm_setup_crtcs] desired mode 1024x768 set on crtc=20
20 (0,0)
[    1.299403] [drm:rockchip_drm_fbdev_create] FB [1024x768]-24=20
kvaddr=3Df0121000 offset=3D0 size=3D3145728
[    1.299512] [drm:drm_sysfs_hotplug_event] generating hotplug event
[    1.299540] [drm:drm_fb_helper_hotplug_event]
[    1.299546] [drm:drm_helper_probe_single_connector_modes_merge_bits]=20
[CONNECTOR:29:HDMI-A-1]
[    1.299712] [drm:drm_do_probe_ddc_edid] drm: skipping non-existent=20
adapter rk3x-i2c
[    1.299750] [drm:drm_mode_debug_printmodeline] Modeline 35:"640x480"=20
0 25175 640 656 752 800 480 490 492 525 0x40 0xa
[    1.299755] [drm:drm_mode_prune_invalid] Not using 640x480 mode: BAD
[    1.299764] [drm:drm_mode_debug_printmodeline] Modeline 38:"848x480"=20
0 33750 848 864 976 1088 480 486 494 517 0x40 0x5
[    1.299769] [drm:drm_mode_prune_invalid] Not using 848x480 mode: BAD
[    1.299776] [drm:drm_helper_probe_single_connector_modes_merge_bits]=20
[CONNECTOR:29:HDMI-A-1] probed modes :
[    1.299786] [drm:drm_mode_debug_printmodeline] Modeline 34:"1024x768"=20
60 65000 1024 1048 1184 1344 768 771 777 806 0x40 0xa
[    1.299795] [drm:drm_mode_debug_printmodeline] Modeline 32:"800x600"=20
60 40000 800 840 968 1056 600 601 605 628 0x40 0x5
[    1.299804] [drm:drm_mode_debug_printmodeline] Modeline 31:"800x600"=20
56 36000 800 824 896 1024 600 601 603 625 0x40 0x5
[    1.299811] [drm:drm_setup_crtcs]
[    1.299818] [drm:drm_enable_connectors] connector 29 enabled? yes
[    1.299822] [drm:drm_target_preferred] looking for cmdline mode on=20
connector 29
[    1.299827] [drm:drm_target_preferred] looking for preferred mode on=20
connector 29 0
[    1.299831] [drm:drm_target_preferred] found mode 1024x768
[    1.299836] [drm:drm_setup_crtcs] picking CRTCs for 4096x4096 config
[    1.299842] [drm:drm_setup_crtcs] desired mode 1024x768 set on crtc=20
20 (0,0)
[    1.299857] [drm:drm_atomic_state_init] Allocated atomic state ee38ebc=
0
[    1.299868] [drm:drm_atomic_get_plane_state] Added [PLANE:18]=20
ee38eac0 state to ee38ebc0
[    1.299875] [drm:drm_atomic_get_plane_state] Added [PLANE:19]=20
ee38ea80 state to ee38ebc0
[    1.299880] [drm:drm_atomic_set_crtc_for_plane] Link plane state=20
ee38ea80 to [NOCRTC]
[    1.299885] [drm:drm_atomic_set_fb_for_plane] Set [NOFB] for plane=20
state ee38ea80
[    1.299892] [drm:drm_atomic_get_plane_state] Added [PLANE:21]=20
ee38ea40 state to ee38ebc0
[    1.299897] [drm:drm_atomic_set_crtc_for_plane] Link plane state=20
ee38ea40 to [NOCRTC]
[    1.299901] [drm:drm_atomic_set_fb_for_plane] Set [NOFB] for plane=20
state ee38ea40
[    1.299907] [drm:drm_atomic_get_plane_state] Added [PLANE:22]=20
ee38ea00 state to ee38ebc0
[    1.299911] [drm:drm_atomic_set_crtc_for_plane] Link plane state=20
ee38ea00 to [NOCRTC]
[    1.299916] [drm:drm_atomic_set_fb_for_plane] Set [NOFB] for plane=20
state ee38ea00
[    1.299922] [drm:drm_atomic_get_plane_state] Added [PLANE:23]=20
ee38e9c0 state to ee38ebc0
[    1.299929] [drm:drm_atomic_get_plane_state] Added [PLANE:24]=20
ee38e980 state to ee38ebc0
[    1.299933] [drm:drm_atomic_set_crtc_for_plane] Link plane state=20
ee38e980 to [NOCRTC]
[    1.299937] [drm:drm_atomic_set_fb_for_plane] Set [NOFB] for plane=20
state ee38e980
[    1.299943] [drm:drm_atomic_get_plane_state] Added [PLANE:26]=20
ee38e940 state to ee38ebc0
[    1.299947] [drm:drm_atomic_set_crtc_for_plane] Link plane state=20
ee38e940 to [NOCRTC]
[    1.299951] [drm:drm_atomic_set_fb_for_plane] Set [NOFB] for plane=20
state ee38e940
[    1.299958] [drm:drm_atomic_get_plane_state] Added [PLANE:27]=20
ee38e900 state to ee38ebc0
[    1.299962] [drm:drm_atomic_set_crtc_for_plane] Link plane state=20
ee38e900 to [NOCRTC]
[    1.299966] [drm:drm_atomic_set_fb_for_plane] Set [NOFB] for plane=20
state ee38e900
[    1.299975] [drm:drm_atomic_get_crtc_state] Added [CRTC:20] ee340000=20
state to ee38ebc0
[    1.299985] [drm:drm_atomic_set_mode_for_crtc] Set [MODE:1024x768]=20
for CRTC state ee340000
[    1.299990] [drm:drm_atomic_set_crtc_for_plane] Link plane state=20
ee38eac0 to [CRTC:20]
[    1.299995] [drm:drm_framebuffer_reference] ee20f640: FB ID: 33 (1)
[    1.300000] [drm:drm_atomic_set_fb_for_plane] Set [FB:33] for plane=20
state ee38eac0
[    1.300008] [drm:drm_atomic_get_connector_state] Added [CONNECTOR:29]=20
ee38e8c0 state to ee38ebc0
[    1.300015] [drm:drm_atomic_add_affected_connectors] Adding all=20
current connectors for [CRTC:20] to ee38ebc0
[    1.300021] [drm:drm_atomic_set_crtc_for_connector] Link connector=20
state ee38e8c0 to [CRTC:20]
[    1.300033] [drm:drm_atomic_get_crtc_state] Added [CRTC:25] ee393e00=20
state to ee38ebc0
[    1.300038] [drm:drm_atomic_set_mode_for_crtc] Set [NOMODE] for CRTC=20
state ee393e00
[    1.300043] [drm:drm_atomic_set_crtc_for_plane] Link plane state=20
ee38e9c0 to [NOCRTC]
[    1.300047] [drm:drm_atomic_set_fb_for_plane] Set [NOFB] for plane=20
state ee38e9c0
[    1.300053] [drm:drm_atomic_add_affected_connectors] Adding all=20
current connectors for [CRTC:20] to ee38ebc0
[    1.300059] [drm:drm_atomic_add_affected_connectors] Adding all=20
current connectors for [CRTC:25] to ee38ebc0
[    1.300067] [drm:drm_atomic_connectors_for_crtc] State ee38ebc0 has 1=20
connectors for [CRTC:20]
[    1.300071] [drm:drm_atomic_check_only] checking ee38ebc0
[    1.300079] [drm:drm_atomic_helper_check_modeset] [CRTC:20] mode chang=
ed
[    1.300083] [drm:drm_atomic_helper_check_modeset] [CRTC:20] enable=20
changed
[    1.300088] [drm:update_connector_routing] Updating routing for=20
[CONNECTOR:29:HDMI-A-1]
[    1.300095] [drm:update_connector_routing] [CONNECTOR:29:HDMI-A-1]=20
using [ENCODER:28:TMDS-28] on [CRTC:20]
[    1.300100] [drm:drm_atomic_helper_check_modeset] [CRTC:20] active=20
changed
[    1.300105] [drm:drm_atomic_helper_check_modeset] [CRTC:20] needs all=20
connectors, enable: y, active: y
[    1.300111] [drm:drm_atomic_add_affected_connectors] Adding all=20
current connectors for [CRTC:20] to ee38ebc0
[    1.300117] [drm:drm_atomic_connectors_for_crtc] State ee38ebc0 has 1=20
connectors for [CRTC:20]
[    1.300130] [drm:drm_atomic_commit] commiting ee38ebc0
[    1.300156] WARNING: CPU: 0 PID: 26 at=20
drivers/gpu/drm/drm_atomic_helper.c:674=20
drm_atomic_helper_update_legacy_modeset_state+0x3c/0x1f8()

--=20
=EF=BC=ADark Yao


--------------060100060205060102000200
Content-Type: text/html; charset=utf-8
Content-Transfer-Encoding: quoted-printable

<html>
  <head>
    <meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Content-Ty=
pe">
  </head>
  <body bgcolor=3D"#FFFFFF" text=3D"#000000">
    <div class=3D"moz-cite-prefix">On 2015=E5=B9=B411=E6=9C=8812=E6=97=A5=
 14:27, Mark yao wrote:<br>
    </div>
    <blockquote cite=3D"mid:56443151.3020508@rock-chips.com" type=3D"cite=
">
      <meta content=3D"text/html; charset=3Dutf-8" http-equiv=3D"Content-=
Type">
      <div class=3D"moz-cite-prefix">On 2015=E5=B9=B411=E6=9C=8811=E6=97=A5=
 00:56, Thierry Reding
        wrote:<br>
      </div>
      <blockquote cite=3D"mid:20151110165615.GB27962@ulmo" type=3D"cite">
        <pre wrap=3D"">On Tue, Nov 10, 2015 at 03:01:03PM +0000, Liviu Du=
dau wrote:
</pre>
        <blockquote type=3D"cite">
          <pre wrap=3D"">Hello,

When booting my Juno board with the HDLCD driver that I have converted to
atomic operations I'm getting the following warning:
</pre>
        </blockquote>
        <pre wrap=3D"">Perhaps you can provide pointers to the source cod=
e, that might make it
easier for people to spot what's going wrong.

Thierry
</pre>
        <br>
        <fieldset class=3D"mimeAttachmentHeader"></fieldset>
        <br>
        <pre wrap=3D"">_______________________________________________
dri-devel mailing list
<a moz-do-not-send=3D"true" class=3D"moz-txt-link-abbreviated" href=3D"ma=
ilto:dri-devel@lists.freedesktop.org">dri-devel@lists.freedesktop.org</a>
<a moz-do-not-send=3D"true" class=3D"moz-txt-link-freetext" href=3D"http:=
//lists.freedesktop.org/mailman/listinfo/dri-devel">http://lists.freedesk=
top.org/mailman/listinfo/dri-devel</a>
</pre>
      </blockquote>
      Hi Thierry<br>
      =C2=A0=C2=A0=C2=A0 I encountered the same problem as Liviu.<br>
      =C2=A0=C2=A0=C2=A0 I'm coverting rockchip drm to atomic api, when b=
ooting with
      hdmi connected, get under warning:<br>
      <br>
      [=C2=A0=C2=A0=C2=A0 1.300156] WARNING: CPU: 0 PID: 26 at
      drivers/gpu/drm/drm_atomic_helper.c:674
      drm_atomic_helper_update_legacy_modeset_state+0x3c/0x1f8()<br>
      [=C2=A0=C2=A0=C2=A0 1.300161] Modules linked in:<br>
      [=C2=A0=C2=A0=C2=A0 1.300171] CPU: 0 PID: 26 Comm: kworker/0:1 Not =
tainted
      4.3.0-rc5+ #160<br>
      [=C2=A0=C2=A0=C2=A0 1.300174] Hardware name: Rockchip (Device Tree)=
<br>
      [=C2=A0=C2=A0=C2=A0 1.300189] Workqueue: events output_poll_execute=
<br>
      [=C2=A0=C2=A0=C2=A0 1.300224] [&lt;c0015e54&gt;] (unwind_backtrace)=
 from
      [&lt;c00123cc&gt;] (show_stack+0x10/0x14)<br>
      [=C2=A0=C2=A0=C2=A0 1.300241] [&lt;c00123cc&gt;] (show_stack) from
      [&lt;c01a5980&gt;] (dump_stack+0x6c/0x88)<br>
      [=C2=A0=C2=A0=C2=A0 1.300255] [&lt;c01a5980&gt;] (dump_stack) from
      [&lt;c0024050&gt;] (warn_slowpath_common+0x80/0xa8)<br>
      [=C2=A0=C2=A0=C2=A0 1.300265] [&lt;c0024050&gt;] (warn_slowpath_com=
mon) from
      [&lt;c0024090&gt;] (warn_slowpath_null+0x18/0x1c)<br>
      [=C2=A0=C2=A0=C2=A0 1.300277] [&lt;c0024090&gt;] (warn_slowpath_nul=
l) from
      [&lt;c0221184&gt;]
      (drm_atomic_helper_update_legacy_modeset_state+0x3c/0x1f8)<br>
      [=C2=A0=C2=A0=C2=A0 1.300293] [&lt;c0221184&gt;]
      (drm_atomic_helper_update_legacy_modeset_state) from
      [&lt;c0221548&gt;]
      (drm_atomic_helper_commit_modeset_disables+0x208/0x364)<br>
      [=C2=A0=C2=A0=C2=A0 1.300305] [&lt;c0221548&gt;]
      (drm_atomic_helper_commit_modeset_disables) from
      [&lt;c0222248&gt;] (drm_atomic_helper_commit+0xf8/0x140)<br>
      [=C2=A0=C2=A0=C2=A0 1.300320] [&lt;c0222248&gt;] (drm_atomic_helper=
_commit) from
      [&lt;c02404cc&gt;] (drm_atomic_commit+0x50/0x60)<br>
      [=C2=A0=C2=A0=C2=A0 1.300333] [&lt;c02404cc&gt;] (drm_atomic_commit=
) from
      [&lt;c0223180&gt;] (restore_fbdev_mode+0xf4/0x278)<br>
      [=C2=A0=C2=A0=C2=A0 1.300345] [&lt;c0223180&gt;] (restore_fbdev_mod=
e) from
      [&lt;c0224164&gt;]
      (drm_fb_helper_restore_fbdev_mode_unlocked+0x30/0x68)<br>
      [=C2=A0=C2=A0=C2=A0 1.300357] [&lt;c0224164&gt;]
      (drm_fb_helper_restore_fbdev_mode_unlocked) from
      [&lt;c02241d8&gt;] (drm_fb_helper_set_par+0x3c/0x54)<br>
      [=C2=A0=C2=A0=C2=A0 1.300368] [&lt;c02241d8&gt;] (drm_fb_helper_set=
_par) from
      [&lt;c022411c&gt;] (drm_fb_helper_hotplug_event+0xe4/0xfc)<br>
      [=C2=A0=C2=A0=C2=A0 1.300382] [&lt;c022411c&gt;] (drm_fb_helper_hot=
plug_event)
      from [&lt;c021ade8&gt;] (drm_kms_helper_hotplug_event+0x24/0x28)<br=
>
      [=C2=A0=C2=A0=C2=A0 1.300396] [&lt;c021ade8&gt;] (drm_kms_helper_ho=
tplug_event)
      from [&lt;c021af20&gt;] (output_poll_execute+0x134/0x18c)<br>
      [=C2=A0=C2=A0=C2=A0 1.300413] [&lt;c021af20&gt;] (output_poll_execu=
te) from
      [&lt;c00377c0&gt;] (process_one_work+0x1e0/0x318)<br>
      [=C2=A0=C2=A0=C2=A0 1.300426] [&lt;c00377c0&gt;] (process_one_work)=
 from
      [&lt;c0037c70&gt;] (worker_thread+0x378/0x4c4)<br>
      [=C2=A0=C2=A0=C2=A0 1.300438] [&lt;c0037c70&gt;] (worker_thread) fr=
om
      [&lt;c003c69c&gt;] (kthread+0xdc/0xf0)<br>
      [=C2=A0=C2=A0=C2=A0 1.300450] [&lt;c003c69c&gt;] (kthread) from
      [&lt;c000f5d8&gt;] (ret_from_fork+0x14/0x3c)<br>
      <br>
      I can't found who can set encoder-&gt;crtc value before
      atomic_commit, what's going wrong?<br>
      <br>
      <pre class=3D"moz-signature" cols=3D"72">--=20
=EF=BC=ADark Yao</pre>
    </blockquote>
    Hi<br>
    =C2=A0=C2=A0 here is the message before warning happen (filtering by =
"dmesg |
    grep drm"),=C2=A0
    <meta http-equiv=3D"content-type" content=3D"text/html; charset=3Dutf=
-8">
    Hope this helps:<br>
    <br>
    [=C2=A0=C2=A0=C2=A0 1.245700] [drm:drm_minor_register] <br>
    [=C2=A0=C2=A0=C2=A0 1.245925] [drm:drm_minor_register] new minor regi=
stered 64<br>
    [=C2=A0=C2=A0=C2=A0 1.245934] [drm:drm_minor_register] <br>
    [=C2=A0=C2=A0=C2=A0 1.245942] [drm:drm_minor_register] <br>
    [=C2=A0=C2=A0=C2=A0 1.246099] [drm:drm_minor_register] new minor regi=
stered 0<br>
    [=C2=A0=C2=A0=C2=A0 1.272968] rockchip-drm display-subsystem: bound f=
f940000.vop
    (ops vop_component_ops)<br>
    [=C2=A0=C2=A0=C2=A0 1.294790] rockchip-drm display-subsystem: bound f=
f930000.vop
    (ops vop_component_ops)<br>
    [=C2=A0=C2=A0=C2=A0 1.295086] rockchip-drm display-subsystem: bound f=
f980000.hdmi
    (ops dw_hdmi_rockchip_ops)<br>
    [=C2=A0=C2=A0=C2=A0 1.295218] [drm:drm_sysfs_connector_add] adding "H=
DMI-A-1" to
    sysfs<br>
    [=C2=A0=C2=A0=C2=A0 1.295222] [drm:drm_sysfs_hotplug_event] generatin=
g hotplug
    event<br>
    [=C2=A0=C2=A0=C2=A0 1.295268] [drm] Supports vblank timestamp caching=
 Rev 2
    (21.10.2013).<br>
    [=C2=A0=C2=A0=C2=A0 1.295270] [drm] No driver support for vblank time=
stamp query.<br>
    [=C2=A0=C2=A0=C2=A0 1.295290]
    [drm:drm_helper_probe_single_connector_modes_merge_bits]
    [CONNECTOR:29:HDMI-A-1]<br>
    [=C2=A0=C2=A0=C2=A0 1.295304]
    [drm:drm_helper_probe_single_connector_modes_merge_bits]
    [CONNECTOR:29:HDMI-A-1] status updated from 3 to 1<br>
    [=C2=A0=C2=A0=C2=A0 1.295470] [drm:drm_do_probe_ddc_edid] drm: skippi=
ng
    non-existent adapter rk3x-i2c<br>
    [=C2=A0=C2=A0=C2=A0 1.295513] [drm:drm_mode_debug_printmodeline] Mode=
line
    30:"640x480" 0 25175 640 656 752 800 480 490 492 525 0x40 0xa<br>
    [=C2=A0=C2=A0=C2=A0 1.295518] [drm:drm_mode_prune_invalid] Not using =
640x480 mode:
    BAD<br>
    [=C2=A0=C2=A0=C2=A0 1.295531] [drm:drm_mode_debug_printmodeline] Mode=
line
    33:"848x480" 0 33750 848 864 976 1088 480 486 494 517 0x40 0x5<br>
    [=C2=A0=C2=A0=C2=A0 1.295535] [drm:drm_mode_prune_invalid] Not using =
848x480 mode:
    BAD<br>
    [=C2=A0=C2=A0=C2=A0 1.295543]
    [drm:drm_helper_probe_single_connector_modes_merge_bits]
    [CONNECTOR:29:HDMI-A-1] probed modes :<br>
    [=C2=A0=C2=A0=C2=A0 1.295555] [drm:drm_mode_debug_printmodeline] Mode=
line
    34:"1024x768" 60 65000 1024 1048 1184 1344 768 771 777 806 0x40 0xa<b=
r>
    [=C2=A0=C2=A0=C2=A0 1.295564] [drm:drm_mode_debug_printmodeline] Mode=
line
    32:"800x600" 60 40000 800 840 968 1056 600 601 605 628 0x40 0x5<br>
    [=C2=A0=C2=A0=C2=A0 1.295573] [drm:drm_mode_debug_printmodeline] Mode=
line
    31:"800x600" 56 36000 800 824 896 1024 600 601 603 625 0x40 0x5<br>
    [=C2=A0=C2=A0=C2=A0 1.295581] [drm:drm_setup_crtcs] <br>
    [=C2=A0=C2=A0=C2=A0 1.295594] [drm:drm_enable_connectors] connector 2=
9 enabled? yes<br>
    [=C2=A0=C2=A0=C2=A0 1.295601] [drm:drm_target_preferred] looking for =
cmdline mode
    on connector 29<br>
    [=C2=A0=C2=A0=C2=A0 1.295606] [drm:drm_target_preferred] looking for =
preferred mode
    on connector 29 0<br>
    [=C2=A0=C2=A0=C2=A0 1.295609] [drm:drm_target_preferred] found mode 1=
024x768<br>
    [=C2=A0=C2=A0=C2=A0 1.295614] [drm:drm_setup_crtcs] picking CRTCs for=
 4096x4096
    config<br>
    [=C2=A0=C2=A0=C2=A0 1.295623] [drm:drm_setup_crtcs] desired mode 1024=
x768 set on
    crtc 20 (0,0)<br>
    [=C2=A0=C2=A0=C2=A0 1.299403] [drm:rockchip_drm_fbdev_create] FB [102=
4x768]-24
    kvaddr=3Df0121000 offset=3D0 size=3D3145728<br>
    [=C2=A0=C2=A0=C2=A0 1.299512] [drm:drm_sysfs_hotplug_event] generatin=
g hotplug
    event<br>
    [=C2=A0=C2=A0=C2=A0 1.299540] [drm:drm_fb_helper_hotplug_event] <br>
    [=C2=A0=C2=A0=C2=A0 1.299546]
    [drm:drm_helper_probe_single_connector_modes_merge_bits]
    [CONNECTOR:29:HDMI-A-1]<br>
    [=C2=A0=C2=A0=C2=A0 1.299712] [drm:drm_do_probe_ddc_edid] drm: skippi=
ng
    non-existent adapter rk3x-i2c<br>
    [=C2=A0=C2=A0=C2=A0 1.299750] [drm:drm_mode_debug_printmodeline] Mode=
line
    35:"640x480" 0 25175 640 656 752 800 480 490 492 525 0x40 0xa<br>
    [=C2=A0=C2=A0=C2=A0 1.299755] [drm:drm_mode_prune_invalid] Not using =
640x480 mode:
    BAD<br>
    [=C2=A0=C2=A0=C2=A0 1.299764] [drm:drm_mode_debug_printmodeline] Mode=
line
    38:"848x480" 0 33750 848 864 976 1088 480 486 494 517 0x40 0x5<br>
    [=C2=A0=C2=A0=C2=A0 1.299769] [drm:drm_mode_prune_invalid] Not using =
848x480 mode:
    BAD<br>
    [=C2=A0=C2=A0=C2=A0 1.299776]
    [drm:drm_helper_probe_single_connector_modes_merge_bits]
    [CONNECTOR:29:HDMI-A-1] probed modes :<br>
    [=C2=A0=C2=A0=C2=A0 1.299786] [drm:drm_mode_debug_printmodeline] Mode=
line
    34:"1024x768" 60 65000 1024 1048 1184 1344 768 771 777 806 0x40 0xa<b=
r>
    [=C2=A0=C2=A0=C2=A0 1.299795] [drm:drm_mode_debug_printmodeline] Mode=
line
    32:"800x600" 60 40000 800 840 968 1056 600 601 605 628 0x40 0x5<br>
    [=C2=A0=C2=A0=C2=A0 1.299804] [drm:drm_mode_debug_printmodeline] Mode=
line
    31:"800x600" 56 36000 800 824 896 1024 600 601 603 625 0x40 0x5<br>
    [=C2=A0=C2=A0=C2=A0 1.299811] [drm:drm_setup_crtcs] <br>
    [=C2=A0=C2=A0=C2=A0 1.299818] [drm:drm_enable_connectors] connector 2=
9 enabled? yes<br>
    [=C2=A0=C2=A0=C2=A0 1.299822] [drm:drm_target_preferred] looking for =
cmdline mode
    on connector 29<br>
    [=C2=A0=C2=A0=C2=A0 1.299827] [drm:drm_target_preferred] looking for =
preferred mode
    on connector 29 0<br>
    [=C2=A0=C2=A0=C2=A0 1.299831] [drm:drm_target_preferred] found mode 1=
024x768<br>
    [=C2=A0=C2=A0=C2=A0 1.299836] [drm:drm_setup_crtcs] picking CRTCs for=
 4096x4096
    config<br>
    [=C2=A0=C2=A0=C2=A0 1.299842] [drm:drm_setup_crtcs] desired mode 1024=
x768 set on
    crtc 20 (0,0)<br>
    [=C2=A0=C2=A0=C2=A0 1.299857] [drm:drm_atomic_state_init] Allocated a=
tomic state
    ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.299868] [drm:drm_atomic_get_plane_state] Added =
[PLANE:18]
    ee38eac0 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.299875] [drm:drm_atomic_get_plane_state] Added =
[PLANE:19]
    ee38ea80 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.299880] [drm:drm_atomic_set_crtc_for_plane] Lin=
k plane state
    ee38ea80 to [NOCRTC]<br>
    [=C2=A0=C2=A0=C2=A0 1.299885] [drm:drm_atomic_set_fb_for_plane] Set [=
NOFB] for
    plane state ee38ea80<br>
    [=C2=A0=C2=A0=C2=A0 1.299892] [drm:drm_atomic_get_plane_state] Added =
[PLANE:21]
    ee38ea40 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.299897] [drm:drm_atomic_set_crtc_for_plane] Lin=
k plane state
    ee38ea40 to [NOCRTC]<br>
    [=C2=A0=C2=A0=C2=A0 1.299901] [drm:drm_atomic_set_fb_for_plane] Set [=
NOFB] for
    plane state ee38ea40<br>
    [=C2=A0=C2=A0=C2=A0 1.299907] [drm:drm_atomic_get_plane_state] Added =
[PLANE:22]
    ee38ea00 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.299911] [drm:drm_atomic_set_crtc_for_plane] Lin=
k plane state
    ee38ea00 to [NOCRTC]<br>
    [=C2=A0=C2=A0=C2=A0 1.299916] [drm:drm_atomic_set_fb_for_plane] Set [=
NOFB] for
    plane state ee38ea00<br>
    [=C2=A0=C2=A0=C2=A0 1.299922] [drm:drm_atomic_get_plane_state] Added =
[PLANE:23]
    ee38e9c0 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.299929] [drm:drm_atomic_get_plane_state] Added =
[PLANE:24]
    ee38e980 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.299933] [drm:drm_atomic_set_crtc_for_plane] Lin=
k plane state
    ee38e980 to [NOCRTC]<br>
    [=C2=A0=C2=A0=C2=A0 1.299937] [drm:drm_atomic_set_fb_for_plane] Set [=
NOFB] for
    plane state ee38e980<br>
    [=C2=A0=C2=A0=C2=A0 1.299943] [drm:drm_atomic_get_plane_state] Added =
[PLANE:26]
    ee38e940 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.299947] [drm:drm_atomic_set_crtc_for_plane] Lin=
k plane state
    ee38e940 to [NOCRTC]<br>
    [=C2=A0=C2=A0=C2=A0 1.299951] [drm:drm_atomic_set_fb_for_plane] Set [=
NOFB] for
    plane state ee38e940<br>
    [=C2=A0=C2=A0=C2=A0 1.299958] [drm:drm_atomic_get_plane_state] Added =
[PLANE:27]
    ee38e900 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.299962] [drm:drm_atomic_set_crtc_for_plane] Lin=
k plane state
    ee38e900 to [NOCRTC]<br>
    [=C2=A0=C2=A0=C2=A0 1.299966] [drm:drm_atomic_set_fb_for_plane] Set [=
NOFB] for
    plane state ee38e900<br>
    [=C2=A0=C2=A0=C2=A0 1.299975] [drm:drm_atomic_get_crtc_state] Added [=
CRTC:20]
    ee340000 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.299985] [drm:drm_atomic_set_mode_for_crtc] Set
    [MODE:1024x768] for CRTC state ee340000<br>
    [=C2=A0=C2=A0=C2=A0 1.299990] [drm:drm_atomic_set_crtc_for_plane] Lin=
k plane state
    ee38eac0 to [CRTC:20]<br>
    [=C2=A0=C2=A0=C2=A0 1.299995] [drm:drm_framebuffer_reference] ee20f64=
0: FB ID: 33
    (1)<br>
    [=C2=A0=C2=A0=C2=A0 1.300000] [drm:drm_atomic_set_fb_for_plane] Set [=
FB:33] for
    plane state ee38eac0<br>
    [=C2=A0=C2=A0=C2=A0 1.300008] [drm:drm_atomic_get_connector_state] Ad=
ded
    [CONNECTOR:29] ee38e8c0 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.300015] [drm:drm_atomic_add_affected_connectors=
] Adding all
    current connectors for [CRTC:20] to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.300021] [drm:drm_atomic_set_crtc_for_connector]=
 Link
    connector state ee38e8c0 to [CRTC:20]<br>
    [=C2=A0=C2=A0=C2=A0 1.300033] [drm:drm_atomic_get_crtc_state] Added [=
CRTC:25]
    ee393e00 state to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.300038] [drm:drm_atomic_set_mode_for_crtc] Set =
[NOMODE] for
    CRTC state ee393e00<br>
    [=C2=A0=C2=A0=C2=A0 1.300043] [drm:drm_atomic_set_crtc_for_plane] Lin=
k plane state
    ee38e9c0 to [NOCRTC]<br>
    [=C2=A0=C2=A0=C2=A0 1.300047] [drm:drm_atomic_set_fb_for_plane] Set [=
NOFB] for
    plane state ee38e9c0<br>
    [=C2=A0=C2=A0=C2=A0 1.300053] [drm:drm_atomic_add_affected_connectors=
] Adding all
    current connectors for [CRTC:20] to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.300059] [drm:drm_atomic_add_affected_connectors=
] Adding all
    current connectors for [CRTC:25] to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.300067] [drm:drm_atomic_connectors_for_crtc] St=
ate ee38ebc0
    has 1 connectors for [CRTC:20]<br>
    [=C2=A0=C2=A0=C2=A0 1.300071] [drm:drm_atomic_check_only] checking ee=
38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.300079] [drm:drm_atomic_helper_check_modeset] [=
CRTC:20] mode
    changed<br>
    [=C2=A0=C2=A0=C2=A0 1.300083] [drm:drm_atomic_helper_check_modeset] [=
CRTC:20]
    enable changed<br>
    [=C2=A0=C2=A0=C2=A0 1.300088] [drm:update_connector_routing] Updating=
 routing for
    [CONNECTOR:29:HDMI-A-1]<br>
    [=C2=A0=C2=A0=C2=A0 1.300095] [drm:update_connector_routing]
    [CONNECTOR:29:HDMI-A-1] using [ENCODER:28:TMDS-28] on [CRTC:20]<br>
    [=C2=A0=C2=A0=C2=A0 1.300100] [drm:drm_atomic_helper_check_modeset] [=
CRTC:20]
    active changed<br>
    [=C2=A0=C2=A0=C2=A0 1.300105] [drm:drm_atomic_helper_check_modeset] [=
CRTC:20] needs
    all connectors, enable: y, active: y<br>
    [=C2=A0=C2=A0=C2=A0 1.300111] [drm:drm_atomic_add_affected_connectors=
] Adding all
    current connectors for [CRTC:20] to ee38ebc0<br>
    [=C2=A0=C2=A0=C2=A0 1.300117] [drm:drm_atomic_connectors_for_crtc] St=
ate ee38ebc0
    has 1 connectors for [CRTC:20]<br>
    [=C2=A0=C2=A0=C2=A0 1.300130] [drm:drm_atomic_commit] commiting ee38e=
bc0<br>
    [=C2=A0=C2=A0=C2=A0 1.300156] WARNING: CPU: 0 PID: 26 at
    drivers/gpu/drm/drm_atomic_helper.c:674
    drm_atomic_helper_update_legacy_modeset_state+0x3c/0x1f8()<br>
    <br>
    <pre class=3D"moz-signature" cols=3D"72">--=20
=EF=BC=ADark Yao</pre>
  </body>
</html>

--------------060100060205060102000200--


--===============1611079635==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK

--===============1611079635==--