Re: [PATCH] tools/libxc: Fix construction of HVM guests with non-default firmware

["Roger Pau Monné" <roger.pau@citrix.com>]

El 11/11/15 a les 21.18, Andrew Cooper ha escrit:
> c/s 1ee15d7 "libxl: switch HVM domain building to use xc_dom_* helpers"
> introduced a regression building HVM domains in combination with the libxl
> "firmware_override=" option.
> 
> The older HVM building code (now removed) had no 32bit ELF check, so would
> happily load ELF64 images which contained a stub to switch into long mode.
> 
> It is convenient for the ELF file to match the intended runmode rather
> than the starting runmode.  As such, don't make an arbitrary restriction.
> 
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>

Sorry for the breakage, I actually added that check to make the domain
building more sane, but didn't know there where such use cases, so:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

TBH, I though that ELF64 binaries that have a 32bit entry point would
always specify their type as ELF32 (IIRC that's what Xen itself does).

Roger.


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel