From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark yao Subject: Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ? Date: Thu, 12 Nov 2015 18:49:38 +0800 Message-ID: <56446EC2.6020301@rock-chips.com> References: <20151110150102.GP963@e106497-lin.cambridge.arm.com> <56444EA1.3050506@rock-chips.com> <20151112103618.GY963@e106497-lin.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from regular1.263xmail.com (regular1.263xmail.com [211.150.99.132]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5E53B6EC65 for ; Thu, 12 Nov 2015 02:49:43 -0800 (PST) In-Reply-To: <20151112103618.GY963@e106497-lin.cambridge.arm.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Liviu Dudau Cc: DRI devel , lkml List-Id: dri-devel@lists.freedesktop.org T24gMjAxNeW5tDEx5pyIMTLml6UgMTg6MzYsIExpdml1IER1ZGF1IHdyb3RlOgo+IE9uIFRodSwg Tm92IDEyLCAyMDE1IGF0IDA0OjMyOjMzUE0gKzA4MDAsIE1hcmsgeWFvIHdyb3RlOgo+PiAgICAg T24gMjAxNeW5tDEx5pyIMTDml6UgMjM6MDEsIExpdml1IER1ZGF1IHdyb3RlOgo+Pgo+PiAgIEhl bGxvLAo+Pgo+PiAgIFdoZW4gYm9vdGluZyBteSBKdW5vIGJvYXJkIHdpdGggdGhlIEhETENEIGRy aXZlciB0aGF0IEkgaGF2ZSBjb252ZXJ0ZWQgdG8KPj4gICBhdG9taWMgb3BlcmF0aW9ucyBJJ20g Z2V0dGluZyB0aGUgZm9sbG93aW5nIHdhcm5pbmc6Cj4+Cj4+ICAgLS0tLS0tLS0tLS0tWyBjdXQg aGVyZSBdLS0tLS0tLS0tLS0tCj4+ICAgV0FSTklORzogYXQgL3dvcmsvcmVwb3NpdG9yaWVzL2tl cm5lbC9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYzo2NzQKPj4gICBNb2R1bGVz IGxpbmtlZCBpbjogaGRsY2QoKykgY2xrX3NjcGkKPj4KPj4gICBDUFU6IDMgUElEOiAxMzc1IENv bW06IHN5c3RlbWQtdWRldmQgTm90IHRhaW50ZWQgNC4zLjAtbmV4dC0yMDE1MTEwOSsgIzUKPj4g ICBIYXJkd2FyZSBuYW1lOiBBUk0gSnVubyBkZXZlbG9wbWVudCBib2FyZCAocjApIChEVCkKPj4g ICB0YXNrOiBmZmZmZmZjOTc0ODg4YjAwIHRpOiBmZmZmZmZjOTc1NWRjMDAwIHRhc2sudGk6IGZm ZmZmZmM5NzU1ZGMwMDAKPj4gICBQQyBpcyBhdCBkcm1fYXRvbWljX2hlbHBlcl91cGRhdGVfbGVn YWN5X21vZGVzZXRfc3RhdGUrMHgyMDQvMHgyMGMKPj4gICBMUiBpcyBhdCBkcm1fYXRvbWljX2hl bHBlcl9jb21taXRfbW9kZXNldF9kaXNhYmxlcysweDFjMC8weDM5NAo+PiAgIHBjIDogWzxmZmZm ZmZjMDAwM2U2ZDE4Pl0gbHIgOiBbPGZmZmZmZmMwMDAzZTgyMTQ+XSBwc3RhdGU6IDIwMDAwMTQ1 Cj4+ICAgc3AgOiBmZmZmZmZjOTc1NWRmNDMwCj4+ICAgeDI5OiBmZmZmZmZjOTc1NWRmNDMwIHgy ODogZmZmZmZmYzk3NTcwMzYwMAo+PiAgIHgyNzogMDAwMDAwMDAwMDAwMDAwMCB4MjY6IGZmZmZm ZmM5NzYyNTM5NjAKPj4gICB4MjU6IGZmZmZmZmM5NzYyNTQwNDAgeDI0OiBmZmZmZmZjMDAwODE5 MDAwCj4+ICAgeDIzOiBmZmZmZmZjMDAwNjg5ZWEwIHgyMjogZmZmZmZmYzk3NjI1MTgwMAo+PiAg IHgyMTogZmZmZmZmYzk3NjI1MTgwMCB4MjA6IDAwMDAwMDAwMDAwMDAwMDAKPj4gICB4MTk6IGZm ZmZmZmM5NzY2YjFmODAgeDE4OiAwMDAwMDAwMDcxNWZlMDE1Cj4+ICAgeDE3OiAwMDAwMDA3ZmI0 Yjg1NWIwIHgxNjogMDAwMDAwMDAwMDAwMDIyMAo+PiAgIHgxNTogMDAwMDAwMDAwMDAwMDAwMSB4 MTQ6IDBmZmZmZmZmZmZmZmZmZmUKPj4gICB4MTM6IDAwMDAwMDAwMDAwMDAwMDggeDEyOiAwMTAx MDEwMTAxMDEwMTAxCj4+ICAgeDExOiBmZmZmZmZjMDAwOTY0MDAwIHgxMDogZmZmZmZmYzAwMDlk MjAwMAo+PiAgIHg5IDogMDAwMDAwMDAwMDAwMDAwMCB4OCA6IGZmZmZmZmM5N2ZmNWY3MDAKPj4g ICB4NyA6IGZmZmZmZmM5NzU2NmNiODAgeDYgOiBmZmZmZmZjOTc2NmIxNzAwCj4+ICAgeDUgOiBm ZmZmZmZjOTc1NjY1MTAwIHg0IDogMDAwMDAwMDAwMDAwMDAwMAo+PiAgIHgzIDogZmZmZmZmYzk3 NjI1Mzk2MCB4MiA6IGZmZmZmZmM5NzU2NmNkMDAKPj4gICB4MSA6IGZmZmZmZmM5NzYyNTM5MDAg eDAgOiAwMDAwMDAwMDAwMDAwMDAwCj4+Cj4+ICAgLS0tWyBlbmQgdHJhY2UgOWZlMjg5Zjc5OGU3 MTc4ZSBdLS0tCj4+ICAgQ2FsbCB0cmFjZToKPj4gICBbPGZmZmZmZmMwMDAzZTZkMTg+XSBkcm1f YXRvbWljX2hlbHBlcl91cGRhdGVfbGVnYWN5X21vZGVzZXRfc3RhdGUrMHgyMDQvMHgyMGMKPj4g ICBbPGZmZmZmZmMwMDAzZTgyMTQ+XSBkcm1fYXRvbWljX2hlbHBlcl9jb21taXRfbW9kZXNldF9k aXNhYmxlcysweDFjMC8weDM5NAo+PiAgIFs8ZmZmZmZmYzAwMDNlODRjOD5dIGRybV9hdG9taWNf aGVscGVyX2NvbW1pdCsweGUwLzB4MTUwCj4+ICAgWzxmZmZmZmZjMDAwNDBiY2MwPl0gZHJtX2F0 b21pY19jb21taXQrMHg0MC8weDZjCj4+ICAgWzxmZmZmZmZjMDAwM2U5MmMwPl0gcmVzdG9yZV9m YmRldl9tb2RlKzB4Mjk0LzB4MmQ0Cj4+ICAgWzxmZmZmZmZjMDAwM2ViNmVjPl0gZHJtX2ZiX2hl bHBlcl9yZXN0b3JlX2ZiZGV2X21vZGVfdW5sb2NrZWQrMHgzNC8weDhjCj4+ICAgWzxmZmZmZmZj MDAwM2ViNzcwPl0gZHJtX2ZiX2hlbHBlcl9zZXRfcGFyKzB4MmMvMHg1OAo+PiAgIFs8ZmZmZmZm YzAwMDM3ODA0OD5dIGZiY29uX2luaXQrMHg0ZDQvMHg1MzQKPj4gICBbPGZmZmZmZmMwMDAzYjQ0 ZjQ+XSB2aXN1YWxfaW5pdCsweGFjLzB4MTA0Cj4+ICAgWzxmZmZmZmZjMDAwM2I2M2Y4Pl0gZG9f YmluZF9jb25fZHJpdmVyKzB4MTZjLzB4Mzk4Cj4+ICAgWzxmZmZmZmZjMDAwM2I2OTY4Pl0gZG9f dGFrZV9vdmVyX2NvbnNvbGUrMHhkOC8weDFmNAo+PiAgIFs8ZmZmZmZmYzAwMDM3ODExYz5dIGRv X2ZiY29uX3Rha2VvdmVyKzB4NzQvMHhmOAo+PiAgIFs8ZmZmZmZmYzAwMDM3YzVjYz5dIGZiY29u X2V2ZW50X25vdGlmeSsweDhhNC8weDhmOAo+PiAgIFs8ZmZmZmZmYzAwMDBkMTlmMD5dIG5vdGlm aWVyX2NhbGxfY2hhaW4rMHg0Yy8weDg4Cj4+ICAgWzxmZmZmZmZjMDAwMGQxZDc4Pl0gX19ibG9j a2luZ19ub3RpZmllcl9jYWxsX2NoYWluKzB4NDQvMHg3NAo+PiAgIFs8ZmZmZmZmYzAwMDBkMWRi Yz5dIGJsb2NraW5nX25vdGlmaWVyX2NhbGxfY2hhaW4rMHgxNC8weDFjCj4+ICAgWzxmZmZmZmZj MDAwMzdkNjE0Pl0gZmJfbm90aWZpZXJfY2FsbF9jaGFpbisweDFjLzB4MjQKPj4gICBbPGZmZmZm ZmMwMDAzN2Y4YTg+XSByZWdpc3Rlcl9mcmFtZWJ1ZmZlcisweDFjMC8weDJhYwo+PiAgIFs8ZmZm ZmZmYzAwMDNlYjlmOD5dIGRybV9mYl9oZWxwZXJfaW5pdGlhbF9jb25maWcrMHgyNWMvMHgzZWMK Pj4gICBbPGZmZmZmZmMwMDAzZWMyOGM+XSBkcm1fZmJkZXZfY21hX2luaXQrMHg5OC8weDEzNAo+ PiAgIFs8ZmZmZmZmYmZmYzAwNjc4MD5dIGhkbGNkX2RybV9iaW5kKzB4MTgwLzB4NDk4IFtoZGxj ZF0KPj4gICBbPGZmZmZmZmMwMDA0MTU4ZTA+XSB0cnlfdG9fYnJpbmdfdXBfbWFzdGVyLnBhcnQu NSsweGQ0LzB4MTE4Cj4+ICAgWzxmZmZmZmZjMDAwNDE1OWU4Pl0gY29tcG9uZW50X21hc3Rlcl9h ZGRfd2l0aF9tYXRjaCsweGM0LzB4MTQ4Cj4+ICAgWzxmZmZmZmZjMDAwNDE1YTdjPl0gY29tcG9u ZW50X21hc3Rlcl9hZGQrMHgxMC8weDE4Cj4+ICAgWzxmZmZmZmZiZmZjMDA2NWVjPl0gaGRsY2Rf cHJvYmUrMHgxNC8weDI4IFtoZGxjZF0KPj4gICBbPGZmZmZmZmMwMDA0MWM1MDQ+XSBwbGF0Zm9y bV9kcnZfcHJvYmUrMHg1NC8weGMwCj4+ICAgWzxmZmZmZmZjMDAwNDFhOWIwPl0gZHJpdmVyX3By b2JlX2RldmljZSsweDFlYy8weDJlOAo+PiAgIFs8ZmZmZmZmYzAwMDQxYWI0OD5dIF9fZHJpdmVy X2F0dGFjaCsweDljLzB4YTAKPj4gICBbPGZmZmZmZmMwMDA0MThiY2M+XSBidXNfZm9yX2VhY2hf ZGV2KzB4NTgvMHg5OAo+PiAgIFs8ZmZmZmZmYzAwMDQxYTQxYz5dIGRyaXZlcl9hdHRhY2grMHgy MC8weDI4Cj4+ICAgWzxmZmZmZmZjMDAwNDFhMDU4Pl0gYnVzX2FkZF9kcml2ZXIrMHgxYzgvMHgy MmMKPj4gICBbPGZmZmZmZmMwMDA0MWIzZDA+XSBkcml2ZXJfcmVnaXN0ZXIrMHg2OC8weDEwOAo+ PiAgIFs8ZmZmZmZmYzAwMDQxYzQwOD5dIF9fcGxhdGZvcm1fZHJpdmVyX3JlZ2lzdGVyKzB4NGMv MHg1NAo+PiAgIFs8ZmZmZmZmYmZmYzAwYjAxOD5dIGhkbGNkX2luaXQrMHgxOC8weDMwIFtoZGxj ZF0KPj4gICBbPGZmZmZmZmMwMDAwODI5M2M+XSBkb19vbmVfaW5pdGNhbGwrMHg5MC8weDFhOAo+ PiAgIFs8ZmZmZmZmYzAwMDE0MjRkYz5dIGRvX2luaXRfbW9kdWxlKzB4NjAvMHgxYzgKPj4gICBb PGZmZmZmZmMwMDAxMWQzNjQ+XSBsb2FkX21vZHVsZSsweDE1NTQvMHgxYzk4Cj4+ICAgWzxmZmZm ZmZjMDAwMTFkYzY0Pl0gU3lTX2Zpbml0X21vZHVsZSsweDdjLzB4ODgKPj4gICBbPGZmZmZmZmMw MDAwODVjYjA+XSBlbDBfc3ZjX25ha2VkKzB4MjQvMHgyOAo+Pgo+Pgo+PiAgIFRoZSBsaW5lIHRo YXQgdHJpZ2dlcnMgdGhlIHdhcm5pbmcgaXM6Cj4+Cj4+ICAgNjc0OiAgICAgICAgICAgICAgICAg ICAgV0FSTl9PTighY29ubmVjdG9yLT5lbmNvZGVyLT5jcnRjKTsKPj4KPj4gICBBcyBmYXIgYXMg SSBjYW4gc2VlIHRoZSBlbmNvZGVyLT5jcnRjIHZhbHVlIGlzIGJlaW5nIHNldCB0byBhIG5vbi1O VUxMIHZhbHVlIG9ubHkKPj4gICBpbiB0d28gcGxhY2VzOgo+PiAgICAtIGluIGRybV9hdG9taWNf aGVscGVyX3VwZGF0ZV9sZWdhY3lfbW9kZXNldF9zdGF0ZSgpIGFmdGVyIFdBUk5fT04oKQo+PiAg ICAgICAgICAgICAgICAgICBlbmNvZGVyLT5jcnRjID0gY29ubmVjdG9yLT5zdGF0ZS0+Y3J0YzsK Pj4gICAgLSBpbiBkcm1fY3J0Y19oZWxwZXJfc2V0X2NvbmZpZyhkcm1fbW9kZV9zZXQgKnNldCk6 Cj4+ICAgICAgICAgICAgICAgICAgIGVuY29kZXItPmNydGMgPSBuZXdfY3J0YzsKPj4KPj4gICBO b3RoaW5nIGluIHRoZSBjYWxsIHBhdGggZnJvbSBkcm1fYXRvbWljX2NvbW1pdCgpIGNhbGxzIGNy dGNfZnVuY3MtPnNldF9jb25maWcoKSBvcgo+PiAgIGRybV9jcnRjX2hlbHBlcl9zZXRfY29uZmln KCkgZGlyZWN0bHksIHNvIHRoZSBxdWVzdGlvbiBpcyBpZiB0aGlzIFdBUk4oKSBpcyBhY3R1YWxs eQo+PiAgIHZhbGlkLgo+Pgo+PiAgIENhbGwgcGF0aCBmcm9tIGRybV9hdG9taWNfY29tbWl0Ogo+ Pgo+PiAgIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdCgpCj4+ICAgICAtIGRybV9hdG9taWNfaGVs cGVyX3ByZXBhcmVfcGxhbmVzKCkKPj4gICAgIC0gZHJtX2F0b21pY19oZWxwZXJfc3dhcF9zdGF0 ZSgpCj4+ICAgICAtIGRybV9hdG9taWNfaGVscGVyX2NvbW1pdF9tb2Rlc2V0X2Rpc2FibGVzKCkK Pj4gICAgICAgIC0gZGlzYWJsZV9vdXRwdXRzKCkKPj4gICAgICAgIC0gZHJtX2F0b21pY19oZWxw ZXJfdXBkYXRlX2xlZ2FjeV9tb2Rlc2V0X3N0YXRlKCkKPj4gICAgICAgICAgIC0gV0FSTl9PTigh Y29ubmVjdG9yLT5lbmNvZGVyLT5jcnRjKQo+Pgo+PiAgIEJlc3QgcmVnYXJkcywKPj4gICBMaXZp dQo+Pgo+Pgo+PiAgICAgSGkgTGl2aXUKPj4gICAgICAgICAgIEkgc29sdmVkIHRoaXMgcHJvYmxl bSBieSBmb2xsb3dpbmcgY2hhbmdlLCB5b3UgY2FuIGNoZWNrIGlmIHlvdXIgZHJpdmVyIGRvIHRo ZSBzYW1lIHRoaW5nczoKPj4gICAgICAgICAgICBkcml2ZXJzL2dwdS9kcm0vYnJpZGdlL2R3X2hk bWkuYzoKPj4gICAgICAgICAgICAgICAtICAgICAgIGhkbWktPmNvbm5lY3Rvci5lbmNvZGVyID0g ZW5jb2RlcjsKPj4gICAgICAgICAgICAgICsvLyAgICAgaGRtaS0+Y29ubmVjdG9yLmVuY29kZXIg PSBlbmNvZGVyOwo+Pgo+PiAgICAgICAgICAgICAgICAgICAgICAgIGRybV9tb2RlX2Nvbm5lY3Rv cl9hdHRhY2hfZW5jb2RlcigmaGRtaS0+Y29ubmVjdG9yLCBlbmNvZGVyKTsKPj4KPj4gICAgICAg ICAgSSBmb3VuZCBzb21lIG90aGVyIGRyaXZlcnMgc2V0IGNvbm5lY3Rvci5lbmNvZGVyIGJlZm9y ZSBkcm1fbW9kZV9jb25uZWN0b3JfYXR0YWNoX2VuY29kZXIsIHNvbWUgYXJlIG5vdC4KPj4KPj4g ICAgICAgICAgZHJtX21vZGVfY29ubmVjdG9yX2F0dGFjaF9lbmNvZGVyIGFscmVhZHkgZGVzY3Jp YmUgdGhlIGxpbmsgb2YgY29ubmVjdG9yIGFuZCBlbmNvZGVyLAo+PiAgICAgc28gSSB0aGluayAi Y29ubmVjdG9yLmVuY29kZXIgPSBlbmNvZGVyIiBpcyBub3QgbmVlZGVkLCBpcyB0aGF0IHJpZ2h0 Pwo+IEknbGwgaGF2ZSBhIGxvb2ssIHRoYW5rcyBmb3IgcG9pbnRpbmcgdGhpcy4gSG93ZXZlciwg bXkgc2V0dXAgdXNlcyB0aGUgdGRhOTk4eCBkcml2ZXIgZm9yIGVuY29kZXIsIHNvIEkgd2lsbAo+ IGhhdmUgdG8gZ28gbG9vayB0aGVyZSByYXRoZXIgdGhhbiBpbiBteSBkcml2ZXIuCj4KPiBCZXN0 IHJlZ2FyZHMsCj4gTGl2aXUKPgo+PiAgICAgVGhhbmtzLgo+Pgo+PiAgIC0tCj4+ICAg77ytYXJr IFlhbwpIaSBMaXZpdQogICAgICBkcml2ZXJzL2dwdS9kcm0vaTJjL3RkYTk5OHhfZHJ2LmMgZG8g dGhlIHNhbWUgdGhpbmdzOgogICAgICAgICAgICAgcHJpdi0+Y29ubmVjdG9yLmVuY29kZXIgPSAm cHJpdi0+ZW5jb2RlcjsKZHJtX21vZGVfY29ubmVjdG9yX2F0dGFjaF9lbmNvZGVyKCZwcml2LT5j b25uZWN0b3IsICZwcml2LT5lbmNvZGVyKTsKCiAgICAgIEkgYmVsaWV2ZSBtdXN0IGJlIHNhbWUg cHJvYmxlbS4KClRoYW5rcy4KCi0tIArvvK1hcmsgWWFvCgoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754262AbbKLKtt (ORCPT ); Thu, 12 Nov 2015 05:49:49 -0500 Received: from regular1.263xmail.com ([211.150.99.132]:58515 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751048AbbKLKts (ORCPT ); Thu, 12 Nov 2015 05:49:48 -0500 X-263anti-spam: KSV:0;BIG:0;ABS:1;DNS:0;ATT:0;SPF:S; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 1 X-SKE-CHECKED: 1 X-ADDR-CHECKED: 0 X-RL-SENDER: mark.yao@rock-chips.com X-FST-TO: linux-kernel@vger.kernel.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: mark.yao@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <56446EC2.6020301@rock-chips.com> Date: Thu, 12 Nov 2015 18:49:38 +0800 From: Mark yao User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Liviu Dudau CC: Daniel Vetter , David Airlie , Rob Clark , DRI devel , lkml Subject: Re: drm: Bogus WARN() in drm_atomic_helper_update_legacy_modeset_state() ? References: <20151110150102.GP963@e106497-lin.cambridge.arm.com> <56444EA1.3050506@rock-chips.com> <20151112103618.GY963@e106497-lin.cambridge.arm.com> In-Reply-To: <20151112103618.GY963@e106497-lin.cambridge.arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2015年11月12日 18:36, Liviu Dudau wrote: > On Thu, Nov 12, 2015 at 04:32:33PM +0800, Mark yao wrote: >> On 2015年11月10日 23:01, Liviu Dudau wrote: >> >> Hello, >> >> When booting my Juno board with the HDLCD driver that I have converted to >> atomic operations I'm getting the following warning: >> >> ------------[ cut here ]------------ >> WARNING: at /work/repositories/kernel/drivers/gpu/drm/drm_atomic_helper.c:674 >> Modules linked in: hdlcd(+) clk_scpi >> >> CPU: 3 PID: 1375 Comm: systemd-udevd Not tainted 4.3.0-next-20151109+ #5 >> Hardware name: ARM Juno development board (r0) (DT) >> task: ffffffc974888b00 ti: ffffffc9755dc000 task.ti: ffffffc9755dc000 >> PC is at drm_atomic_helper_update_legacy_modeset_state+0x204/0x20c >> LR is at drm_atomic_helper_commit_modeset_disables+0x1c0/0x394 >> pc : [] lr : [] pstate: 20000145 >> sp : ffffffc9755df430 >> x29: ffffffc9755df430 x28: ffffffc975703600 >> x27: 0000000000000000 x26: ffffffc976253960 >> x25: ffffffc976254040 x24: ffffffc000819000 >> x23: ffffffc000689ea0 x22: ffffffc976251800 >> x21: ffffffc976251800 x20: 0000000000000000 >> x19: ffffffc9766b1f80 x18: 00000000715fe015 >> x17: 0000007fb4b855b0 x16: 0000000000000220 >> x15: 0000000000000001 x14: 0ffffffffffffffe >> x13: 0000000000000008 x12: 0101010101010101 >> x11: ffffffc000964000 x10: ffffffc0009d2000 >> x9 : 0000000000000000 x8 : ffffffc97ff5f700 >> x7 : ffffffc97566cb80 x6 : ffffffc9766b1700 >> x5 : ffffffc975665100 x4 : 0000000000000000 >> x3 : ffffffc976253960 x2 : ffffffc97566cd00 >> x1 : ffffffc976253900 x0 : 0000000000000000 >> >> ---[ end trace 9fe289f798e7178e ]--- >> Call trace: >> [] drm_atomic_helper_update_legacy_modeset_state+0x204/0x20c >> [] drm_atomic_helper_commit_modeset_disables+0x1c0/0x394 >> [] drm_atomic_helper_commit+0xe0/0x150 >> [] drm_atomic_commit+0x40/0x6c >> [] restore_fbdev_mode+0x294/0x2d4 >> [] drm_fb_helper_restore_fbdev_mode_unlocked+0x34/0x8c >> [] drm_fb_helper_set_par+0x2c/0x58 >> [] fbcon_init+0x4d4/0x534 >> [] visual_init+0xac/0x104 >> [] do_bind_con_driver+0x16c/0x398 >> [] do_take_over_console+0xd8/0x1f4 >> [] do_fbcon_takeover+0x74/0xf8 >> [] fbcon_event_notify+0x8a4/0x8f8 >> [] notifier_call_chain+0x4c/0x88 >> [] __blocking_notifier_call_chain+0x44/0x74 >> [] blocking_notifier_call_chain+0x14/0x1c >> [] fb_notifier_call_chain+0x1c/0x24 >> [] register_framebuffer+0x1c0/0x2ac >> [] drm_fb_helper_initial_config+0x25c/0x3ec >> [] drm_fbdev_cma_init+0x98/0x134 >> [] hdlcd_drm_bind+0x180/0x498 [hdlcd] >> [] try_to_bring_up_master.part.5+0xd4/0x118 >> [] component_master_add_with_match+0xc4/0x148 >> [] component_master_add+0x10/0x18 >> [] hdlcd_probe+0x14/0x28 [hdlcd] >> [] platform_drv_probe+0x54/0xc0 >> [] driver_probe_device+0x1ec/0x2e8 >> [] __driver_attach+0x9c/0xa0 >> [] bus_for_each_dev+0x58/0x98 >> [] driver_attach+0x20/0x28 >> [] bus_add_driver+0x1c8/0x22c >> [] driver_register+0x68/0x108 >> [] __platform_driver_register+0x4c/0x54 >> [] hdlcd_init+0x18/0x30 [hdlcd] >> [] do_one_initcall+0x90/0x1a8 >> [] do_init_module+0x60/0x1c8 >> [] load_module+0x1554/0x1c98 >> [] SyS_finit_module+0x7c/0x88 >> [] el0_svc_naked+0x24/0x28 >> >> >> The line that triggers the warning is: >> >> 674: WARN_ON(!connector->encoder->crtc); >> >> As far as I can see the encoder->crtc value is being set to a non-NULL value only >> in two places: >> - in drm_atomic_helper_update_legacy_modeset_state() after WARN_ON() >> encoder->crtc = connector->state->crtc; >> - in drm_crtc_helper_set_config(drm_mode_set *set): >> encoder->crtc = new_crtc; >> >> Nothing in the call path from drm_atomic_commit() calls crtc_funcs->set_config() or >> drm_crtc_helper_set_config() directly, so the question is if this WARN() is actually >> valid. >> >> Call path from drm_atomic_commit: >> >> drm_atomic_helper_commit() >> - drm_atomic_helper_prepare_planes() >> - drm_atomic_helper_swap_state() >> - drm_atomic_helper_commit_modeset_disables() >> - disable_outputs() >> - drm_atomic_helper_update_legacy_modeset_state() >> - WARN_ON(!connector->encoder->crtc) >> >> Best regards, >> Liviu >> >> >> Hi Liviu >> I solved this problem by following change, you can check if your driver do the same things: >> drivers/gpu/drm/bridge/dw_hdmi.c: >> - hdmi->connector.encoder = encoder; >> +// hdmi->connector.encoder = encoder; >> >> drm_mode_connector_attach_encoder(&hdmi->connector, encoder); >> >> I found some other drivers set connector.encoder before drm_mode_connector_attach_encoder, some are not. >> >> drm_mode_connector_attach_encoder already describe the link of connector and encoder, >> so I think "connector.encoder = encoder" is not needed, is that right? > I'll have a look, thanks for pointing this. However, my setup uses the tda998x driver for encoder, so I will > have to go look there rather than in my driver. > > Best regards, > Liviu > >> Thanks. >> >> -- >> Ｍark Yao Hi Liviu drivers/gpu/drm/i2c/tda998x_drv.c do the same things: priv->connector.encoder = &priv->encoder; drm_mode_connector_attach_encoder(&priv->connector, &priv->encoder); I believe must be same problem. Thanks. -- Ｍark Yao