From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@citrix.com>
Subject: Re: [PATCH v3 2/2] arm: export platform_op
	XENPF_settime64
Date: Thu, 12 Nov 2015 11:31:53 +0000
Message-ID: <564478A9.4070909@citrix.com>
References: <alpine.DEB.2.02.1511111712230.526@kaball.uk.xensource.com>
	<1447262371-1555-2-git-send-email-stefano.stabellini@eu.citrix.com>
	<56437C57.4000900@citrix.com>
	<alpine.DEB.2.02.1511111738110.526@kaball.uk.xensource.com>
	<564387AB.5070005@citrix.com>
	<alpine.DEB.2.02.1511121131241.526@kaball.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <alpine.DEB.2.02.1511121131241.526@kaball.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: dgdegra@tycho.nsa.gov, xen-devel@lists.xensource.com, Ian.Campbell@citrix.com
List-Id: xen-devel@lists.xenproject.org

On 12/11/15 11:32, Stefano Stabellini wrote:
> On Wed, 11 Nov 2015, Julien Grall wrote:
>> On 11/11/15 18:14, Stefano Stabellini wrote:
>>> On Wed, 11 Nov 2015, Julien Grall wrote:
>>>>> diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c
>>>>> index 1418092..aa0fde6 100644
>>>>> --- a/xen/arch/arm/vtimer.c
>>>>> +++ b/xen/arch/arm/vtimer.c
>>>>> @@ -22,13 +22,13 @@
>>>>>  #include <xen/timer.h>
>>>>>  #include <xen/sched.h>
>>>>>  #include <xen/perfc.h>
>>>>> +#include <asm/div64.h>
>>>>>  #include <asm/irq.h>
>>>>>  #include <asm/time.h>
>>>>>  #include <asm/gic.h>
>>>>>  #include <asm/vgic.h>
>>>>>  #include <asm/regs.h>
>>>>>  
>>>>> -extern s_time_t ticks_to_ns(uint64_t ticks);
>>>>
>>>> If it's a valid change you should mention it in the commit message
>>>> because it's not related to this patch.
>>>>
>>>> Otherwise it looks spurious...
>>>
>>> Sorry, that's not a valid change anymore, I meant to remove it. Thanks
>>> for checking.
>>
>> If it wasn't clear, I think this change is valid. Defining the prototype
>> in the C file is a call to have the prototype not matching the declaration.
>>
>> Any prototypes should be declared in the header and not that way.
>>
>> I'm fine with this, but it should be mentioned in the commit message.
> 
> It might be a decent change to have, but it is not needed by this patch
> anymore, so if anything it should go in on its own.

I'm fine with that.

Regards,

-- 
Julien Grall