All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Lieven <pl@kamp.de>
To: Fam Zheng <famz@redhat.com>
Cc: kwolf@redhat.com, qemu-block@nongnu.org, stefanha@gmail.com,
	jcody@redhat.com, qemu-devel@nongnu.org, jsnow@redhat.com
Subject: Re: [Qemu-devel] [PATCH V3 0/6] ide: avoid main-loop hang on CDROM/NFS failure
Date: Thu, 12 Nov 2015 12:46:37 +0100	[thread overview]
Message-ID: <56447C1D.8000302@kamp.de> (raw)
In-Reply-To: <20151112113303.GU4082@ad.usersys.redhat.com>

Am 12.11.2015 um 12:33 schrieb Fam Zheng:
> On Fri, 11/06 09:42, Peter Lieven wrote:
>> This series aims at avoiding a hanging main-loop if a vserver has a
>> CDROM image mounted from a NFS share and that NFS share goes down.
>> Typical situation is that users mount an CDROM ISO to install something
>> and then forget to eject that CDROM afterwards.
>> As a consequence this mounted CD is able to bring down the
>> whole vserver if the backend NFS share is unreachable. This is bad
>> especially if the CDROM itself is not needed anymore at this point.
> If a storage backend is lost, would QEMU hang on guest reboot with this patch?
> If so, just for understanding the problem, what is the use case this series
> addresses?

Qemu would hang whenever the next request to the CDROM is made.
This usually happens as soon as the CDROM is mounted (at least in Windows guests)
even if there is no CDROM activity intiated by the user. This brings down every guest
where the user just forgot to unmount the CDROM just because some NFS storage is
unreachable.

>
> The code looks good to me apart from the two questions I left, and that I
> didn't fully understand the elementary transfer part.

That indeed is not obvious. There was a long discussion on that topic in V1 of this series.

Thanks,
Peter

      reply	other threads:[~2015-11-12 11:46 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-06  8:42 [Qemu-devel] [PATCH V3 0/6] ide: avoid main-loop hang on CDROM/NFS failure Peter Lieven
2015-11-06  8:42 ` [Qemu-devel] [PATCH V3 1/6] ide/atapi: make PIO read requests async Peter Lieven
2015-11-09 23:35   ` John Snow
2015-11-06  8:42 ` [Qemu-devel] [PATCH V3 2/6] block: add blk_abort_aio_request Peter Lieven
2015-11-12  8:17   ` Fam Zheng
2015-11-06  8:42 ` [Qemu-devel] [PATCH V3 3/6] ide: add support for IDEBufferedRequest Peter Lieven
2015-11-12  9:57   ` Fam Zheng
2015-11-12 10:21     ` Peter Lieven
2015-11-06  8:42 ` [Qemu-devel] [PATCH V3 4/6] ide: orphan all buffered requests on DMA cancel Peter Lieven
2015-11-12  8:27   ` Fam Zheng
2015-11-12  8:45     ` Peter Lieven
2015-11-06  8:42 ` [Qemu-devel] [PATCH V3 5/6] ide: enable buffered requests for ATAPI devices Peter Lieven
2015-11-12 11:25   ` Fam Zheng
2015-11-12 11:42     ` Peter Lieven
2015-11-06  8:42 ` [Qemu-devel] [PATCH V3 6/6] ide: enable buffered requests for PIO read requests Peter Lieven
2015-11-12 11:33 ` [Qemu-devel] [PATCH V3 0/6] ide: avoid main-loop hang on CDROM/NFS failure Fam Zheng
2015-11-12 11:46   ` Peter Lieven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56447C1D.8000302@kamp.de \
    --to=pl@kamp.de \
    --cc=famz@redhat.com \
    --cc=jcody@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.