All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Jörg Rödel" <joro@8bytes.org>, "kvm ML" <kvm@vger.kernel.org>,
	lkml <linux-kernel@vger.kernel.org>
Subject: Re: Shut up unhandled MSR warnings
Date: Thu, 12 Nov 2015 13:28:16 +0100	[thread overview]
Message-ID: <564485E0.9040902@redhat.com> (raw)
In-Reply-To: <20151112121613.GC3838@pd.tnic>



On 12/11/2015 13:16, Borislav Petkov wrote:
>>> > > Yes, see guest_cpuid_has_* for an example of reading the CPUID values.
>>> > > 
>>> > > But if it's defined for _all_ models starting at family 21, we can just
>>> > > do it unconditionally.
>> > 
>> > The thing is, those bits are Reserved again on the next family 22. Lemme
>> > take a look at guest_cpuid_has_* and see how ugly it gets.
> 
> Ok, I see there's guest_cpuid_is_amd() but I'd need also family and model.
> 
> How about adding also
> 
> guest_cpuid_family(), guest_cpuid_model(), guest_cpuid_stepping()? Those
> could be quite useful in other contexts maybe.

Sure, that's what I meant by "for an example". :)

Paolo

      reply	other threads:[~2015-11-12 12:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 10:13 Shut up unhandled MSR warnings Borislav Petkov
2015-11-12 10:33 ` Paolo Bonzini
2015-11-12 10:59   ` Borislav Petkov
2015-11-12 12:16     ` Borislav Petkov
2015-11-12 12:28       ` Paolo Bonzini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564485E0.9040902@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=bp@alien8.de \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.