Re: Regression in btrfs: properly set the termination value of ctx->pos in readdir

["Holger Hoffstätte" <holger.hoffstaette@googlemail.com>]

On 11/12/15 14:09, David Sterba wrote:
> On Thu, Nov 12, 2015 at 11:35:23AM +0100, David Sterba wrote:
>> On Wed, Nov 11, 2015 at 01:22:19PM +0100, Holger Hoffstätte wrote:
>>>> the patch btrfs: properly set the termination value of ctx->pos in
>>>> readdir introduces a regression to me.
>>>>
>>>> A lot of stuff runs in "endless" or long running loops.
>>>
>>> Just tested this and can confirm something is off.
>>> In a directory with several files, create a new directory and move all
>>> files into the new subdir.
>>>
>>> An immediately following ls will hang. The problem goes away after a
>>> manual sync.
>>
>> I can reproduce the hang, thanks.
> 
> The hang was triggered by use of trace_printk and I'm seeing several
> strange bugs caused by added debugging, so I can't say I can reproduce
> it yet.

Be that as it may, the procedure I described above immediately started to
work again when I backed out this patch. I also didn't noctice anything
wrong before Stefan's email, so it's apparently not easy to hit.

-h