From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1ZwsBn-00012s-9u for mharc-grub-devel@gnu.org; Thu, 12 Nov 2015 08:45:23 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37495) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwsBl-00012m-7A for grub-devel@gnu.org; Thu, 12 Nov 2015 08:45:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwsBk-0004Af-CR for grub-devel@gnu.org; Thu, 12 Nov 2015 08:45:21 -0500 Received: from mail-wm0-x22c.google.com ([2a00:1450:400c:c09::22c]:38831) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwsBk-0004Ab-5t for grub-devel@gnu.org; Thu, 12 Nov 2015 08:45:20 -0500 Received: by wmec201 with SMTP id c201so92047014wme.1 for ; Thu, 12 Nov 2015 05:45:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type; bh=OOP3moikNlcm2A1WmZDZQ7Ea8yKZV/nJiFfTcZu2Otc=; b=WxW4ioskURZcwul6YSfvO5oGF4V0dR5cpALAGRSRS27b347LxIQmkbgw679XhnChUh /yxthwOVokvOK+GorK8/eHDIqmIOVlp9cfjuoiDcaKXROKctagQoBHxBJW98LL9kPov8 kjEg9BKnQtOArOlmZzdliwIbIw5Mi3LHVE/woQeNStl50l9JTQV9/sQI5y/OL0q5bUGO s278fxvtfm1f76+wGH5vfDyRA8jZIx4dKLe0m5qdn8gfImcm15rwuBU4w+945ztEGA4w bPHpknxBkN8XUQjGI6RAE772js8a3EYaKSAmrI8GDATO2IHPLQSA0i4WEVQGnsruvH0H OD2w== X-Received: by 10.194.186.238 with SMTP id fn14mr18044373wjc.128.1447335919574; Thu, 12 Nov 2015 05:45:19 -0800 (PST) Received: from ?IPv6:2620:0:105f:fd00:863a:4bff:fe50:abc4? ([2620:0:105f:fd00:863a:4bff:fe50:abc4]) by smtp.gmail.com with ESMTPSA id l1sm3996238wmb.1.2015.11.12.05.45.18 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 12 Nov 2015 05:45:18 -0800 (PST) Subject: Re: [PATCH v2 3/6] i386/relocator: Add grub_relocator64_efi relocator To: Daniel Kiper References: <1437402954-7375-1-git-send-email-daniel.kiper@oracle.com> <1437402954-7375-4-git-send-email-daniel.kiper@oracle.com> <5640FC7B.9080206@gmail.com> <20151110143833.GS26902@olila.local.net-space.pl> From: =?UTF-8?Q?Vladimir_'=cf=86-coder/phcoder'_Serbinenko?= Message-ID: <564497ED.3050709@gmail.com> Date: Thu, 12 Nov 2015 14:45:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: <20151110143833.GS26902@olila.local.net-space.pl> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="5cRRWIGrI4eIfe7qvuR0mKbmKjdDg6v2s" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a00:1450:400c:c09::22c Cc: jgross@suse.com, grub-devel@gnu.org, keir@xen.org, ian.campbell@citrix.com, andrew.cooper3@citrix.com, stefano.stabellini@eu.citrix.com, roy.franz@linaro.org, ning.sun@intel.com, david.vrabel@citrix.com, jbeulich@suse.com, wei.liu2@citrix.com, xen-devel@lists.xenproject.org, qiaowei.ren@intel.com, richard.l.maliszewski@intel.com, gang.wei@intel.com, fu.wei@linaro.org X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2015 13:45:22 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --5cRRWIGrI4eIfe7qvuR0mKbmKjdDg6v2s Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 10.11.2015 15:38, Daniel Kiper wrote: >>> - if (entry_specified) >>> > > + if (keep_bs && efi_entry_specified) >>> > > + grub_multiboot_payload_eip =3D efi_entry; >>> > > + else if (entry_specified) >>> > > grub_multiboot_payload_eip =3D entry; >>> > > >> > This seems redundant. > What is wrong here? I just mean that if we use a single structure this code could go away --5cRRWIGrI4eIfe7qvuR0mKbmKjdDg6v2s Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREKAAYFAlZEl+0ACgkQmBXlbbo5nOswogD+JfylWRykCzFj1m4OyyXaAp9+ iF08P4N90ba0lH3Wr6YA/3JxJ4mJuQx/x3nKLG7SMNd8UbxCZbR8LIXftycIbg3P =e0Q2 -----END PGP SIGNATURE----- --5cRRWIGrI4eIfe7qvuR0mKbmKjdDg6v2s--