All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: John Snow <jsnow@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH] configure: check for $cxx before use
Date: Thu, 12 Nov 2015 17:47:13 +0100	[thread overview]
Message-ID: <5644C291.7080302@redhat.com> (raw)
In-Reply-To: <1447345789-840-1-git-send-email-jsnow@redhat.com>



On 12/11/2015 17:29, John Snow wrote:
> I broke this when adding checks for clang++.
> 
> Reported-by: Laurent Vivier <lvivier@redhat.com>
> Signed-off-by: John Snow <jsnow@redhat.com>
> 
> ---
>  configure | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index 46fd8bd..f75df4b 100755
> --- a/configure
> +++ b/configure
> @@ -4435,7 +4435,8 @@ fi
>  if test "$fortify_source" != "no"; then
>    if echo | $cc -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
>      fortify_source="no";
> -  elif echo | $cxx -dM -E - | grep __clang__ > /dev/null 2>&1 ; then
> +  elif test -n "$cxx" &&
> +       echo | $cxx -dM -E - | grep __clang__ >/dev/null 2>&1 ; then
>      fortify_source="no";
>    else
>      fortify_source="yes"
> 

This fixes the problem: no more error message.

Thanks,
Laurent

  reply	other threads:[~2015-11-12 16:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-12 16:29 [Qemu-devel] [PATCH] configure: check for $cxx before use John Snow
2015-11-12 16:47 ` Laurent Vivier [this message]
2015-11-12 16:54 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5644C291.7080302@redhat.com \
    --to=lvivier@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.