From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Cooper Subject: Re: [PATCH v2] ns16550: misc minor adjustments Date: Thu, 12 Nov 2015 16:53:36 +0000 Message-ID: <5644C410.6020701@citrix.com> References: <5644BF9302000078000B4535@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Zwv83-0000aw-IN for xen-devel@lists.xenproject.org; Thu, 12 Nov 2015 16:53:43 +0000 In-Reply-To: <5644BF9302000078000B4535@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Jan Beulich , xen-devel Cc: Ian Campbell , Ian Jackson , Keir Fraser , Tim Deegan List-Id: xen-devel@lists.xenproject.org On 12/11/15 15:34, Jan Beulich wrote: > First and foremost: fix documentation: The use of "clock_hz", when > "base_baud" was meant, has taken me several hours (suspecting a more > complicated problem with the PCIe card I've been trying to get > working). At once correct the "gdb" option, which is more like > "console", not like "com". > > Next, fix the types of ns_{read,write}_reg(): Especially the former > having had a signed return type so far caused quite interesting effects > when determining to baud rate if "auto" was specified. In that same > code, also avoid dividing by zero when in fact the baud rate was not > previously set up. > > Further, accept I/O port based serial PCI cards with a port range wider > than 8 bytes. > > Finally, slightly rearrange struct ns16550 to reduce holes. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper with one tweak > --- > v2: Log a message when reading zero divisor. Make an attempt at > explaining what "base baud rate" means. > > --- a/docs/misc/xen-command-line.markdown > +++ b/docs/misc/xen-command-line.markdown > @@ -277,13 +277,14 @@ Flag to indicate whether to probe for a > ACPI indicating none to be there. > > ### com1,com2 > -> `= [/][,[DPS][,[|pci|amt][,[][,[][,[]]]]]]` > +> `= [/][,[DPS][,[|pci|amt][,[][,[][,[]]]]]]` > > Both option `com1` and `com2` follow the same format. > > * `` may be either an integer baud rate, or the string `auto` if > the bootloader or other earlier firmware has already set it up. > -* Optionally, a clock speed measured in hz can be specified. > +* Optionally, the base baud rate (usually the highest baud rate the > + device can communicate at) can be specified. > * `DPS` represents the number of data bits, the parity, and the number > of stop bits. > * `D` is an integer between 5 and 8 for the number of data bits. > @@ -730,9 +731,11 @@ Controls EPT related features. > >> Have hardware keep accessed/dirty (A/D) bits updated. > > ### gdb > -> `= [/][,DPS[,[,[,[,]]]] | pci | amt ] ` > +> `= com1[H,L] | com2[H,L] | dbgp` > > -Specify the serial parameters for the GDB stub. > +> Default: `` > + > +Specify which console gdbstub should use. See `console`. Elsewhere in the document, bold is used to refer to other options, so "see **console**". ~Andrew