From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754348AbbKLSCO (ORCPT ); Thu, 12 Nov 2015 13:02:14 -0500 Received: from smtp105.iad3a.emailsrvr.com ([173.203.187.105]:52380 "EHLO smtp105.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753992AbbKLSCM (ORCPT ); Thu, 12 Nov 2015 13:02:12 -0500 X-Auth-ID: abbotti@mev.co.uk X-Sender-Id: abbotti@mev.co.uk Subject: Re: [PATCH] comedi: cb_pcidda: Fix coding style - use BIT macro To: Ranjith Thangavel , gregkh@linuxfoundation.org References: <1447259271-14326-1-git-send-email-ranjithece24@gmail.com> Cc: hsweeten@visionengravers.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Ian Abbott Message-ID: <5644D422.7090601@mev.co.uk> Date: Thu, 12 Nov 2015 18:02:10 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447259271-14326-1-git-send-email-ranjithece24@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/15 16:27, Ranjith Thangavel wrote: > BIT macro is used for defining BIT location instead of > shifting operator - coding style issue > > Signed-off-by: Ranjith Thangavel > --- > drivers/staging/comedi/drivers/cb_pcidda.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/comedi/drivers/cb_pcidda.c b/drivers/staging/comedi/drivers/cb_pcidda.c > index b00a36a..ccb37d1 100644 > --- a/drivers/staging/comedi/drivers/cb_pcidda.c > +++ b/drivers/staging/comedi/drivers/cb_pcidda.c > @@ -51,13 +51,13 @@ > > /* DAC registers */ > #define CB_DDA_DA_CTRL_REG 0x00 /* D/A Control Register */ > -#define CB_DDA_DA_CTRL_SU (1 << 0) /* Simultaneous update */ > -#define CB_DDA_DA_CTRL_EN (1 << 1) /* Enable specified DAC */ > +#define CB_DDA_DA_CTRL_SU BIT(0) /* Simultaneous update */ > +#define CB_DDA_DA_CTRL_EN BIT(1) /* Enable specified DAC */ > #define CB_DDA_DA_CTRL_DAC(x) ((x) << 2) /* Specify DAC channel */ > #define CB_DDA_DA_CTRL_RANGE2V5 (0 << 6) /* 2.5V range */ > #define CB_DDA_DA_CTRL_RANGE5V (2 << 6) /* 5V range */ > #define CB_DDA_DA_CTRL_RANGE10V (3 << 6) /* 10V range */ > -#define CB_DDA_DA_CTRL_UNIP (1 << 8) /* Unipolar range */ > +#define CB_DDA_DA_CTRL_UNIP BIT(8) /* Unipolar range */ > > #define DACALIBRATION1 4 /* D/A CALIBRATION REGISTER 1 */ > /* write bits */ > Thanks! Reviewed-by: Ian Abbott -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-