From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1Zwwgl-0005kV-1H for mharc-qemu-trivial@gnu.org; Thu, 12 Nov 2015 13:33:39 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwwgf-0005dk-Qv for qemu-trivial@nongnu.org; Thu, 12 Nov 2015 13:33:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zwwge-0005G0-TZ for qemu-trivial@nongnu.org; Thu, 12 Nov 2015 13:33:33 -0500 Received: from isrv.corpit.ru ([86.62.121.231]:33847) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZwwgX-0005Ch-IM; Thu, 12 Nov 2015 13:33:25 -0500 Received: from [192.168.88.2] (mjt.vpn.tls.msk.ru [192.168.177.99]) by isrv.corpit.ru (Postfix) with ESMTP id 22F3341335; Thu, 12 Nov 2015 21:33:17 +0300 (MSK) Message-ID: <5644DB6D.4030308@msgid.tls.msk.ru> Date: Thu, 12 Nov 2015 21:33:17 +0300 From: Michael Tokarev Organization: Telecom Service, JSC User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.8.0 MIME-Version: 1.0 To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org References: <5644D222.3070408@suse.de> In-Reply-To: <5644D222.3070408@suse.de> OpenPGP: id=804465C5 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 86.62.121.231 Cc: qemu-trivial@nongnu.org, Cao jin Subject: Re: [Qemu-trivial] [PULL 17/24] qom/object: fix 2 comment typos X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Nov 2015 18:33:37 -0000 12.11.2015 20:53, Andreas F=E4rber wrote: > Am 06.11.2015 um 13:43 schrieb Michael Tokarev: >> From: Cao jin >> >> Also change the misleading definition of macro OBJECT_CLASS_CHECK >> >> Signed-off-by: Cao jin >> Signed-off-by: Michael Tokarev >=20 > Michael, please *STOP* queuing QOM patches! You merged the unfixed I think I do more harm to the project than good, these days. > version now - it's supposed to have just "qom:", and the parenthesis an= d > full stop are missing, too, that I had on qom-next before it disappeare= d > with today's rebase... >=20 > And why was I not CC'ed on this submission as include/qom/object.h > maintainer? You did not reply to the patch either, where I did. I didn't reply there because I wanted to remove the patch, exactly because you replied to the thread. It looks like I forgot to remove it from the -trivial tree. Now, in the original thread, you said you only tweaked the commit (subject) message. Is it really that bad in the original submission? Thanks, /mjt From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zwwgd-0005bq-VQ for qemu-devel@nongnu.org; Thu, 12 Nov 2015 13:33:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZwwgX-0005Ev-PV for qemu-devel@nongnu.org; Thu, 12 Nov 2015 13:33:29 -0500 Message-ID: <5644DB6D.4030308@msgid.tls.msk.ru> Date: Thu, 12 Nov 2015 21:33:17 +0300 From: Michael Tokarev MIME-Version: 1.0 References: <5644D222.3070408@suse.de> In-Reply-To: <5644D222.3070408@suse.de> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PULL 17/24] qom/object: fix 2 comment typos List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= , qemu-devel@nongnu.org Cc: qemu-trivial@nongnu.org, Cao jin 12.11.2015 20:53, Andreas F=E4rber wrote: > Am 06.11.2015 um 13:43 schrieb Michael Tokarev: >> From: Cao jin >> >> Also change the misleading definition of macro OBJECT_CLASS_CHECK >> >> Signed-off-by: Cao jin >> Signed-off-by: Michael Tokarev >=20 > Michael, please *STOP* queuing QOM patches! You merged the unfixed I think I do more harm to the project than good, these days. > version now - it's supposed to have just "qom:", and the parenthesis an= d > full stop are missing, too, that I had on qom-next before it disappeare= d > with today's rebase... >=20 > And why was I not CC'ed on this submission as include/qom/object.h > maintainer? You did not reply to the patch either, where I did. I didn't reply there because I wanted to remove the patch, exactly because you replied to the thread. It looks like I forgot to remove it from the -trivial tree. Now, in the original thread, you said you only tweaked the commit (subject) message. Is it really that bad in the original submission? Thanks, /mjt